From: Tomeu Vizoso <tomeu.vizoso@collabora.com>
To: Tomeu Vizoso <tomeu.vizoso@collabora.com>,
open list <linux-kernel@vger.kernel.org>,
Rob Herring <robh@kernel.org>, David Airlie <airlied@linux.ie>,
dri-devel <dri-devel@lists.freedesktop.org>
Cc: Daniel Vetter <daniel@ffwll.ch>
Subject: Re: [PATCH] drm/panfrost: Add sanity checks to submit IOCTL
Date: Wed, 24 Apr 2019 16:38:29 +0200 [thread overview]
Message-ID: <CAAObsKAnCt2wfip6QsJy0fXyq1mNr02oghUO9qt_OC_EQh6q_A@mail.gmail.com> (raw)
In-Reply-To: <20190424132019.GS9857@phenom.ffwll.local>
On Wed, 24 Apr 2019 at 15:20, Daniel Vetter <daniel@ffwll.ch> wrote:
>
> On Wed, Apr 24, 2019 at 03:13:53PM +0200, Tomeu Vizoso wrote:
> > So userspace can get feedback on any error conditions, instead of going
> > ahead and things breaking later.
> >
> > Signed-off-by: Tomeu Vizoso <tomeu.vizoso@collabora.com>
>
> Bonus: some igts to exercise these corner cases. It helps a lot with uapi
> review and testing.
I'm rebasing that igt branch as we speak :)
Tomeu
> -Daniel
>
> > ---
> > drivers/gpu/drm/panfrost/panfrost_drv.c | 35 +++++++++++++++++--------
> > 1 file changed, 24 insertions(+), 11 deletions(-)
> >
> > diff --git a/drivers/gpu/drm/panfrost/panfrost_drv.c b/drivers/gpu/drm/panfrost/panfrost_drv.c
> > index c06af78ab833..0f2863cb8077 100644
> > --- a/drivers/gpu/drm/panfrost/panfrost_drv.c
> > +++ b/drivers/gpu/drm/panfrost/panfrost_drv.c
> > @@ -172,13 +172,27 @@ static int panfrost_ioctl_submit(struct drm_device *dev, void *data,
> > {
> > struct panfrost_device *pfdev = dev->dev_private;
> > struct drm_panfrost_submit *args = data;
> > - struct drm_syncobj *sync_out;
> > + struct drm_syncobj *sync_out = NULL;
> > struct panfrost_job *job;
> > int ret = 0;
> >
> > + if (!args->jc)
> > + return -EINVAL;
> > +
> > + if (args->requirements && args->requirements != PANFROST_JD_REQ_FS)
> > + return -EINVAL;
> > +
> > + if (args->out_sync > 0) {
> > + sync_out = drm_syncobj_find(file, args->out_sync);
> > + if (!sync_out)
> > + return -ENODEV;
> > + }
> > +
> > job = kzalloc(sizeof(*job), GFP_KERNEL);
> > - if (!job)
> > - return -ENOMEM;
> > + if (!job) {
> > + ret = -ENOMEM;
> > + goto fail_out_sync;
> > + }
> >
> > kref_init(&job->refcount);
> >
> > @@ -190,25 +204,24 @@ static int panfrost_ioctl_submit(struct drm_device *dev, void *data,
> >
> > ret = panfrost_copy_in_sync(dev, file, args, job);
> > if (ret)
> > - goto fail;
> > + goto fail_job;
> >
> > ret = panfrost_lookup_bos(dev, file, args, job);
> > if (ret)
> > - goto fail;
> > + goto fail_job;
> >
> > ret = panfrost_job_push(job);
> > if (ret)
> > - goto fail;
> > + goto fail_job;
> >
> > /* Update the return sync object for the job */
> > - sync_out = drm_syncobj_find(file, args->out_sync);
> > - if (sync_out) {
> > + if (sync_out)
> > drm_syncobj_replace_fence(sync_out, job->render_done_fence);
> > - drm_syncobj_put(sync_out);
> > - }
> >
> > -fail:
> > +fail_job:
> > panfrost_job_put(job);
> > +fail_out_sync:
> > + drm_syncobj_put(sync_out);
> >
> > return ret;
> > }
> > --
> > 2.20.1
> >
>
> --
> Daniel Vetter
> Software Engineer, Intel Corporation
> http://blog.ffwll.ch
prev parent reply other threads:[~2019-04-24 14:38 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-24 13:13 [PATCH] drm/panfrost: Add sanity checks to submit IOCTL Tomeu Vizoso
2019-04-24 13:20 ` Daniel Vetter
2019-04-24 14:38 ` Tomeu Vizoso [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAAObsKAnCt2wfip6QsJy0fXyq1mNr02oghUO9qt_OC_EQh6q_A@mail.gmail.com \
--to=tomeu.vizoso@collabora.com \
--cc=airlied@linux.ie \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).