From: Tomeu Vizoso <tomeu.vizoso@collabora.com>
To: Emil Velikov <emil.l.velikov@gmail.com>
Cc: David Airlie <airlied@linux.ie>,
"intel-gfx@lists.freedesktop.org"
<intel-gfx@lists.freedesktop.org>,
"Linux-Kernel@Vger. Kernel. Org" <linux-kernel@vger.kernel.org>,
ML dri-devel <dri-devel@lists.freedesktop.org>,
Thierry Reding <thierry.reding@gmail.com>,
Daniel Vetter <daniel.vetter@intel.com>,
Emil Velikov <emil.velikov@collabora.com>
Subject: Re: [Intel-gfx] [PATCH v6 3/4] drm/i915: Use new CRC debugfs API
Date: Thu, 8 Sep 2016 16:47:37 +0200 [thread overview]
Message-ID: <CAAObsKC8w+hfMFS8Q0oSFDWvY60_-GKxJYZkZgSu_Z50_UdOQw@mail.gmail.com> (raw)
In-Reply-To: <CACvgo52p3J0mPNLhO7DJY14WnWCK0nzQTFm1eqAgEDMGi_CzoQ@mail.gmail.com>
On 8 September 2016 at 15:35, Emil Velikov <emil.l.velikov@gmail.com> wrote:
> Hi Tomeu,
>
> Just a couple of nitpicks. Nothing that has to be fixed or (if you
> agree) cannot be done on top/later on.
>
> On 7 September 2016 at 11:27, Tomeu Vizoso <tomeu.vizoso@collabora.com> wrote:
>> The core provides now an ABI to userspace for generation of frame CRCs,
>> so implement the ->set_crc_source() callback and reuse as much code as
>> possible with the previous ABI implementation.
>>
>> v2:
>> - Leave the legacy implementation in place as the ABI implementation
>> in the core is incompatible with it.
>> v3:
>> - Use the "cooked" vblank counter so we have a whole 32 bits.
>> - Make sure we don't mess with the state of the legacy CRC capture
>> ABI implementation.
>> v4:
>> - Keep use of get_vblank_counter as in the legacy code, will be
>> changed in a followup commit.
>>
>> v5:
>> - Skip first frame or two as it's known that they contain wrong
>> data.
> Even if the frames are only skipped in the new code, it doesn't
> explain why one'd need it in the first place and/or how it isn't
> required with the current code. Might be worth poking the original
> authors and/or adding a big WARNING/NOTE/XXX/HACK to make things more
> prominent.
Have added a note to the commit message, as once the legacy codepath
is removed, it could be confusing.
>
>> - A few fixes suggested by Emil Velikov.
>>
>> v6:
>> - Rework programming of the HW registers to preserve previous
>> behavior.
>>
> Huge thanks for this.
>
>
>> @@ -791,7 +797,7 @@ display_crc_ctl_parse_object(const char *buf, enum intel_pipe_crc_object *o)
>> if (!strcmp(buf, pipe_crc_objects[i])) {
>> *o = i;
>> return 0;
>> - }
>> + }
>>
> Looks like newly introduced whitespace changes, should have been part of 1/4 ?
Oops, both instances fixed in v7.
Thanks,
Tomeu
>> return -EINVAL;
>> }
>> @@ -813,11 +819,16 @@ display_crc_ctl_parse_source(const char *buf, enum intel_pipe_crc_source *s)
>> {
>> int i;
>
>> if (!strcmp(buf, pipe_crc_sources[i])) {
>> *s = i;
>> return 0;
>> - }
>> + }
>>
> Ditto ?
>
> Thanks
> Emil
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2016-09-08 14:48 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-07 10:27 [PATCH v6 0/4] New debugfs API for capturing CRC of frames Tomeu Vizoso
2016-09-07 10:27 ` [PATCH v6 1/4] drm/i915/debugfs: Move out pipe CRC code Tomeu Vizoso
2016-09-07 10:27 ` [PATCH v6 2/4] drm: Add API for capturing frame CRCs Tomeu Vizoso
2016-09-08 13:24 ` Emil Velikov
2016-09-08 14:49 ` Tomeu Vizoso
2016-09-08 15:08 ` Emil Velikov
2016-09-07 10:27 ` [PATCH v6 3/4] drm/i915: Use new CRC debugfs API Tomeu Vizoso
2016-09-08 13:35 ` [Intel-gfx] " Emil Velikov
2016-09-08 14:47 ` Tomeu Vizoso [this message]
2016-09-07 10:27 ` [PATCH v6 4/4] drm/i915: Put "cooked" vlank counters in frame CRC lines Tomeu Vizoso
2016-09-08 13:38 ` [Intel-gfx] [PATCH v6 0/4] New debugfs API for capturing CRC of frames Emil Velikov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAAObsKC8w+hfMFS8Q0oSFDWvY60_-GKxJYZkZgSu_Z50_UdOQw@mail.gmail.com \
--to=tomeu.vizoso@collabora.com \
--cc=airlied@linux.ie \
--cc=daniel.vetter@intel.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=emil.l.velikov@gmail.com \
--cc=emil.velikov@collabora.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).