From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965355AbbBCNNy (ORCPT ); Tue, 3 Feb 2015 08:13:54 -0500 Received: from mail-qa0-f50.google.com ([209.85.216.50]:63489 "EHLO mail-qa0-f50.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754631AbbBCNNu (ORCPT ); Tue, 3 Feb 2015 08:13:50 -0500 MIME-Version: 1.0 In-Reply-To: <54CFE754.7000500@wwwdotorg.org> References: <1422442278-10405-1-git-send-email-tomeu.vizoso@collabora.com> <1422442278-10405-2-git-send-email-tomeu.vizoso@collabora.com> <54CFE754.7000500@wwwdotorg.org> From: Tomeu Vizoso Date: Tue, 3 Feb 2015 14:13:28 +0100 X-Google-Sender-Auth: VL56JpgyZ-T_rqgyUUTnat9Ur3I Message-ID: Subject: Re: [PATCH v3 01/10] ARM: tegra: Set the sound card model that alsaucm expects To: Stephen Warren Cc: "linux-kernel@vger.kernel.org" , Mark Rutland , Alexandre Courbot , Russell King , Pawel Moll , Ian Campbell , Andrew Bresticker , Simon Glass , "devicetree@vger.kernel.org" , Rob Herring , Thierry Reding , Kumar Gala , "linux-tegra@vger.kernel.org" , Dylan Reid , Javier Martinez Canillas , "linux-arm-kernel@lists.infradead.org" Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2 February 2015 at 22:08, Stephen Warren wrote: > On 01/28/2015 03:50 AM, Tomeu Vizoso wrote: >> >> Patches are on its way to add a config file to alsaucm for the Nyan >> boards. Use the same card ID that alsaucm will expect. > > >> diff --git a/arch/arm/boot/dts/tegra124-nyan-big.dts >> b/arch/arm/boot/dts/tegra124-nyan-big.dts > > >> sound { >> - compatible = "nvidia,tegra-audio-max98090-nyan-big", >> + compatible = "nvidia,tegra-audio-max98090-nyan", >> "nvidia,tegra-audio-max98090"; > > > I'm not convinced that removing the board-specific compatible value is a > great idea. What if we find we need to distinguish between different boards > that use this same binding in the future. That situation is exactly why we > have board-/SoC-specific values in compatible even if we don't immediately > use them. I understand the need of naming each component variant so they can be distinguished in the future, but in this case it's the exact same hw. >> - nvidia,model = "Acer Chromebook 13"; >> + nvidia,model = "GoogleNyan"; > > > I believe this also technically breaks ABI, since some user-space tools use > the model to look up saved state. Can we not leave this as is, and just have > the UCM files know about both names? Well, "A13" isn't a great card id. Given that there's no users yet, I would prefer to take this chance to put a sane value in there. Btw, alsa-lib has now a UCM config for this and it uses the GoogleNyan card id (has been picked up already by OpenSUSE). So in this case, I think it would be good to change the card id now before people start to actually use it. Regards, Tomeu > Aside from that, I think the series looks OK at a quick glance. > > _______________________________________________ > linux-arm-kernel mailing list > linux-arm-kernel@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel