From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751770AbbGMMLL (ORCPT ); Mon, 13 Jul 2015 08:11:11 -0400 Received: from mail-wi0-f181.google.com ([209.85.212.181]:35907 "EHLO mail-wi0-f181.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750792AbbGMMLI (ORCPT ); Mon, 13 Jul 2015 08:11:08 -0400 MIME-Version: 1.0 In-Reply-To: <20150701173802.GW11162@sirena.org.uk> References: <1435743667-11987-1-git-send-email-tomeu.vizoso@collabora.com> <1435743667-11987-12-git-send-email-tomeu.vizoso@collabora.com> <20150701173802.GW11162@sirena.org.uk> From: Tomeu Vizoso Date: Mon, 13 Jul 2015 14:10:45 +0200 X-Google-Sender-Auth: Ntypx_t1H2K8g-F_utCMLUuthLY Message-ID: Subject: Re: [alsa-devel] [PATCH v2 11/12] ASoC: tegra: register dependency parser for firmware nodes To: Mark Brown Cc: "devicetree@vger.kernel.org" , linux-fbdev@vger.kernel.org, alsa-devel@alsa-project.org, linux-gpio@vger.kernel.org, Takashi Iwai , Liam Girdwood , Stephen Warren , "Rafael J. Wysocki" , "linux-kernel@vger.kernel.org" , "dri-devel@lists.freedesktop.org" , linux-acpi@vger.kernel.org, Thierry Reding , Linux PWM List , "linux-tegra@vger.kernel.org" , Alexandre Courbot Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 1 July 2015 at 19:38, Mark Brown wrote: > On Wed, Jul 01, 2015 at 11:41:06AM +0200, Tomeu Vizoso wrote: > >> +static void tegra_max98090_get_dependencies(struct fwnode_handle *fwnode, >> + struct list_head *deps) >> +{ >> + add_dependency(fwnode, "nvidia,i2s-controller", deps); >> + add_dependency(fwnode, "nvidia,audio-codec", deps); >> +} > > Why is this all being open coded in an individual driver (we already > know about and manage all these dependencies in the core...)? If we're > going to do this I'd expect the interface for specifying DT nodes to the > core to be changed to support this. Are you thinking of changing drivers to acquire their resources through Arnd's devm_probe (only that the resource table would have to be in struct device_driver)? https://lkml.kernel.org/g/4742258.TBitC3hVuO@wuerfel Sounds like lots of fun, but that means that any given machine will get ordered probe only after all the drivers it uses have been moved to the new declarative API. TBH, that seems really far away. Regards, Tomeu