From: Wei Xu <weixugc@google.com>
To: Dave Hansen <dave.hansen@linux.intel.com>
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org,
shy828301@gmail.com, Greg Thelen <gthelen@google.com>,
David Rientjes <rientjes@google.com>,
ying.huang@intel.com, Dan Williams <dan.j.williams@intel.com>,
david@redhat.com, osalvador@suse.de
Subject: Re: [PATCH 07/10] mm/vmscan: add helper for querying ability to age anonymous pages
Date: Wed, 7 Apr 2021 11:40:13 -0700 [thread overview]
Message-ID: <CAAPL-u-OgmT+R=txfO_rFaYLKC0UZ5xEmFOY3spVHEmk_r4iSQ@mail.gmail.com> (raw)
In-Reply-To: <20210401183229.B2360AEA@viggo.jf.intel.com>
> +/*
> + * Anonymous LRU management is a waste if there is
> + * ultimately no way to reclaim the memory.
> + */
> +bool anon_should_be_aged(struct lruvec *lruvec)
> +{
> + struct pglist_data *pgdat = lruvec_pgdat(lruvec);
> +
> + /* Aging the anon LRU is valuable if swap is present: */
> + if (total_swap_pages > 0)
> + return true;
> +
> + /* Also valuable if anon pages can be demoted: */
> + if (next_demotion_node(pgdat->node_id) >= 0)
> + return true;
> +
> + /* No way to reclaim anon pages. Should not age anon LRUs: */
> + return false;
> +}
anon_should_be_aged() doesn't really need "lruvec". It essentially
answers whether the pages of the given node can be swapped or demoted.
So it would be clearer and less confusing if anon_should_be_aged()
takes "pgdat" instead of "lruvec" as the argument. The call to
mem_cgroup_lruvec(NULL, pgdat) in age_active_anon() can then be removed
as well.
next prev parent reply other threads:[~2021-04-07 18:40 UTC|newest]
Thread overview: 65+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-01 18:32 [PATCH 00/10] [v7][RESEND] Migrate Pages in lieu of discard Dave Hansen
2021-04-01 18:32 ` [PATCH 01/10] mm/numa: node demotion data structure and lookup Dave Hansen
2021-04-08 8:03 ` Oscar Salvador
2021-04-08 21:29 ` Dave Hansen
2021-04-09 5:32 ` Wei Xu
2021-04-01 18:32 ` [PATCH 02/10] mm/numa: automatically generate node migration order Dave Hansen
2021-04-08 8:26 ` Oscar Salvador
2021-04-08 21:51 ` Dave Hansen
2021-04-09 8:17 ` Oscar Salvador
2021-04-10 3:07 ` Wei Xu
2021-04-14 8:08 ` Oscar Salvador
2021-04-14 8:11 ` Oscar Salvador
2021-04-14 8:12 ` David Hildenbrand
2021-04-14 8:14 ` Oscar Salvador
2021-04-14 8:20 ` David Hildenbrand
2021-04-15 4:07 ` Wei Xu
2021-04-15 15:35 ` Dave Hansen
2021-04-15 20:25 ` Wei Xu
2021-04-01 18:32 ` [PATCH 03/10] mm/migrate: update node demotion order during on hotplug events Dave Hansen
2021-04-08 9:52 ` Oscar Salvador
2021-04-09 10:14 ` Oscar Salvador
2021-04-09 10:15 ` Oscar Salvador
2021-04-09 18:59 ` David Hildenbrand
2021-04-12 7:19 ` Oscar Salvador
2021-04-12 9:19 ` David Hildenbrand
2021-04-01 18:32 ` [PATCH 04/10] mm/migrate: make migrate_pages() return nr_succeeded Dave Hansen
2021-04-01 22:39 ` Wei Xu
[not found] ` <CAAPL-u-o-M2T25xBtSoipYjUnu+3aJNcJ9uS84yKaAnbrXpefw@mail.gmail.com>
2021-04-01 23:21 ` Dave Hansen
2021-04-08 10:14 ` Oscar Salvador
2021-04-08 17:26 ` Yang Shi
2021-04-08 18:17 ` Oscar Salvador
2021-04-08 18:21 ` Oscar Salvador
2021-04-08 20:40 ` Yang Shi
2021-04-09 5:06 ` Oscar Salvador
2021-04-09 5:43 ` Wei Xu
2021-04-09 15:43 ` Yang Shi
2021-04-09 15:50 ` Dave Hansen
2021-04-09 18:47 ` Wei Xu
2021-04-09 20:10 ` Yang Shi
2021-04-01 18:32 ` [PATCH 05/10] mm/migrate: demote pages during reclaim Dave Hansen
2021-04-01 20:01 ` Yang Shi
2021-04-01 22:58 ` Dave Hansen
2021-04-08 10:47 ` Oscar Salvador
2021-04-10 3:35 ` Wei Xu
2021-04-01 18:32 ` [PATCH 06/10] mm/vmscan: add page demotion counter Dave Hansen
2021-04-10 3:40 ` Wei Xu
2021-04-01 18:32 ` [PATCH 07/10] mm/vmscan: add helper for querying ability to age anonymous pages Dave Hansen
2021-04-07 18:40 ` Wei Xu [this message]
2021-04-09 8:31 ` Oscar Salvador
2021-04-01 18:32 ` [PATCH 08/10] mm/vmscan: Consider anonymous pages without swap Dave Hansen
2021-04-02 0:55 ` Wei Xu
2021-04-01 18:32 ` [PATCH 09/10] mm/vmscan: never demote for memcg reclaim Dave Hansen
2021-04-02 0:18 ` Wei Xu
2021-04-01 18:32 ` [PATCH 10/10] mm/migrate: new zone_reclaim_mode to enable reclaim migration Dave Hansen
2021-04-01 20:06 ` Yang Shi
2021-04-10 4:10 ` Wei Xu
2021-04-16 12:35 ` [PATCH 00/10] [v7][RESEND] Migrate Pages in lieu of discard Michal Hocko
2021-04-16 14:26 ` Dave Hansen
2021-04-16 15:02 ` Michal Hocko
2021-04-21 2:39 ` Huang, Ying
2021-05-07 6:14 ` Huang, Ying
2021-06-11 5:50 ` Huang, Ying
-- strict thread matches above, loose matches on Subject: below --
2021-03-04 23:59 [PATCH 00/10] [v6] " Dave Hansen
2021-03-05 0:00 ` [PATCH 07/10] mm/vmscan: add helper for querying ability to age anonymous pages Dave Hansen
2021-03-09 0:14 ` Yang Shi
2021-03-20 4:05 ` Greg Thelen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAAPL-u-OgmT+R=txfO_rFaYLKC0UZ5xEmFOY3spVHEmk_r4iSQ@mail.gmail.com' \
--to=weixugc@google.com \
--cc=dan.j.williams@intel.com \
--cc=dave.hansen@linux.intel.com \
--cc=david@redhat.com \
--cc=gthelen@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=osalvador@suse.de \
--cc=rientjes@google.com \
--cc=shy828301@gmail.com \
--cc=ying.huang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).