From: Inki Dae <inki.dae@samsung.com>
To: Mandeep Singh Baines <msb@chromium.org>
Cc: "Joonyoung Shim" <jy0922.shim@samsung.com>,
"Kyungmin Park" <kyungmin.park@samsung.com>,
"David Airlie" <airlied@linux.ie>,
dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
"Paul Menzel" <paulepanter@users.sourceforge.net>,
"Stéphane Marchesin" <marcheu@chromium.org>,
"Pawel Osciak" <posciak@google.com>
Subject: Re: [PATCH] drm/exynos: fix double call of drm_prime_(init/destroy)_file_private
Date: Fri, 7 Sep 2012 13:49:17 +0900 [thread overview]
Message-ID: <CAAQKjZMeTq0nci1c-_ZaUiH=fWmpC4Uimrh8=URn4KzKwJ_O4g@mail.gmail.com> (raw)
In-Reply-To: <1346950163-17590-1-git-send-email-msb@chromium.org>
Applied.
Thanks,
Inki Dae
2012/9/7 Mandeep Singh Baines <msb@chromium.org>:
> The double invocations are incorrect but seem to be safe so I don't
> think this will fix any bugs.
>
> Before:
>
> [ 7.639366] drm_prime_init_file ee3675d0
> [ 7.639377] drm_prime_init_file ee3675d0
> [ 7.639507] drm_prime_destroy_file ee3675d0
> [ 7.639518] drm_prime_destroy_file ee3675d0
> [ 7.639802] drm_prime_init_file ee372390
> [ 7.639810] drm_prime_init_file ee372390
> [ 8.473316] drm_prime_init_file ee356390
> [ 8.473331] drm_prime_init_file ee356390
>
> After:
>
> [ 6.363842] drm_prime_init_file edc2e5d0
> [ 6.363994] drm_prime_destroy_file edc2e5d0
> [ 6.364260] drm_prime_init_file edc2e750
> [ 8.004837] drm_prime_init_file ee36ded0
>
> Signed-off-by: Mandeep Singh Baines <msb@chromium.org>
> Acked-by: Seung-Woo Kim <sw0312.kim@samsung.com>
> ---
> drivers/gpu/drm/exynos/exynos_drm_drv.c | 2 --
> 1 files changed, 0 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/exynos/exynos_drm_drv.c b/drivers/gpu/drm/exynos/exynos_drm_drv.c
> index ebacec6..a27b8ff 100644
> --- a/drivers/gpu/drm/exynos/exynos_drm_drv.c
> +++ b/drivers/gpu/drm/exynos/exynos_drm_drv.c
> @@ -160,7 +160,6 @@ static int exynos_drm_open(struct drm_device *dev, struct drm_file *file)
> if (!file_priv)
> return -ENOMEM;
>
> - drm_prime_init_file_private(&file->prime);
> file->driver_priv = file_priv;
>
> return exynos_drm_subdrv_open(dev, file);
> @@ -184,7 +183,6 @@ static void exynos_drm_preclose(struct drm_device *dev,
> e->base.destroy(&e->base);
> }
> }
> - drm_prime_destroy_file_private(&file->prime);
> spin_unlock_irqrestore(&dev->event_lock, flags);
>
> exynos_drm_subdrv_close(dev, file);
> --
> 1.7.7.3
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/dri-devel
prev parent reply other threads:[~2012-09-07 4:49 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-05 21:47 [PATCH] drm/exynos: fix double call of drm_prime_(init/destroy)_file_private Mandeep Singh Baines
2012-09-06 2:15 ` 김승우
2012-09-06 2:35 ` InKi Dae
2012-09-06 7:50 ` Paul Menzel
2012-09-06 8:30 ` InKi Dae
2012-09-06 16:49 ` Mandeep Singh Baines
2012-09-07 4:49 ` Inki Dae [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAAQKjZMeTq0nci1c-_ZaUiH=fWmpC4Uimrh8=URn4KzKwJ_O4g@mail.gmail.com' \
--to=inki.dae@samsung.com \
--cc=airlied@linux.ie \
--cc=dri-devel@lists.freedesktop.org \
--cc=jy0922.shim@samsung.com \
--cc=kyungmin.park@samsung.com \
--cc=linux-kernel@vger.kernel.org \
--cc=marcheu@chromium.org \
--cc=msb@chromium.org \
--cc=paulepanter@users.sourceforge.net \
--cc=posciak@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).