From: Andrea Adami <andrea.adami@gmail.com>
To: linux-mtd@lists.infradead.org
Cc: David Woodhouse <dwmw2@infradead.org>,
Brian Norris <computersforpeace@gmail.com>,
Boris Brezillon <boris.brezillon@free-electrons.com>,
Marek Vasut <marek.vasut@gmail.com>,
Richard Weinberger <richard@nod.at>,
Cyrille Pitchen <cyrille.pitchen@wedev4u.fr>,
Dmitry Eremin-Solenikov <dbaryshkov@gmail.com>,
Robert Jarzmik <robert.jarzmik@free.fr>,
Linus Walleij <linus.walleij@linaro.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 0/3] mtd: sharpslpart partition parser
Date: Tue, 23 May 2017 11:11:36 +0200 [thread overview]
Message-ID: <CAAQYJAv-8wH=UuEvOtubimw1bLTiPEwdgJTdhiYQ_z_PYd+keA@mail.gmail.com> (raw)
In-Reply-To: <1492860013-20848-1-git-send-email-andrea.adami@gmail.com>
On Sat, Apr 22, 2017 at 1:20 PM, Andrea Adami <andrea.adami@gmail.com> wrote:
> This patchset introduces a simple partition parser for the Sharp SL
> Series PXA handhelds. More details in the commit text.
>
> I have set in cc the ARM PXA maintainers because this is the MTD part of
> a planned wider patchset cleaning the Zaurus board files.
>
> Changelog:
> v1 initial import of 2.4 sources [1]
> v2 refactor applying many suggested fixes [2]
>
> [1] https://github.com/LinuxPDA/Sharp_FTL_2.4.20
> [2] https://github.com/LinuxPDA/linux/commits/sharpslpart_v2
>
> Andrea Adami (3):
> mtd: sharpsl: add sharpslpart MTD partition parser
> mtd: nand: sharpsl.c: prefer sharpslpart MTD partition parser
> mtd: nand: tmio_nand.c: prefer sharpslpart MTD partition parser
>
> drivers/mtd/Kconfig | 8 ++
> drivers/mtd/Makefile | 2 +
> drivers/mtd/nand/sharpsl.c | 4 +-
> drivers/mtd/nand/tmio_nand.c | 4 +-
> drivers/mtd/sharpsl_ftl.c | 219 +++++++++++++++++++++++++++++++++++++++++++
> drivers/mtd/sharpsl_ftl.h | 34 +++++++
> drivers/mtd/sharpslpart.c | 132 ++++++++++++++++++++++++++
> 7 files changed, 401 insertions(+), 2 deletions(-)
> create mode 100644 drivers/mtd/sharpsl_ftl.c
> create mode 100644 drivers/mtd/sharpsl_ftl.h
> create mode 100644 drivers/mtd/sharpslpart.c
>
> --
> 2.7.4
>
Hello,
I'd be thankful for a second review after the big changes from v1
which was just a proof of concept.
As for the memory management, it totally mimics the other parsers.
The patch has been backported to 4.4 [1] and up to 3.10 [2] with
minimal changes to module init/exit:
since linux 4.5 (commit b8f70ba mtd: kill off MTD partition parser
boilerplate) we use module_mtd_part_parser().
With this parser we have finally a single linux-as bootloader kernel
covering the 4 Zaurus pxa 27x devices (repartitioned or not).
Thanks in advance
Andrea
[1] http://cgit.openembedded.org/meta-handheld/tree/recipes-kernel/linux/linux-handheld-4.4/sharpslpart/0001-mtd-sharpsl-add-sharpslpart-MTD-partition-parser.patch
[2] https://github.com/greguu/linux-3.10.y-c3x00-f2fs-kexec-r0/commit/f087900fbd778cce642a8e24e7351a0d814bb9a7
prev parent reply other threads:[~2017-05-23 9:11 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-22 11:20 [PATCH v2 0/3] mtd: sharpslpart partition parser Andrea Adami
2017-04-22 11:20 ` [PATCH v2 1/3] mtd: sharpsl: add sharpslpart MTD " Andrea Adami
2017-04-22 11:20 ` [PATCH v2 2/3] mtd: nand: sharpsl.c: prefer " Andrea Adami
2017-04-22 11:20 ` [PATCH v2 3/3] mtd: nand: tmio_nand.c: " Andrea Adami
2017-05-25 19:25 ` Brian Norris
2017-05-25 20:47 ` Andrea Adami
2017-05-25 21:10 ` Brian Norris
2017-05-25 22:21 ` Andrea Adami
2017-05-23 9:11 ` Andrea Adami [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAAQYJAv-8wH=UuEvOtubimw1bLTiPEwdgJTdhiYQ_z_PYd+keA@mail.gmail.com' \
--to=andrea.adami@gmail.com \
--cc=boris.brezillon@free-electrons.com \
--cc=computersforpeace@gmail.com \
--cc=cyrille.pitchen@wedev4u.fr \
--cc=dbaryshkov@gmail.com \
--cc=dwmw2@infradead.org \
--cc=linus.walleij@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=marek.vasut@gmail.com \
--cc=richard@nod.at \
--cc=robert.jarzmik@free.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).