From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 22C15C04AAF for ; Tue, 21 May 2019 08:58:09 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id ED68A2173E for ; Tue, 21 May 2019 08:58:08 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=sifive.com header.i=@sifive.com header.b="OGaKD9fk" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727219AbfEUI6H (ORCPT ); Tue, 21 May 2019 04:58:07 -0400 Received: from mail-ua1-f66.google.com ([209.85.222.66]:40848 "EHLO mail-ua1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726242AbfEUI6H (ORCPT ); Tue, 21 May 2019 04:58:07 -0400 Received: by mail-ua1-f66.google.com with SMTP id d4so6330572uaj.7 for ; Tue, 21 May 2019 01:58:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sifive.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=ASCK5QEsgPSM1g1u7FGizuNcDI5mfe6ouhE1b8rzrSY=; b=OGaKD9fkwz/Uh1otcyfhnq5/11wcGhDIMBsJWSCFGVzL84pS/hohwFfTIPr0f3C7Ss TCzV+PrZ/UE1xdmLWaFz6PlGI/iF3RtRcVfLUtdvGvPDcDjQ6ZWUuw7/hqHnzw4aVDq1 T+TY5Hf5SwxBmY4jlUIN7MgSgWIeGv9WeCgHuKRb6Ws8uWAfz87GnLQtfCKnhwCm5Ijl 7AT6oOuPUrKCta8mX1J86JEXXy7ICqIg+BDY8PRPDNIGX4oA5flVrgmU0Joi7mCEt2Wr R+xJmID9TmfovxsKCZZJ9RzeZZ/7PNIBdrrTxN3UIyhoLQvh5nHJEXpJfG6LmHecnXdD QFTg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=ASCK5QEsgPSM1g1u7FGizuNcDI5mfe6ouhE1b8rzrSY=; b=SY19SqwwO5DiNbWfkFu6qSenb1LtwwuCJ7bRXhxcl21QlzQwUhcvl9iulDhwwOoftd BAIj2zM8AYszU1uU+lSbEfEIgoxEkmNnjY6aJOVVwbiorxvwhPapxS9jfA60f68kKAXd n1LjNxnECePH/4S8mky9oDQzUsfKw1co/dGDbFOwmbIkxr91vF8Gd+QnBbG+jexyO/ME rG3zDhL7OlcKYQzzQSHGtqR672g/miUhZBsFsKIdKpx8F9XqFWRS3gfhL2hbuo5MkSlA KvmI0r3BDy+p35BR4tC2++MnjggmhmagYiXhaQV2ZSlncc74CHeygqLVWjooAETaNg1Z NHcA== X-Gm-Message-State: APjAAAVd6Mrsetq4+LFynKJNXSpca/KICDdsUiIlw/JEKcoiXgyjivuD cKkcq/PtxNdXgbVatb0lXIC+eCR94ctBaPjy2mIcNg== X-Google-Smtp-Source: APXvYqzkKcNaCd+xd63rL6haTKxCeW8/LcqpqGKBrmCWjM1IJegwyk74C67ww1GqqytfFzxidHgluiDjyzYYhL10aqk= X-Received: by 2002:ab0:45e9:: with SMTP id u96mr17987279uau.75.1558429085797; Tue, 21 May 2019 01:58:05 -0700 (PDT) MIME-Version: 1.0 References: <1558361478-4381-1-git-send-email-sagar.kadam@sifive.com> <1558361478-4381-4-git-send-email-sagar.kadam@sifive.com> In-Reply-To: From: Sagar Kadam Date: Tue, 21 May 2019 14:27:54 +0530 Message-ID: Subject: Re: [PATCH v5 3/3] i2c-ocores: sifive: add polling mode workaround for FU540-C000 SoC. To: Andreas Schwab Cc: Rob Herring , Mark Rutland , peter@korsgaard.com, Andrew Lunn , Palmer Dabbelt , Paul Walmsley , Linux I2C , devicetree@vger.kernel.org, linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Thanks Andreas, Yes, I rebased to v5.2-rc1 and observed that there have been changes in polling interface, and i2c->flags is not longer being used for setting the polling mode. I am working on a way to hook in the fix for broken IRQ and will submit it in v6. Thanks & BR, Sagar Kadam On Tue, May 21, 2019 at 2:03 PM Andreas Schwab wrote: > > On Mai 20 2019, Sagar Shrikant Kadam wrote: > > > The i2c-ocore driver already has a polling mode interface.But it needs > > a workaround for FU540 Chipset on HiFive unleashed board (RevA00). > > There is an erratum in FU540 chip that prevents interrupt driven i2c > > transfers from working, and also the I2C controller's interrupt bit > > cannot be cleared if set, due to this the existing i2c polling mode > > interface added in mainline earlier doesn't work, and CPU stall's > > infinitely, when-ever i2c transfer is initiated. > > > > Ref:previous polling mode support in mainline > > > > commit 69c8c0c0efa8 ("i2c: ocores: add polling interface") > > > > The workaround / fix under OCORES_FLAG_BROKEN_IRQ is particularly for > > FU540-COOO SoC. > > After commit dd7dbf0eb090 this no longer fits. > > Andreas. > > -- > Andreas Schwab, SUSE Labs, schwab@suse.de > GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE 1748 E4D4 88E3 0EEA B9D7 > "And now for something completely different."