From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4C6C9C04AAC for ; Mon, 20 May 2019 15:20:20 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 2144520863 for ; Mon, 20 May 2019 15:20:20 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=sifive.com header.i=@sifive.com header.b="Kxtt3uvg" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2389720AbfETPUT (ORCPT ); Mon, 20 May 2019 11:20:19 -0400 Received: from mail-ua1-f66.google.com ([209.85.222.66]:36531 "EHLO mail-ua1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726146AbfETPUS (ORCPT ); Mon, 20 May 2019 11:20:18 -0400 Received: by mail-ua1-f66.google.com with SMTP id 94so5406847uam.3 for ; Mon, 20 May 2019 08:20:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sifive.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=yPkishA3no+/g/FV605XOJKWtbVRtxVgWtFS2JQZ9bI=; b=Kxtt3uvgicFdIlOHphmgzeg6qcwksSg5x8b5fBlKAUoEtJbeq4uW+PNn4F5YAmMzyr uqFFhbY+un+kGiRRgCgL8MghZdTl4kLYe1ufn/CfBNiWyoYHwrRGgMA09rA6e9ix2WMk 9sEpQr8fsWkqi7WNU3NXS9rylbV39+uq3sCw3ZpuGTkms4ijpxsGjO6FyoWtt5OL26EV RmgW9ZjVg/r34Cpggv32pOk/8Kik6hQliDvpmui4EcqGKnrIJvH/MCa3VX2Caz4uq/54 4WGxty5+Ktsb3Z/m30o44gwsWigfGOM1GAh9Sg1WWp3W3R9KO+sG0qNvKHkLME5eVU8M MpLw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=yPkishA3no+/g/FV605XOJKWtbVRtxVgWtFS2JQZ9bI=; b=ODNySIY59CR0QbNd2PQkVZ7uT36LPFb1bJMbJgjNnAwYQnsLSECks4E5ySOOcIfI7w 3O8+FrpvszAnB7m8GTZCMO7BC1sh1IXcwwj5Q1tNX1EyeeesRFuhi1KaTghVuUoMwT1q gQIkr2bc7oSRyeFbJK0xBLLlNhUD/I3nz/Ch9BteiuphvakJuBKHt6ymrRyv7DquCUJn LK26j+NCV+TvlGND43clwoexIM7PLssy+NgPoRswbICCl4pBkt+VRlfz32K0METIUrok kwLjTcmzOKRueWjl58WUW2yyL4CoVS+jC2XxvKLWFQxbQ88kcTNwd2xbfMFA9GoacYpA llwQ== X-Gm-Message-State: APjAAAVKeUljBreu123WiB2zgiuE9x3IVv9M0oks6UkAW6q2QQyY17eT G0brurGNViKILocpalqQf6BRNR42Z6Cy4bOxULJxEQ== X-Google-Smtp-Source: APXvYqyUiE88Q5DbYY6MW6gAUlfOMNSWJ4PSpYDD0G5KebJp1+15Ue04rR+q2oWWqyNgk8/ayaSUM7mZwfLYVH9RSRs= X-Received: by 2002:a9f:2b0c:: with SMTP id p12mr28323739uaj.143.1558365617913; Mon, 20 May 2019 08:20:17 -0700 (PDT) MIME-Version: 1.0 References: <1558361478-4381-1-git-send-email-sagar.kadam@sifive.com> <1558361478-4381-4-git-send-email-sagar.kadam@sifive.com> <20190520145216.GD22024@lunn.ch> In-Reply-To: <20190520145216.GD22024@lunn.ch> From: Sagar Kadam Date: Mon, 20 May 2019 20:50:06 +0530 Message-ID: Subject: Re: [PATCH v5 3/3] i2c-ocores: sifive: add polling mode workaround for FU540-C000 SoC. To: Andrew Lunn Cc: robh+dt@kernel.org, mark.rutland@arm.com, peter@korsgaard.com, Palmer Dabbelt , Paul Walmsley , linux-i2c@vger.kernel.org, devicetree@vger.kernel.org, linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, May 20, 2019 at 8:22 PM Andrew Lunn wrote: > > On Mon, May 20, 2019 at 07:41:18PM +0530, Sagar Shrikant Kadam wrote: > > The i2c-ocore driver already has a polling mode interface.But it needs > > a workaround for FU540 Chipset on HiFive unleashed board (RevA00). > > There is an erratum in FU540 chip that prevents interrupt driven i2c > > transfers from working, and also the I2C controller's interrupt bit > > cannot be cleared if set, due to this the existing i2c polling mode > > interface added in mainline earlier doesn't work, and CPU stall's > > infinitely, when-ever i2c transfer is initiated. > > > > Ref:previous polling mode support in mainline > > > > commit 69c8c0c0efa8 ("i2c: ocores: add polling interface") > > > > The workaround / fix under OCORES_FLAG_BROKEN_IRQ is particularly for > > FU540-COOO SoC. > > > > Signed-off-by: Sagar Shrikant Kadam > > Much better, thanks. My pleasure Andrew. Appreciate your timely review and response. > > Reviewed-by: Andrew Lunn > > Andrew Thanks, Sagar