From: Alexandru Ardelean <aardelean@deviqon.com>
To: Bartosz Golaszewski <bgolaszewski@baylibre.com>
Cc: linux-gpio <linux-gpio@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
Linus Walleij <linus.walleij@linaro.org>
Subject: Re: [PATCH] gpio: gpio-tps68470: remove platform_set_drvdata() + cleanup probe
Date: Fri, 21 May 2021 20:46:03 +0300 [thread overview]
Message-ID: <CAASAkobrt=t0ObR+_nn6g403VAMP3f7uh7VmVDAo7S0PgpLE-A@mail.gmail.com> (raw)
In-Reply-To: <CAMpxmJWmc-8cCZ5EQcnBKSAmXPbcVUnX7GdhKgKWFp5i=B6y1w@mail.gmail.com>
On Fri, 21 May 2021 at 16:52, Bartosz Golaszewski
<bgolaszewski@baylibre.com> wrote:
>
> On Fri, May 14, 2021 at 11:41 AM Alexandru Ardelean
> <aardelean@deviqon.com> wrote:
> >
> > The platform_set_drvdata() call is only useful if we need to retrieve back
> > the private information.
> > Since the driver doesn't do that, it's not useful to have it.
> >
> > If this is removed, we can also just do a direct return on
> > devm_gpiochip_add_data(). We don't need to print that this call failed as
> > there are other ways to log/see this during probe.
> >
> > Signed-off-by: Alexandru Ardelean <aardelean@deviqon.com>
> > ---
> > drivers/gpio/gpio-tps68470.c | 12 +-----------
> > 1 file changed, 1 insertion(+), 11 deletions(-)
> >
> > diff --git a/drivers/gpio/gpio-tps68470.c b/drivers/gpio/gpio-tps68470.c
> > index f7f5f770e0fb..423b7bc30ae8 100644
> > --- a/drivers/gpio/gpio-tps68470.c
> > +++ b/drivers/gpio/gpio-tps68470.c
> > @@ -125,7 +125,6 @@ static const char *tps68470_names[TPS68470_N_GPIO] = {
> > static int tps68470_gpio_probe(struct platform_device *pdev)
> > {
> > struct tps68470_gpio_data *tps68470_gpio;
> > - int ret;
> >
> > tps68470_gpio = devm_kzalloc(&pdev->dev, sizeof(*tps68470_gpio),
> > GFP_KERNEL);
> > @@ -146,16 +145,7 @@ static int tps68470_gpio_probe(struct platform_device *pdev)
> > tps68470_gpio->gc.base = -1;
> > tps68470_gpio->gc.parent = &pdev->dev;
> >
> > - ret = devm_gpiochip_add_data(&pdev->dev, &tps68470_gpio->gc,
> > - tps68470_gpio);
> > - if (ret < 0) {
> > - dev_err(&pdev->dev, "Failed to register gpio_chip: %d\n", ret);
> > - return ret;
> > - }
> > -
> > - platform_set_drvdata(pdev, tps68470_gpio);
> > -
> > - return ret;
> > + return devm_gpiochip_add_data(&pdev->dev, &tps68470_gpio->gc, tps68470_gpio);
> > }
> >
> > static struct platform_driver tps68470_gpio_driver = {
> > --
> > 2.31.1
> >
>
> Applied. I got confused by the dev_get_drvdata() call earlier in probe
> but this one's for the parent.
Yes.
I initially got confused as well about it.
This pattern seems to be similar in other drivers as well; usually MFD devices.
>
> Thanks,
> Bart
prev parent reply other threads:[~2021-05-21 17:46 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-14 9:41 [PATCH] gpio: gpio-tps68470: remove platform_set_drvdata() + cleanup probe Alexandru Ardelean
2021-05-21 13:52 ` Bartosz Golaszewski
2021-05-21 17:46 ` Alexandru Ardelean [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAASAkobrt=t0ObR+_nn6g403VAMP3f7uh7VmVDAo7S0PgpLE-A@mail.gmail.com' \
--to=aardelean@deviqon.com \
--cc=bgolaszewski@baylibre.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).