From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.3 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_IN_DEF_DKIM_WL autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E5011C433E0 for ; Thu, 4 Feb 2021 06:14:54 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A123164F48 for ; Thu, 4 Feb 2021 06:14:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232163AbhBDGOy (ORCPT ); Thu, 4 Feb 2021 01:14:54 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:32908 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231259AbhBDGOu (ORCPT ); Thu, 4 Feb 2021 01:14:50 -0500 Received: from mail-wr1-x430.google.com (mail-wr1-x430.google.com [IPv6:2a00:1450:4864:20::430]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 51189C061786 for ; Wed, 3 Feb 2021 22:14:10 -0800 (PST) Received: by mail-wr1-x430.google.com with SMTP id a1so2074784wrq.6 for ; Wed, 03 Feb 2021 22:14:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=xgHzQqM7Lq62ORquHPkb4VNOYCwVoPGIPjGQe4hn+cQ=; b=RrUyEy/qircZcidYS/z9FTtqPHZhNCPKypUymmx5N5+20Osxp1ysGMBpji502uXsST 4TkZYunVG0bli1+cUBFMsfYszw8dH4Zu2ED869pWa8ijBqnX1U2bpUDYt99pii/5z3Uz yirtdioTIviZ5Gowx104V6fcEp6zmcBkfKZde4+GJjY6b+PoXbPm9KMYd0d62LfbZsGQ IW89t2WaBb7Tn9NcK/bSEQI4Omx538VBJzSNoLkM6LBfZqNe2tK4jISXrdYFqHmaektP by2pxKrKL0cJM9XZIkp5RWYCeT2okfocFGhhnt/JiPc76eyzK457jyqJatFKClPoVoOf dAOA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=xgHzQqM7Lq62ORquHPkb4VNOYCwVoPGIPjGQe4hn+cQ=; b=ad4KsGhi9RTb6+sswwIwhsjZc0ZskES0/UVUso5X4bu9VHj8OMqkovioIMDCdcOO+j sMboYApOMVE6lP8gIrgKVoerTf/d83So5Q9PW42dfx1LovHvKPxdfCG4bU1urUgDOTmg 54n5wrTxrGgCnzjp3LlBTFTfSSr8FghgBXGmxU3LXX1Nrxs3r4vaK0xaMS33UWZH8AOq 0tTjIn9z/PnvSCYcJ6q3VsCVVgVhEW+9cHdpk3CmDIvZMe1zgbwYkQMvXwTfCUTlOWfL EDPYYbCRbPxU2M8axYcUz61cmjhGTqfGXUBvWNVoIytpYriaBO3773Oq8b8zdsnz0pbi kz2A== X-Gm-Message-State: AOAM530Nne2nbJZ9rg9t/nX7MGYDGzJf2xv+CPVsRzHkxs65ykpn0/G+ AMQ9pA+icedREV3AfIUYaSBy+NqEdF2PX578qVNrRQ== X-Google-Smtp-Source: ABdhPJyC1vkWHqe63BdHOP8poxSwuVrurAeaA1vkzS6TO0q0xtyQ/Ji4LIxcuRG8jCJowNS2WTd51Pf+SJ7KDklg1ls= X-Received: by 2002:a5d:6092:: with SMTP id w18mr7298340wrt.75.1612419248851; Wed, 03 Feb 2021 22:14:08 -0800 (PST) MIME-Version: 1.0 References: <20210204132043.1.I2392cf11fb353d10459958100b69d93346fa167c@changeid> In-Reply-To: From: "Anand K. Mistry" Date: Thu, 4 Feb 2021 17:13:56 +1100 Message-ID: Subject: Re: [PATCH] x86: Add a prompt for HPET_EMULATE_RTC To: Randy Dunlap Cc: x86@kernel.org, Borislav Petkov , "H. Peter Anvin" , Ingo Molnar , Thomas Gleixner , Linux Kernel Mailing List Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > Hi, > > When you run "make olddefconfig", should this "depends on" > line evaluate to true or false? True. RTC_DRV_CMOS=y by default on x86 systems and HPET_TIMER also appears to default yes (on x86-64 if I'm reading this right). Oddly, the RTC config option doesn't appear to exist. Probably a separate issue. > I.e., what are the settings of these symbols in the old .config file? > > > depends on HPET_TIMER && (RTC=y || RTC=m || RTC_DRV_CMOS=m || RTC_DRV_CMOS=y) Actually, none of these options are set in the old config. RTC_DRV_CMOS and HPET_TIMER appear to default to yes. % grep HPET .config CONFIG_HPET=y # CONFIG_HPET_EMULATE_RTC is not set # CONFIG_HPET_MMAP is not set % grep RTC .config CONFIG_RTC_CLASS=y # CONFIG_HPET_EMULATE_RTC is not set CONFIG_PM_TRACE_RTC=y # CONFIG_RTC_HCTOSYS is not set > > If not, is there some out-of-tree driver involved? No out of tree drivers involved. I tried this on a vanilla 5.11-rc6. > I'm having a little trouble seeing why this is needed. So am I. But this is the magic that lets me keep CONFIG_HPET_EMULATE_RTC from the old config. I did manage to trace where the option is being overridden in the conf tool, but the reasoning why is beyond my knowledge. -- Anand K. Mistry Software Engineer Google Australia