From: "Anand K. Mistry" <amistry@google.com>
To: Thomas Zimmermann <tzimmermann@suse.de>
Cc: dri-devel@lists.freedesktop.org, nartemiev@google.com,
Daniel Vetter <daniel@ffwll.ch>, David Airlie <airlied@linux.ie>,
Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
Maxime Ripard <mripard@kernel.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] drm/prime: Fix use after free in mmap with drm_gem_ttm_mmap
Date: Wed, 3 Nov 2021 11:12:25 +1100 [thread overview]
Message-ID: <CAATStaMSFu=27LdxNOabtARGaRq7rm_k2BHSsZ9+M-fF+nnk7Q@mail.gmail.com> (raw)
In-Reply-To: <17d63b06-d1bd-85ab-92d3-71fa236b9493@suse.de>
Any movement on merging this patch? Not urgent on my end (we have this
patch in our tree), but I think other amd users might run into this
UAF.
On Thu, 30 Sept 2021 at 17:21, Thomas Zimmermann <tzimmermann@suse.de> wrote:
>
> Hi
>
> Am 30.09.21 um 01:00 schrieb Anand K Mistry:
> > drm_gem_ttm_mmap() drops a reference to the gem object on success. If
> > the gem object's refcount == 1 on entry to drm_gem_prime_mmap(), that
> > drop will free the gem object, and the subsequent drm_gem_object_get()
> > will be a UAF. Fix by grabbing a reference before calling the mmap
> > helper.
> >
> > This issue was forseen when the reference dropping was adding in
> > commit 9786b65bc61ac ("drm/ttm: fix mmap refcounting"):
> > "For that to work properly the drm_gem_object_get() call in
> > drm_gem_ttm_mmap() must be moved so it happens before calling
> > obj->funcs->mmap(), otherwise the gem refcount would go down
> > to zero."
> >
> > Signed-off-by: Anand K Mistry <amistry@google.com>
>
> Acked-by: Thomas Zimmermann <tzimmermann@suse.de>
>
> This looks fine to me, but it affects many drivers. Let's maybe wait a
> bit if more reviews come it.
>
> Best regards
> Thomas
>
> > ---
> >
> > drivers/gpu/drm/drm_prime.c | 6 ++++--
> > 1 file changed, 4 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/gpu/drm/drm_prime.c b/drivers/gpu/drm/drm_prime.c
> > index 2a54f86856af..e1854fd24bb0 100644
> > --- a/drivers/gpu/drm/drm_prime.c
> > +++ b/drivers/gpu/drm/drm_prime.c
> > @@ -719,11 +719,13 @@ int drm_gem_prime_mmap(struct drm_gem_object *obj, struct vm_area_struct *vma)
> > if (obj->funcs && obj->funcs->mmap) {
> > vma->vm_ops = obj->funcs->vm_ops;
> >
> > + drm_gem_object_get(obj);
> > ret = obj->funcs->mmap(obj, vma);
> > - if (ret)
> > + if (ret) {
> > + drm_gem_object_put(obj);
> > return ret;
> > + }
> > vma->vm_private_data = obj;
> > - drm_gem_object_get(obj);
> > return 0;
> > }
> >
> >
>
> --
> Thomas Zimmermann
> Graphics Driver Developer
> SUSE Software Solutions Germany GmbH
> Maxfeldstr. 5, 90409 Nürnberg, Germany
> (HRB 36809, AG Nürnberg)
> Geschäftsführer: Felix Imendörffer
--
Anand K. Mistry
Software Engineer
Google Australia
next prev parent reply other threads:[~2021-11-03 0:12 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-29 23:00 [PATCH] drm/prime: Fix use after free in mmap with drm_gem_ttm_mmap Anand K Mistry
2021-09-30 7:21 ` Thomas Zimmermann
2021-11-03 0:12 ` Anand K. Mistry [this message]
2021-11-03 8:55 ` Thomas Zimmermann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAATStaMSFu=27LdxNOabtARGaRq7rm_k2BHSsZ9+M-fF+nnk7Q@mail.gmail.com' \
--to=amistry@google.com \
--cc=airlied@linux.ie \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=mripard@kernel.org \
--cc=nartemiev@google.com \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).