From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1751519AbbEFVfM (ORCPT <rfc822;w@1wt.eu>);
	Wed, 6 May 2015 17:35:12 -0400
Received: from mail-qc0-f176.google.com ([209.85.216.176]:34305 "EHLO
	mail-qc0-f176.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1750868AbbEFVfK (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Wed, 6 May 2015 17:35:10 -0400
MIME-Version: 1.0
In-Reply-To: <20150430145103.GA18896@kroah.com>
References: <1429205359-12929-1-git-send-email-gdk@google.com> <20150430145103.GA18896@kroah.com>
From: Garret Kelly <gdk@google.com>
Date: Wed, 6 May 2015 14:34:49 -0700
Message-ID: <CAAUC4VKSAejfm35KDmed=2fXez8h+ZB3+thQr+yvVU4mu4g+og@mail.gmail.com>
Subject: Re: [PATCH] staging: fbtft: force cast to non-__iomem pointer
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>,
        =?UTF-8?Q?Noralf_Tr=C3=B8nnes?= <noralf@tronnes.org>,
        "open list:STAGING SUBSYSTEM" <devel@driverdev.osuosl.org>,
        open list <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset=UTF-8
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> Can't we fix this properly, to use the correct type of pointer instead
> for non-__iomem allocations?

You mean making an alternate screen_base pointer inside fb_info that
isn't __iomem?  There are already a bunch of framebuffer drivers that
(ab)use screen_base to store non-__iomem pointers, so this didn't
strike me as too far out of line.

Garret