From: Alexandre Courbot <gnurou@gmail.com>
To: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Ben Skeggs <bskeggs@redhat.com>, David Airlie <airlied@linux.ie>,
"dri-devel@lists.freedesktop.org"
<dri-devel@lists.freedesktop.org>,
"nouveau@lists.freedesktop.org" <nouveau@lists.freedesktop.org>
Subject: Re: [Nouveau] [PATCH v4 3/3] drm/nouveau/fb/nv50: defer DMA mapping of scratch page to init() hook
Date: Mon, 3 Oct 2016 14:45:59 +0900 [thread overview]
Message-ID: <CAAVeFu+E0032ykOe99W32ACgMX5ZNgYiHn4KSZ9oyEeWtjzvRg@mail.gmail.com> (raw)
In-Reply-To: <1474893160-12321-4-git-send-email-ard.biesheuvel@linaro.org>
On Mon, Sep 26, 2016 at 9:32 PM, Ard Biesheuvel
<ard.biesheuvel@linaro.org> wrote:
> The 100c08 scratch page is mapped using dma_map_page() before the TTM
> layer has had a chance to set the DMA mask. This means we are still
> running with the default of 32 when this code executes, and this causes
> problems for platforms with no memory below 4 GB (such as AMD Seattle)
>
> So move the dma_map_page() to the .init hook, which executes after the
> DMA mask has been set.
The comments I did on gf100 also apply here. The only difference is
that you will have to create the oneinit hook which does not exist in
this file.
Thanks!
prev parent reply other threads:[~2016-10-03 5:46 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-26 12:32 [PATCH v4 0/3] drm/nouveau: set DMA mask before mapping scratch page Ard Biesheuvel
2016-09-26 12:32 ` [PATCH v4 1/3] drm/nouveau: set streaming DMA mask early Ard Biesheuvel
2016-10-03 5:39 ` [Nouveau] " Alexandre Courbot
2016-10-06 12:57 ` Ard Biesheuvel
2016-09-26 12:32 ` [PATCH v4 2/3] drm/nouveau/fb/gf100: defer DMA mapping of scratch page to init() hook Ard Biesheuvel
2016-10-03 5:44 ` [Nouveau] " Alexandre Courbot
2016-09-26 12:32 ` [PATCH v4 3/3] drm/nouveau/fb/nv50: " Ard Biesheuvel
2016-10-03 5:45 ` Alexandre Courbot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAAVeFu+E0032ykOe99W32ACgMX5ZNgYiHn4KSZ9oyEeWtjzvRg@mail.gmail.com \
--to=gnurou@gmail.com \
--cc=airlied@linux.ie \
--cc=ard.biesheuvel@linaro.org \
--cc=bskeggs@redhat.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nouveau@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).