From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752081AbaCYCSC (ORCPT ); Mon, 24 Mar 2014 22:18:02 -0400 Received: from mail-ve0-f175.google.com ([209.85.128.175]:65184 "EHLO mail-ve0-f175.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751261AbaCYCSB (ORCPT ); Mon, 24 Mar 2014 22:18:01 -0400 MIME-Version: 1.0 In-Reply-To: <1395505004-22650-8-git-send-email-bigeasy@linutronix.de> References: <1395505004-22650-1-git-send-email-bigeasy@linutronix.de> <1395505004-22650-8-git-send-email-bigeasy@linutronix.de> From: Alexandre Courbot Date: Tue, 25 Mar 2014 11:17:40 +0900 Message-ID: Subject: Re: [PATCH 7/7] gpio: dwapb: use d->mask instead od BIT(bit) To: Sebastian Andrzej Siewior Cc: atull@altera.com, Linus Walleij , "linux-gpio@vger.kernel.org" , Linux Kernel Mailing List , dinguyen@altera.com, delicious.quinoa@gmail.com Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Mar 23, 2014 at 1:16 AM, Sebastian Andrzej Siewior wrote: > d->mask contains exact the same information as BIT(bit) so we could save > a few cycles here. > > Signed-off-by: Sebastian Andrzej Siewior > --- > drivers/gpio/gpio-dwapb.c | 25 ++++++++++++------------- > 1 file changed, 12 insertions(+), 13 deletions(-) > > diff --git a/drivers/gpio/gpio-dwapb.c b/drivers/gpio/gpio-dwapb.c > index 3c9cdda..ebfcf5c 100644 > --- a/drivers/gpio/gpio-dwapb.c > +++ b/drivers/gpio/gpio-dwapb.c > @@ -113,7 +113,7 @@ static void dwapb_irq_enable(struct irq_data *d) > > irq_gc_lock(igc); > val = readl(gpio->regs + GPIO_INTEN); > - val |= BIT(d->hwirq); > + val |= d->mask; > writel(val, gpio->regs + GPIO_INTEN); > irq_gc_unlock(igc); > } > @@ -126,7 +126,7 @@ static void dwapb_irq_disable(struct irq_data *d) > > irq_gc_lock(igc); > val = readl(gpio->regs + GPIO_INTEN); > - val &= ~BIT(d->hwirq); > + val &= d->mask; Shouldn't that be ~d->mask here?