From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S932484AbcGDBiB (ORCPT <rfc822;w@1wt.eu>);
	Sun, 3 Jul 2016 21:38:01 -0400
Received: from mail-it0-f66.google.com ([209.85.214.66]:35993 "EHLO
	mail-it0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S932182AbcGDBiA (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Sun, 3 Jul 2016 21:38:00 -0400
MIME-Version: 1.0
In-Reply-To: <CAGt4E5uusNK3vtBo5N9FyUTuWCpMtQS1KC1mHVCq5iFzFJpJFg@mail.gmail.com>
References: <1467330612-26242-1-git-send-email-mmayer@broadcom.com>
 <1467330612-26242-3-git-send-email-mmayer@broadcom.com> <CAAVeFuKabYS8s42GghnDSNe_AVa5v+1w_OHiR6cEgdU0_Dz7UA@mail.gmail.com>
 <CAGt4E5uusNK3vtBo5N9FyUTuWCpMtQS1KC1mHVCq5iFzFJpJFg@mail.gmail.com>
From: Alexandre Courbot <gnurou@gmail.com>
Date: Mon, 4 Jul 2016 10:37:39 +0900
Message-ID: <CAAVeFu+fwtEXG2sWkCqKDsybykeG_pvUWKCL26mYXpzEGi7vtQ@mail.gmail.com>
Subject: Re: [Nouveau] [PATCH 2/6] drm/nouveau/core: make use of new
 strtolower() function
To: Markus Mayer <markus.mayer@broadcom.com>
Cc: Ben Skeggs <bskeggs@redhat.com>, David Airlie <airlied@linux.ie>,
        Alexandre Courbot <acourbot@nvidia.com>,
        "nouveau@lists.freedesktop.org" <nouveau@lists.freedesktop.org>,
        "dri-devel@lists.freedesktop.org" <dri-devel@lists.freedesktop.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset=UTF-8
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Sun, Jul 3, 2016 at 12:21 AM, Markus Mayer <markus.mayer@broadcom.com> wrote:
> On 1 July 2016 at 18:18, Alexandre Courbot <gnurou@gmail.com> wrote:
>> On Fri, Jul 1, 2016 at 8:50 AM, Markus Mayer <mmayer@broadcom.com> wrote:
>>> Call strtolower() rather than walking the string explicitly to convert
>>> it to lowercase.
>>>
>>> Signed-off-by: Markus Mayer <mmayer@broadcom.com>
>>> ---
>>>  drivers/gpu/drm/nouveau/nvkm/core/firmware.c | 7 +------
>>>  1 file changed, 1 insertion(+), 6 deletions(-)
>>>
>>> diff --git a/drivers/gpu/drm/nouveau/nvkm/core/firmware.c b/drivers/gpu/drm/nouveau/nvkm/core/firmware.c
>>> index 34ecd4a..c50594c 100644
>>> --- a/drivers/gpu/drm/nouveau/nvkm/core/firmware.c
>>> +++ b/drivers/gpu/drm/nouveau/nvkm/core/firmware.c
>>> @@ -36,16 +36,11 @@ nvkm_firmware_get(struct nvkm_device *device, const char *fwname,
>>>  {
>>>         char f[64];
>>>         char cname[16];
>>> -       int i;
>>>
>>>         /* Convert device name to lowercase */
>>>         strncpy(cname, device->chip->name, sizeof(cname));
>>>         cname[sizeof(cname) - 1] = '\0';
>>> -       i = strlen(cname);
>>> -       while (i) {
>>> -               --i;
>>> -               cname[i] = tolower(cname[i]);
>>> -       }
>>> +       strtolower(cname);
>>
>> This function doesn't seem to exist as of next-20160701, where have
>> you found it?
>
> I didn't find it. I wrote it, because it didn't exist and I needed it.
> See: https://lkml.org/lkml/2016/6/30/727 and
> https://lkml.org/lkml/2016/6/30/733 (cover letter and first patch in
> series).

Ah, right - would have been easier to understand if you had sent the
whole series (or at least patches 0 to 2) to us as well. Please do
that for the next version.