From: Todd Poynor <toddpoynor@google.com>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: "toddpoynor@gmail.com" <toddpoynor@gmail.com>,
Rob Springer <rspringer@google.com>,
benchan@chromium.org, devel@driverdev.osuosl.org,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 01/11] staging: gasket: core: debug log updates
Date: Mon, 15 Oct 2018 13:33:35 -0700 [thread overview]
Message-ID: <CAAW3YpYHo=PZk_AHVD8O6E+D+Ky=LSQpWQ6gBPYCt5rRGEMXXQ@mail.gmail.com> (raw)
In-Reply-To: <20181015073436.GC14476@kroah.com>
On Mon, Oct 15, 2018 at 12:34 AM Greg Kroah-Hartman
<gregkh@linuxfoundation.org> wrote:
>
> On Sun, Oct 14, 2018 at 09:59:17PM -0700, Todd Poynor wrote:
> > From: Todd Poynor <toddpoynor@google.com>
> >
> > Add debug logs for device enable/disable events,
>
> Why?
>
> What is going to need this?
As one of the few people actually developing for Apex chips (but this
may be more soon), I ran into a situation where I cared about this.
But I usually cobble together custom debugging for development
situations, and generally don't get debug logs for
released-in-the-wild drivers, so I'm fine not including these or any
other debug logs.
It sounds like debug logs face a pretty high bar for acceptance. I'm
happy to send a patch removing all of 'em from gasket/apex if that's
preferred.
> > remove logs for
> > callbacks (the called functions can generate their own logs if needed).
>
> That's a different thing than "adding" them, so shouldn't this really be
> 2 patches? If it was, I could have accepted this patch already, and
> ignored the "add new logs" one :)
Sure, the callbacks most frequently occur during disable/enable events
and were linked in my brain, but will send a new patch to just remove
the useless callback logs.
>
> thanks,
>
> greg k-h
next prev parent reply other threads:[~2018-10-15 20:33 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-15 4:59 [PATCH 00/11] staging: gasket: fixes Todd Poynor
2018-10-15 4:59 ` [PATCH 01/11] staging: gasket: core: debug log updates Todd Poynor
2018-10-15 7:34 ` Greg Kroah-Hartman
2018-10-15 20:33 ` Todd Poynor [this message]
2018-10-15 4:59 ` [PATCH 02/11] staging: gasket: page table: return valid error code on map fail Todd Poynor
2018-10-15 4:59 ` [PATCH 03/11] staging: gasket: page table: remove dead code in coherent mem alloc Todd Poynor
2018-10-15 4:59 ` [PATCH 04/11] staging: gasket: page_table: remove unnecessary PTE status set to free Todd Poynor
2018-10-15 4:59 ` [PATCH 05/11] staging: gasket: page_table: rearrange gasket_page_table_entry Todd Poynor
2018-10-15 7:37 ` Greg Kroah-Hartman
2018-10-15 4:59 ` [PATCH 06/11] staging: gasket: page table: fixup error path allocating coherent mem Todd Poynor
2018-10-15 4:59 ` [PATCH 07/11] staging: gasket: page_table: fix comment in components_to_dev_address Todd Poynor
2018-10-15 4:59 ` [PATCH 08/11] staging: gasket: page_table: simplify gasket_components_to_dev_address Todd Poynor
2018-10-15 4:59 ` [PATCH 09/11] staging: gasket: apex: fix sysfs_show Todd Poynor
2018-10-15 4:59 ` [PATCH 10/11] staging: gasket: sysfs: fix attribute release comment Todd Poynor
2018-10-15 4:59 ` [PATCH 11/11] staging: gasket: Update device virtual address comment Todd Poynor
2018-10-15 7:33 ` [PATCH 00/11] staging: gasket: fixes Greg Kroah-Hartman
2018-10-15 10:19 ` Todd Poynor
2018-10-15 10:29 ` Christoph Hellwig
2018-10-15 10:35 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAAW3YpYHo=PZk_AHVD8O6E+D+Ky=LSQpWQ6gBPYCt5rRGEMXXQ@mail.gmail.com' \
--to=toddpoynor@google.com \
--cc=benchan@chromium.org \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rspringer@google.com \
--cc=toddpoynor@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).