linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Mark Fasheh <mfasheh@versity.com>
To: Gang He <ghe@suse.com>
Cc: Joel Becker <jlbec@evilplan.org>,
	linux-kernel@vger.kernel.org, ocfs2-devel@oss.oracle.com,
	Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH v2 2/4] ocfs2: fix some small problems
Date: Wed, 28 Dec 2016 16:34:08 -0600	[thread overview]
Message-ID: <CAAXPY_LMr3a8D=YB0-My9gZqbGQBMN3sic3-1wnicRhnT8F+_g@mail.gmail.com> (raw)
In-Reply-To: <1482308461-12964-3-git-send-email-ghe@suse.com>

Hi Gang, one small comment below:

On Wed, Dec 21, 2016 at 2:20 AM, Gang He <ghe@suse.com> wrote:
> First, move setting fe_done = 1 in spin lock, avoid bring
> any potential race condition. Second, tune mlog message level
> from ERROR to NOTICE, since the message should not belong to
> error message.
>
> Signed-off-by: Gang He <ghe@suse.com>
> ---
>  fs/ocfs2/filecheck.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
>
> @@ -545,11 +545,11 @@ static ssize_t ocfs2_filecheck_store(struct kobject *kobj,
>         spin_lock(&ent->fs_fcheck->fc_lock);
>         if ((ent->fs_fcheck->fc_size >= ent->fs_fcheck->fc_max) &&
>             (ent->fs_fcheck->fc_done == 0)) {
> -               mlog(ML_ERROR,
> +               mlog(ML_NOTICE,
>                 "Cannot do more file check "
>                 "since file check queue(%u) is full now\n",
>                 ent->fs_fcheck->fc_max);
> -               ret = -EBUSY;
> +               ret = -EAGAIN;

This change wasn't described in the patch header. Granted, from the
message above the change, -EAGAIN certainly seems a more reasonable
return value but it would be good to know whether this was intended
and why.

Thanks,
   --Mark

  reply	other threads:[~2016-12-28 22:34 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-12-21  8:20 [PATCH v2 0/4] ocfs2: use kobject for online file check Gang He
2016-12-21  8:20 ` [PATCH v2 1/4] ocfs2: move some definitions to header file Gang He
2016-12-21  8:20 ` [PATCH v2 2/4] ocfs2: fix some small problems Gang He
2016-12-28 22:34   ` Mark Fasheh [this message]
2016-12-29  2:54     ` Gang He
2016-12-21  8:21 ` [PATCH v2 3/4] ocfs2: add kobject for online file check Gang He
2016-12-21  8:21 ` [PATCH v2 4/4] ocfs2: add duplicative ino number check Gang He

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAAXPY_LMr3a8D=YB0-My9gZqbGQBMN3sic3-1wnicRhnT8F+_g@mail.gmail.com' \
    --to=mfasheh@versity.com \
    --cc=akpm@linux-foundation.org \
    --cc=ghe@suse.com \
    --cc=jlbec@evilplan.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=ocfs2-devel@oss.oracle.com \
    --subject='Re: [PATCH v2 2/4] ocfs2: fix some small problems' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).