From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752111AbcL1WeM (ORCPT ); Wed, 28 Dec 2016 17:34:12 -0500 Received: from mail-lf0-f47.google.com ([209.85.215.47]:36648 "EHLO mail-lf0-f47.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751890AbcL1WeK (ORCPT ); Wed, 28 Dec 2016 17:34:10 -0500 MIME-Version: 1.0 In-Reply-To: <1482308461-12964-3-git-send-email-ghe@suse.com> References: <1482308461-12964-1-git-send-email-ghe@suse.com> <1482308461-12964-3-git-send-email-ghe@suse.com> From: Mark Fasheh Date: Wed, 28 Dec 2016 16:34:08 -0600 Message-ID: Subject: Re: [PATCH v2 2/4] ocfs2: fix some small problems To: Gang He Cc: Joel Becker , linux-kernel@vger.kernel.org, ocfs2-devel@oss.oracle.com, Andrew Morton Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Gang, one small comment below: On Wed, Dec 21, 2016 at 2:20 AM, Gang He wrote: > First, move setting fe_done = 1 in spin lock, avoid bring > any potential race condition. Second, tune mlog message level > from ERROR to NOTICE, since the message should not belong to > error message. > > Signed-off-by: Gang He > --- > fs/ocfs2/filecheck.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > @@ -545,11 +545,11 @@ static ssize_t ocfs2_filecheck_store(struct kobject *kobj, > spin_lock(&ent->fs_fcheck->fc_lock); > if ((ent->fs_fcheck->fc_size >= ent->fs_fcheck->fc_max) && > (ent->fs_fcheck->fc_done == 0)) { > - mlog(ML_ERROR, > + mlog(ML_NOTICE, > "Cannot do more file check " > "since file check queue(%u) is full now\n", > ent->fs_fcheck->fc_max); > - ret = -EBUSY; > + ret = -EAGAIN; This change wasn't described in the patch header. Granted, from the message above the change, -EAGAIN certainly seems a more reasonable return value but it would be good to know whether this was intended and why. Thanks, --Mark