From: Doug Smythies <dsmythies@telus.net>
To: "Rafael J. Wysocki" <rjw@rjwysocki.net>
Cc: "Rafael J. Wysocki" <rafael@kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
Linux PM <linux-pm@vger.kernel.org>,
dsmythies <dsmythies@telus.net>
Subject: Re: [PATCH v1 0/5] cpuidle: teo: Rework the idle state selection logic
Date: Thu, 29 Jul 2021 20:36:49 -0700 [thread overview]
Message-ID: <CAAYoRsUn853=yFbYtD+GkbGVTxw8pzo8iZGp1NWkab0vHGpanw@mail.gmail.com> (raw)
In-Reply-To: <4334837.LvFx2qVVIh@kreacher>
On Thu, Jul 29, 2021 at 9:14 AM Rafael J. Wysocki <rjw@rjwysocki.net> wrote:
>
... [snip]...
>
> This means that idle state 0 data are disregarded after disabling it
> and that most likely is because the second loop in teo_select() should
> be over all states down to idle state 0 (not only down to the first
> enabled one).
>
> So below is an updated patch (not tested yet).
Hi Rafael,
This updated patch works great / solves the problem.
Tested-by: Doug Smythies <dsmythies@telus.net>
Thank you very much.
... Doug
>
> ---
> drivers/cpuidle/governors/teo.c | 28 +++++++++++++++-------------
> 1 file changed, 15 insertions(+), 13 deletions(-)
>
> Index: linux-pm/drivers/cpuidle/governors/teo.c
> ===================================================================
> --- linux-pm.orig/drivers/cpuidle/governors/teo.c
> +++ linux-pm/drivers/cpuidle/governors/teo.c
> @@ -397,32 +397,34 @@ static int teo_select(struct cpuidle_dri
> intercept_sum = 0;
> recent_sum = 0;
>
> - for (i = idx - 1; i >= idx0; i--) {
> + for (i = idx - 1; i >= 0; i--) {
> struct teo_bin *bin = &cpu_data->state_bins[i];
> s64 span_ns;
>
> intercept_sum += bin->intercepts;
> recent_sum += bin->recent;
>
> - if (dev->states_usage[i].disable)
> + if (dev->states_usage[i].disable && i > 0)
> continue;
>
> span_ns = teo_middle_of_bin(i, drv);
> - if (!teo_time_ok(span_ns)) {
> - /*
> - * The current state is too shallow, so select
> - * the first enabled deeper state.
> - */
> - duration_ns = last_enabled_span_ns;
> - idx = last_enabled_idx;
> - break;
> - }
>
> if ((!alt_recent || 2 * recent_sum > idx_recent_sum) &&
> (!alt_intercepts ||
> 2 * intercept_sum > idx_intercept_sum)) {
> - idx = i;
> - duration_ns = span_ns;
> + if (!teo_time_ok(span_ns) ||
> + dev->states_usage[i].disable) {
> + /*
> + * The current state is too shallow or
> + * disabled, so select the first enabled
> + * deeper state.
> + */
> + duration_ns = last_enabled_span_ns;
> + idx = last_enabled_idx;
> + } else {
> + idx = i;
> + duration_ns = span_ns;
> + }
> break;
> }
next prev parent reply other threads:[~2021-07-30 3:37 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-02 18:14 [PATCH v1 0/5] cpuidle: teo: Rework the idle state selection logic Rafael J. Wysocki
2021-06-02 18:15 ` [PATCH v1 1/5] cpuidle: teo: Cosmetic modifications of teo_update() Rafael J. Wysocki
2021-06-02 18:15 ` [PATCH v1 2/5] cpuidle: teo: Cosmetic modification of teo_select() Rafael J. Wysocki
2021-06-02 18:16 ` [PATCH v1 3/5] cpuidle: teo: Change the main idle state selection logic Rafael J. Wysocki
2021-06-02 18:17 ` [PATCH v1 4/5] cpuidle: teo: Rework most recent idle duration values treatment Rafael J. Wysocki
2021-06-02 18:18 ` [PATCH v1 5/5] cpuidle: teo: Use kerneldoc documentation in admin-guide Rafael J. Wysocki
2021-07-04 21:01 ` [PATCH v1 0/5] cpuidle: teo: Rework the idle state selection logic Doug Smythies
2021-07-05 13:24 ` Rafael J. Wysocki
2021-07-27 20:06 ` Doug Smythies
2021-07-28 13:52 ` Rafael J. Wysocki
2021-07-28 17:47 ` Rafael J. Wysocki
2021-07-29 6:34 ` Doug Smythies
2021-07-29 15:23 ` Doug Smythies
2021-07-29 16:18 ` Rafael J. Wysocki
2021-07-29 16:14 ` Rafael J. Wysocki
2021-07-30 3:36 ` Doug Smythies [this message]
2021-07-30 13:25 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAAYoRsUn853=yFbYtD+GkbGVTxw8pzo8iZGp1NWkab0vHGpanw@mail.gmail.com' \
--to=dsmythies@telus.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=rafael@kernel.org \
--cc=rjw@rjwysocki.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).