From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754692Ab3A1JIm (ORCPT ); Mon, 28 Jan 2013 04:08:42 -0500 Received: from mail-vc0-f181.google.com ([209.85.220.181]:53512 "EHLO mail-vc0-f181.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751176Ab3A1JIi convert rfc822-to-8bit (ORCPT ); Mon, 28 Jan 2013 04:08:38 -0500 MIME-Version: 1.0 In-Reply-To: <1359282808-31398-3-git-send-email-geert@linux-m68k.org> References: <1359282808-31398-1-git-send-email-geert@linux-m68k.org> <1359282808-31398-3-git-send-email-geert@linux-m68k.org> Date: Mon, 28 Jan 2013 17:08:37 +0800 Message-ID: Subject: Re: [uclinux-dist-devel] [PATCH v2 2/9] blackfin: Provide dma_mmap_coherent() and dma_get_sgtable() From: Bob Liu To: Geert Uytterhoeven Cc: linux-arch@vger.kernel.org, uclinux-dist-devel@blackfin.uclinux.org, linux-kernel@vger.kernel.org, Marek Szyprowski Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Jan 27, 2013 at 6:33 PM, Geert Uytterhoeven wrote: > blackfin/allmodconfig: > > drivers/media/v4l2-core/videobuf2-dma-contig.c: In function ‘vb2_dc_mmap’: > drivers/media/v4l2-core/videobuf2-dma-contig.c:204: error: implicit declaration of function ‘dma_mmap_coherent’ > drivers/media/v4l2-core/videobuf2-dma-contig.c: In function ‘vb2_dc_get_base_sgt’: > drivers/media/v4l2-core/videobuf2-dma-contig.c:387: error: implicit declaration of function ‘dma_get_sgtable’ > > For architectures using dma_map_ops, dma_mmap_coherent() and > dma_get_sgtable() are provided in . > > Blackfin does not use dma_map_ops, hence it should implement them as inline > stubs using dma_common_mmap() and dma_common_get_sgtable(). > > Signed-off-by: Geert Uytterhoeven > Cc: Marek Szyprowski > Cc: uclinux-dist-devel@blackfin.uclinux.org > Acked-by: Scott Jiang Thanks, Will be applied to my blackfin arch tree. > --- > v2: No changes > --- > arch/blackfin/include/asm/dma-mapping.h | 10 ++++++++++ > 1 files changed, 10 insertions(+), 0 deletions(-) > > diff --git a/arch/blackfin/include/asm/dma-mapping.h b/arch/blackfin/include/asm/dma-mapping.h > index bbf4610..054d9ec 100644 > --- a/arch/blackfin/include/asm/dma-mapping.h > +++ b/arch/blackfin/include/asm/dma-mapping.h > @@ -154,4 +154,14 @@ dma_cache_sync(struct device *dev, void *vaddr, size_t size, > _dma_sync((dma_addr_t)vaddr, size, dir); > } > > +/* drivers/base/dma-mapping.c */ > +extern int dma_common_mmap(struct device *dev, struct vm_area_struct *vma, > + void *cpu_addr, dma_addr_t dma_addr, size_t size); > +extern int dma_common_get_sgtable(struct device *dev, struct sg_table *sgt, > + void *cpu_addr, dma_addr_t dma_addr, > + size_t size); > + > +#define dma_mmap_coherent(d, v, c, h, s) dma_common_mmap(d, v, c, h, s) > +#define dma_get_sgtable(d, t, v, h, s) dma_common_get_sgtable(d, t, v, h, s) > + > #endif /* _BLACKFIN_DMA_MAPPING_H */ > -- > 1.7.0.4 > -- Regards, --Bob