From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.7 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B6D49C3A59E for ; Wed, 21 Aug 2019 04:32:27 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 8F06522DA7 for ; Wed, 21 Aug 2019 04:32:26 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727630AbfHUEcZ (ORCPT ); Wed, 21 Aug 2019 00:32:25 -0400 Received: from ajax.cs.uga.edu ([128.192.4.6]:44158 "EHLO ajax.cs.uga.edu" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725866AbfHUEcZ (ORCPT ); Wed, 21 Aug 2019 00:32:25 -0400 Received: from mail-lj1-f171.google.com (mail-lj1-f171.google.com [209.85.208.171]) (authenticated bits=0) by ajax.cs.uga.edu (8.14.4/8.14.4) with ESMTP id x7L4WMoe069266 (version=TLSv1/SSLv3 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Wed, 21 Aug 2019 00:32:23 -0400 Received: by mail-lj1-f171.google.com with SMTP id l1so795910lji.12; Tue, 20 Aug 2019 21:32:23 -0700 (PDT) X-Gm-Message-State: APjAAAUL11Gw39KpL4NYef24UhbT582GgezPL+E++gdp13coDwblbYkw n40Psyg8TDmXil8gmZGOkJRWycFg3HeKMPxzbJM= X-Google-Smtp-Source: APXvYqwJHnVp3pdE4Bg3YqrbSEYEU0E+uUeX0LYZnhept2ioLf2LEA9SBYVSnw5rPgmOuKsCzmsz5ZDPTJNOx9P70bM= X-Received: by 2002:a2e:5c5:: with SMTP id 188mr2582725ljf.166.1566361942335; Tue, 20 Aug 2019 21:32:22 -0700 (PDT) MIME-Version: 1.0 References: <1565690709-3186-1-git-send-email-wenwen@cs.uga.edu> In-Reply-To: From: Wenwen Wang Date: Wed, 21 Aug 2019 00:31:46 -0400 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [EXT] [PATCH] qed: Add cleanup in qed_slowpath_start() To: Sudarsana Reddy Kalluru Cc: Ariel Elior , GR-everest-linux-l2 , "David S. Miller" , "open list:QLOGIC QL4xxx ETHERNET DRIVER" , open list , Wenwen Wang Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Aug 13, 2019 at 6:46 AM Sudarsana Reddy Kalluru wrote: > > > -----Original Message----- > > From: Wenwen Wang > > Sent: Tuesday, August 13, 2019 3:35 PM > > To: Wenwen Wang > > Cc: Ariel Elior ; GR-everest-linux-l2 > l2@marvell.com>; David S. Miller ; open > > list:QLOGIC QL4xxx ETHERNET DRIVER ; open list > > > > Subject: [EXT] [PATCH] qed: Add cleanup in qed_slowpath_start() > > > > External Email > > > > ---------------------------------------------------------------------- > > If qed_mcp_send_drv_version() fails, no cleanup is executed, leading to > > memory leaks. To fix this issue, redirect the execution to the label 'err3' > > before returning the error. > > > > Signed-off-by: Wenwen Wang > > --- > > drivers/net/ethernet/qlogic/qed/qed_main.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/net/ethernet/qlogic/qed/qed_main.c > > b/drivers/net/ethernet/qlogic/qed/qed_main.c > > index 829dd60..d16a251 100644 > > --- a/drivers/net/ethernet/qlogic/qed/qed_main.c > > +++ b/drivers/net/ethernet/qlogic/qed/qed_main.c > > @@ -1325,7 +1325,7 @@ static int qed_slowpath_start(struct qed_dev > > *cdev, > > &drv_version); > > if (rc) { > > DP_NOTICE(cdev, "Failed sending drv version > > command\n"); > > - return rc; > > + goto err3; > > In this case, we might need to free the ll2-buf allocated at the below path (?), > 1312 /* Allocate LL2 interface if needed */ > 1313 if (QED_LEADING_HWFN(cdev)->using_ll2) { > 1314 rc = qed_ll2_alloc_if(cdev); > May be by adding a new goto label 'err4'. Thanks for your suggestion! I will rework the patch. Wenwen > > > } > > } > > > > -- > > 2.7.4 >