From: Kai-Heng Feng <kai.heng.feng@canonical.com>
To: Ilia Mirkin <imirkin@alum.mit.edu>
Cc: Takashi Iwai <tiwai@suse.de>,
"moderated list:SOUND" <alsa-devel@alsa-project.org>,
Kai Vehmanen <kai.vehmanen@linux.intel.com>,
nouveau <nouveau@lists.freedesktop.org>,
open list <linux-kernel@vger.kernel.org>,
Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>,
tiwai@suse.com, Bjorn Helgaas <bhelgaas@google.com>,
Alan Stern <stern@rowland.harvard.edu>,
Linux PCI <linux-pci@vger.kernel.org>,
Alex Deucher <alexander.deucher@amd.com>,
Jaroslav Kysela <perex@perex.cz>, Mike Rapoport <rppt@kernel.org>
Subject: Re: [Nouveau] [PATCH v2] ALSA: hda: Continue to probe when codec probe fails
Date: Tue, 22 Dec 2020 10:49:53 +0800 [thread overview]
Message-ID: <CAAd53p4=bSX26QzsPyV1sxADiuVn2sowWyb5JFDoPZQ+ZYoCzA@mail.gmail.com> (raw)
In-Reply-To: <CAKb7UvjWX7xbwMKtnad5EVy16nY1M-A13YJeRWyUwHzemcVswA@mail.gmail.com>
On Tue, Dec 22, 2020 at 1:56 AM Ilia Mirkin <imirkin@alum.mit.edu> wrote:
>
> On Mon, Dec 21, 2020 at 11:33 AM Kai-Heng Feng
> <kai.heng.feng@canonical.com> wrote:
> >
> > [+Cc nouveau]
> >
> > On Fri, Dec 18, 2020 at 4:06 PM Takashi Iwai <tiwai@suse.de> wrote:
> > [snip]
> > > > Quite possibly the system doesn't power up HDA controller when there's
> > > > no external monitor.
> > > > So when it's connected to external monitor, it's still needed for HDMI audio.
> > > > Let me ask the user to confirm this.
> > >
> > > Yeah, it's the basic question whether the HD-audio is supposed to work
> > > on this machine at all. If yes, the current approach we take makes
> > > less sense - instead we should rather make the HD-audio controller
> > > working.
> >
> > Yea, confirmed that the Nvidia HDA works when HDMI is connected prior boot.
> >
> > > > > - The second problem is that pci_enable_device() ignores the error
> > > > > returned from pci_set_power_state() if it's -EIO. And the
> > > > > inaccessible access error returns -EIO, although it's rather a fatal
> > > > > problem. So the driver believes as the PCI device gets enabled
> > > > > properly.
> > > >
> > > > This was introduced in 2005, by Alan's 11f3859b1e85 ("[PATCH] PCI: Fix
> > > > regression in pci_enable_device_bars") to fix UHCI controller.
> > > >
> > > > >
> > > > > - The third problem is that HD-audio driver blindly believes the
> > > > > codec_mask read from the register even if it's a read failure as I
> > > > > already showed.
> > > >
> > > > This approach has least regression risk.
> > >
> > > Yes, but it assumes that HD-audio is really non-existent.
> >
> > I really don't know any good approach to address this.
> > On Windows, HDA PCI is "hidden" until HDMI cable is plugged, then the
> > driver will flag the magic bit to make HDA audio appear on the PCI
> > bus.
> > IIRC the current approach is to make nouveau and device link work.
>
> I don't have the full context of this discussion, but the kernel
> force-enables the HDA subfunction nowadays, irrespective of nouveau or
> nvidia or whatever:
That's the problem.
The nvidia HDA controller on the affected system only gets its power
after HDMI cable plugged, so the probe on boot fails.
Kai-Heng
>
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/drivers/pci/quirks.c?h=v5.10#n5267
>
> Cheers,
>
> -ilia
next prev parent reply other threads:[~2020-12-22 2:51 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-14 6:06 [PATCH] ALSA: hda: Enable runtime PM when codec probe fails Kai-Heng Feng
2020-12-14 7:58 ` Takashi Iwai
2020-12-16 12:47 ` [PATCH v2] ALSA: hda: Continue to probe " Kai-Heng Feng
2020-12-16 15:41 ` Takashi Iwai
2020-12-16 15:50 ` Kai-Heng Feng
2020-12-16 15:58 ` Takashi Iwai
2020-12-16 16:07 ` Kai-Heng Feng
2020-12-16 16:22 ` Takashi Iwai
2020-12-16 16:57 ` Takashi Iwai
2020-12-18 5:09 ` Kai-Heng Feng
2020-12-18 8:06 ` Takashi Iwai
2020-12-21 16:33 ` Kai-Heng Feng
2020-12-21 16:47 ` Takashi Iwai
2020-12-21 17:15 ` Kai-Heng Feng
2020-12-21 17:56 ` [Nouveau] " Ilia Mirkin
2020-12-22 2:49 ` Kai-Heng Feng [this message]
2021-01-04 13:20 ` Karol Herbst
2021-04-10 15:51 ` Roy Spliet
2021-04-10 19:23 ` Lukas Wunner
2021-04-10 20:48 ` Roy Spliet
2021-04-12 19:06 ` Aaron Plattner
2021-04-12 19:36 ` Roy Spliet
2021-04-12 20:00 ` Aaron Plattner
2021-04-12 20:03 ` Ilia Mirkin
2021-04-13 0:10 ` Karol Herbst
2021-04-13 8:24 ` Roy Spliet
2021-04-13 9:48 ` Karol Herbst
2021-04-13 11:17 ` Roy Spliet
2021-04-13 11:49 ` Karol Herbst
2021-06-25 12:45 ` Paul Cercueil
2021-07-02 17:59 ` Paul Cercueil
2021-07-02 18:26 ` Paul Cercueil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAAd53p4=bSX26QzsPyV1sxADiuVn2sowWyb5JFDoPZQ+ZYoCzA@mail.gmail.com' \
--to=kai.heng.feng@canonical.com \
--cc=alexander.deucher@amd.com \
--cc=alsa-devel@alsa-project.org \
--cc=bhelgaas@google.com \
--cc=imirkin@alum.mit.edu \
--cc=kai.vehmanen@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=nouveau@lists.freedesktop.org \
--cc=perex@perex.cz \
--cc=pierre-louis.bossart@linux.intel.com \
--cc=rppt@kernel.org \
--cc=stern@rowland.harvard.edu \
--cc=tiwai@suse.com \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).