From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1752373AbdHGIAJ (ORCPT <rfc822;w@1wt.eu>);
        Mon, 7 Aug 2017 04:00:09 -0400
Received: from mail-wr0-f175.google.com ([209.85.128.175]:34726 "EHLO
        mail-wr0-f175.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1752161AbdHGIAI (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Mon, 7 Aug 2017 04:00:08 -0400
MIME-Version: 1.0
In-Reply-To: <20170807075150.GN2369@lahna.fi.intel.com>
References: <20170807044912.18146-1-kai.heng.feng@canonical.com>
 <CAAd53p5c+MHuviVjEi0=oJ0eEE3atW181PsHpCjfqnhtHBy=GA@mail.gmail.com>
 <20170807070254.GL2369@lahna.fi.intel.com> <CAAd53p6M0Vh7xsa3UfEV_fmnbXfyi9knUQvbNRkhGdZrHtSEMQ@mail.gmail.com>
 <20170807075150.GN2369@lahna.fi.intel.com>
From: Kai-Heng Feng <kai.heng.feng@canonical.com>
Date: Mon, 7 Aug 2017 16:00:06 +0800
Message-ID: <CAAd53p6uJ_LRtLycay=bQG1TsnWeDcKx_b6ZK650-m91vMHWAg@mail.gmail.com>
Subject: Re: [PATCH] thunderbolt: icm: Remove Apple check for Alpine Ridge
To: Mika Westerberg <mika.westerberg@linux.intel.com>
Cc: LKML <linux-kernel@vger.kernel.org>, andreas.noever@gmail.com,
        michael.jamet@intel.com, yehezkel.bernat@intel.com
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, Aug 7, 2017 at 3:51 PM, Mika Westerberg
<mika.westerberg@linux.intel.com> wrote:
> At this point we should find out that the ICM is already running and the
> function never calls pci2cio_write().

I guess you mean this code section:

        /* Check if the ICM firmware is already running */
        val = ioread32(nhi->iobase + REG_FW_STS);
        if (val & REG_FW_STS_ICM_EN)
                return 0;

>
> The reason why it is not happening needs to be resolved.
>
>>       pcie2cio_write()
>>         pci_write_config_dword(pdev, vnd_cap + PCIE2CIO_WRDATA, data);
>>
>> > Is there an actual issue you are trying to solve here?
>>
>> Yes, please take a look at [1].
>>
>> Although both the patch I sent and the diff above still failed to
>> probe the device
>> But there are no more NULL pointer dereference.
>>
>> [1]  https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1708043/comments/11
>
> I would like to understand what the actual problem is here because in
> normal cases we should not end up starting ICM firmware in the first
> place.
>
> So no, let's not fix it like this until we know the root cause.
>
> I'll be participating the discussion on the above bug in hopes we could
> figure out the root cause.

Thanks for the information and explanation.