From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 55758ECAAA3 for ; Fri, 26 Aug 2022 02:33:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S243483AbiHZCdW (ORCPT ); Thu, 25 Aug 2022 22:33:22 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60600 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S242671AbiHZCdU (ORCPT ); Thu, 25 Aug 2022 22:33:20 -0400 Received: from smtp-relay-internal-1.canonical.com (smtp-relay-internal-1.canonical.com [185.125.188.123]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 37154CCD71 for ; Thu, 25 Aug 2022 19:33:18 -0700 (PDT) Received: from mail-ot1-f71.google.com (mail-ot1-f71.google.com [209.85.210.71]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by smtp-relay-internal-1.canonical.com (Postfix) with ESMTPS id 89BF43F0A2 for ; Fri, 26 Aug 2022 02:33:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=canonical.com; s=20210705; t=1661481196; bh=nUe5FUkp5BM8mlUb6+rDyzPScCmSYf6H5ZIbxJFBzKI=; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject: To:Cc:Content-Type; b=K6UhQpsY49bimB/8FOmwfQPvCNmha7Q9UtNIsY8cHesIE1ZErfmCulInwbTRpxd4u XK7rL5lU1SOa4UeqZrGP4Vk2eIOdtq7xSjLseqEITK+WxwJDdVdtrwADySOCTZVJ6V EnaLExGYjAukVjK0ngnqXQ/pGvNh0F6+SaAZsOnGD5yzKAua1Tbx4XCuik/o7uQ4lK q4349RYHuuEp7iGBngyucvfpS2DqGQvN0IcwuHBQk1ZRJ+xL8dSzSo2YBiPaZRzp+a 4kUsj6z6FoIz0PrZi2cSIe0/NU2OFIAnC9D3SudP+zNUJHLbSuUSASKWNbrwSU4oJe YqKaVSZgI/C9g== Received: by mail-ot1-f71.google.com with SMTP id cp8-20020a056830660800b006388a844bdaso129704otb.17 for ; Thu, 25 Aug 2022 19:33:16 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc; bh=nUe5FUkp5BM8mlUb6+rDyzPScCmSYf6H5ZIbxJFBzKI=; b=aIgm6AQzvs+omqofiOCnEd/PLwaEapSTFYHTtwJebadD7FIQjSQJByrBbjWQVOVedf j3AFUe4MZcA7fZSZbS1ThBNucZdixgk6f0T0L3GhUuDOWYMP2HgddUmmcUSPoE/dYO84 GxbUELPEPAzAicUvqCRDT/2O32AT1pwlPwfD90kkJTi57PCzf7FPr8FLnwXjBsOFZ2q+ 1Wkr+5jorN8KR9zHcA/ZJVwSmYD9FDfyBBiHSXzYHwhU2Ck1oojvtqRoFhLEcuO5Gqm/ AGQu0D3Vrt6CGjdxj8Mq9aCEyG0C3zFW5ftNmqb6IarGUSyoR/sm7bLUJQ2sgnNgpzA4 MMgQ== X-Gm-Message-State: ACgBeo04SAVE89r5UycHS3mw/CGaq2Z3TdrYtzIa9gz/VH71H152VHfe xLUGasfsCCI7t+7kq9EbfWEGw8WNgIwyO7EYTX6Sf62mIsfwxN9oPnKkXYKiIbQEE/J7d5px+qx +nRrZWPH9Ikkyr4riK2i7jdk2MGt3xIGkLUA8Kw1ns7y9fPLQnzRcw3TZFA== X-Received: by 2002:a05:6830:56:b0:639:bbb:f0cf with SMTP id d22-20020a056830005600b006390bbbf0cfmr640895otp.161.1661481195523; Thu, 25 Aug 2022 19:33:15 -0700 (PDT) X-Google-Smtp-Source: AA6agR7TFBWGF0ixay4ZBvqbgrqxXt9V5BPVUWMtfHjty3Dd9xD2Siok+CMHe9Hpq+thX/xTUOqz6zLVJPjb2dI3opU= X-Received: by 2002:a05:6830:56:b0:639:bbb:f0cf with SMTP id d22-20020a056830005600b006390bbbf0cfmr640883otp.161.1661481195289; Thu, 25 Aug 2022 19:33:15 -0700 (PDT) MIME-Version: 1.0 References: <20220825063852.1120632-1-kai.heng.feng@canonical.com> <20220825104403.740cac15@kernel.org> In-Reply-To: <20220825104403.740cac15@kernel.org> From: Kai-Heng Feng Date: Fri, 26 Aug 2022 10:33:03 +0800 Message-ID: Subject: Re: [PATCH] tg3: Disable tg3 device on system reboot to avoid triggering AER To: Jakub Kicinski Cc: siva.kallam@broadcom.com, prashant@broadcom.com, mchan@broadcom.com, Josef Bacik , "David S. Miller" , Eric Dumazet , Paolo Abeni , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Aug 26, 2022 at 1:44 AM Jakub Kicinski wrote: > > On Thu, 25 Aug 2022 14:38:52 +0800 Kai-Heng Feng wrote: > > rtnl_lock(); > > + > > + tg3_reset_task_cancel(tp); > > Doesn't this "task" take rtnl_lock()? Looks deadlocky. Thanks for the review. I sent v2 to address it. Kai-Heng