From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-23.3 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_IN_DEF_DKIM_WL autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1DA0DC432BE for ; Thu, 29 Jul 2021 20:08:08 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0AFD7604D7 for ; Thu, 29 Jul 2021 20:08:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232827AbhG2UIK (ORCPT ); Thu, 29 Jul 2021 16:08:10 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59984 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232785AbhG2UIC (ORCPT ); Thu, 29 Jul 2021 16:08:02 -0400 Received: from mail-lf1-x129.google.com (mail-lf1-x129.google.com [IPv6:2a00:1450:4864:20::129]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A5D34C061765 for ; Thu, 29 Jul 2021 13:07:58 -0700 (PDT) Received: by mail-lf1-x129.google.com with SMTP id z2so13265380lft.1 for ; Thu, 29 Jul 2021 13:07:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=jTmFh8dBUxxfIA7MnCPlfr2/MF7WnSFwZKcouyPXsrI=; b=j3mDa6/bGguSlBEB/5YxoKvbffgwh8rRFdcJJYMuubkjWC7CzKoNOZD3yPNxJ5HXdP hr+DzfA66ATd4M7E2M+M9zIPjJABeU+0Z61nfoY9yQ7zilP+BKfpzFqjtu00y0DbImoJ FTcarWb2JwjnWDYZCTMQ30Lw2y2/cEPmgU5RxAZDbsvJT9r52Z8AErywhCQ5AHiYBGnj LQrDuL/pl8MB2hzSyUiTTaSfvn+bLP1LwIqLrY+bKAdNRfLwWBAQXSPX5vOgARcuEjHW 8gM3Rf16RdRVskU9QL4fMLoKQ1RhQ6RpT/7d83kUJ4+MU9JieNSqBmgPZyqNihnU1eaq XeCA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=jTmFh8dBUxxfIA7MnCPlfr2/MF7WnSFwZKcouyPXsrI=; b=tqpcPYVc3GLLx252LsbVcRU9zs8XME9/lGZuKKY3crMnw/vmdr0zV/D5xd1YfLh7YO od5ErYpNQXGwuEW5zGe5Na/vR7UI4E0q35xkrehg4B9jeLGLcGNs5xBvg+AIXSBlmoC8 OTlM8J36qE0QzLKNOpXoS4+lWAHor8tgQNAo6ctmIeH0UUNgR8euH5SCbpxMssfANl05 uFL32J/fVVcVSptASBOR/0ZXVaZMkp1J7qk1+P7Me89pACsxINMN9PK9eYk0KYZeDgWr MS7X8S1JX9CWqqRQJQumrbzG6I5WrC3OGNOAGGJWoqN5ps9P8dnyzx7irBsMvdO6PVp+ 2Idw== X-Gm-Message-State: AOAM530TgA3Py7rGFR78szLz6DvbCBZhrUbkDtah4htolfr5tjmUJmN7 fd8Dabl7I70dHaTSMqTiYeMMIJv3gMuy6WjGL0jKGg== X-Google-Smtp-Source: ABdhPJyCK1cfhDjBCUWkIafk33w1RKfYfFOKKupy9ZzcP8PGybq89vd6BezAvcQkfzUv0BhjixrwfA9GUnzLCWOGh0E= X-Received: by 2002:a19:6b14:: with SMTP id d20mr5099285lfa.359.1627589276715; Thu, 29 Jul 2021 13:07:56 -0700 (PDT) MIME-Version: 1.0 References: <20210729195632.489978-1-oupton@google.com> <20210729195632.489978-2-oupton@google.com> In-Reply-To: <20210729195632.489978-2-oupton@google.com> From: Jing Zhang Date: Thu, 29 Jul 2021 13:07:45 -0700 Message-ID: Subject: Re: [PATCH 1/3] KVM: arm64: Record number of signal exits as a vCPU stat To: Oliver Upton Cc: KVM ARM , KVM , linux-kernel@vger.kernel.org, Paolo Bonzini , Marc Zyngier , James Morse , Alexandru Elisei , Suzuki K Poulose , Catalin Marinas , Will Deacon , Thomas Gleixner , Peter Zijlstra , Andy Lutomirski , linux-arm-kernel@lists.infradead.org, Peter Shier , Shakeel Butt , Guangyu Shi Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jul 29, 2021 at 12:56 PM Oliver Upton wrote: > > Most other architectures that implement KVM record a statistic > indicating the number of times a vCPU has exited due to a pending > signal. Add support for that stat to arm64. > > Cc: Jing Zhang > Signed-off-by: Oliver Upton > --- > arch/arm64/include/asm/kvm_host.h | 1 + > arch/arm64/kvm/arm.c | 1 + > arch/arm64/kvm/guest.c | 3 ++- > 3 files changed, 4 insertions(+), 1 deletion(-) > > diff --git a/arch/arm64/include/asm/kvm_host.h b/arch/arm64/include/asm/kvm_host.h > index 41911585ae0c..70e129f2b574 100644 > --- a/arch/arm64/include/asm/kvm_host.h > +++ b/arch/arm64/include/asm/kvm_host.h > @@ -576,6 +576,7 @@ struct kvm_vcpu_stat { > u64 wfi_exit_stat; > u64 mmio_exit_user; > u64 mmio_exit_kernel; > + u64 signal_exits; > u64 exits; > }; > > diff --git a/arch/arm64/kvm/arm.c b/arch/arm64/kvm/arm.c > index e9a2b8f27792..60d0a546d7fd 100644 > --- a/arch/arm64/kvm/arm.c > +++ b/arch/arm64/kvm/arm.c > @@ -783,6 +783,7 @@ int kvm_arch_vcpu_ioctl_run(struct kvm_vcpu *vcpu) > if (signal_pending(current)) { > ret = -EINTR; > run->exit_reason = KVM_EXIT_INTR; > + ++vcpu->stat.signal_exits; > } > > /* > diff --git a/arch/arm64/kvm/guest.c b/arch/arm64/kvm/guest.c > index 1dfb83578277..50fc16ad872f 100644 > --- a/arch/arm64/kvm/guest.c > +++ b/arch/arm64/kvm/guest.c > @@ -50,7 +50,8 @@ const struct _kvm_stats_desc kvm_vcpu_stats_desc[] = { > STATS_DESC_COUNTER(VCPU, wfi_exit_stat), > STATS_DESC_COUNTER(VCPU, mmio_exit_user), > STATS_DESC_COUNTER(VCPU, mmio_exit_kernel), > - STATS_DESC_COUNTER(VCPU, exits) > + STATS_DESC_COUNTER(VCPU, exits), > + STATS_DESC_COUNTER(VCPU, signal_exits), How about put signal_exits before exits as the same order in kvm_vcpu_stat just for readability? > }; > static_assert(ARRAY_SIZE(kvm_vcpu_stats_desc) == > sizeof(struct kvm_vcpu_stat) / sizeof(u64)); > -- > 2.32.0.554.ge1b32706d8-goog > Reviewed-by: Jing Zhang Thanks, Jing