From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-23.3 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_IN_DEF_DKIM_WL autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6BFF1C11F67 for ; Thu, 1 Jul 2021 21:26:20 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 4990D6140D for ; Thu, 1 Jul 2021 21:26:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234294AbhGAV1g (ORCPT ); Thu, 1 Jul 2021 17:27:36 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41494 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233080AbhGAV1e (ORCPT ); Thu, 1 Jul 2021 17:27:34 -0400 Received: from mail-lj1-x22b.google.com (mail-lj1-x22b.google.com [IPv6:2a00:1450:4864:20::22b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9806DC061764 for ; Thu, 1 Jul 2021 14:25:03 -0700 (PDT) Received: by mail-lj1-x22b.google.com with SMTP id a6so10450129ljq.3 for ; Thu, 01 Jul 2021 14:25:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=uPZE1BnafEGGofshB/oCVcT1sDDIq1gVM120dwnS8WQ=; b=qrtMwvxzuwsefQ6MJGziiD+Zj5B/8NlZ9l3QFDoj3ttI3TNctdjKL/H768lEDo7/Bn /3S6E3Ik34hDvHag9Jvgh6/jZKUdvSGeWVOwzEO+uXMzcleV2c34BBqNO1360HuEtzdb i9u7JnTIujV13k5YXPB9Rv/7PvdXAHIKNAinJt+jZzAaGMWh/sckm2pLHbJqGrj29NSY eJQmEiA4i+ipiUKAquwa8mEeOEy20UojSuA9pXleAP0XbvWIqE/i7bnFzHX/nhA0zng3 h4Ii8qO6AMa5okkG2Iq01cFfhHGIfwgw+mkVDuwm8QQWYRyn4vUeH30TybayS3uX9JBQ qcvQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=uPZE1BnafEGGofshB/oCVcT1sDDIq1gVM120dwnS8WQ=; b=e9ipCtTA2A+PYwZfqLbCA1Io2Hmt2yHFgTiKtClskwiWG53QT/pvRFMhjz+N8CzAG+ 3D7nK9u/6tE7qDl7+4lLKctZ6zUyLealArjPcpNXlGqZqu9lxdmBgKeMtNBDxkrkfhXj eA6cyHMaD6ph9KgpllikxZt5hIIQxxpJqTuUm0AdnD/mAvgRWLgbmzrdMVYe7G2ApiRP HjKOy5U0jSKCIrsD3zulmu0YxAza3rTxFdsyPhIrkmDCtSdvBd7UdxOwB0hjh75AW00n 6tF3/HwhNVeOTy7oWCfsl2N4QYsT5kfPVOYx/NAVwpuKvA3qfd5bW1KKgUxF6IrkgsGo LIrQ== X-Gm-Message-State: AOAM532m8B9UG/aYJBi+rR9cWbyXmnjA7IzuxkCr891BQ1Lu/UChONDy NbrClQCFa8MmkNj2cCjD6s1SUXGgyu3G/H2d2tpN/w== X-Google-Smtp-Source: ABdhPJyczRahnz2Bvg+RDafJ0A1MHyUUYYJlaOn5sOi6JrcXxe2uH2eeAHM3Uf0K6fIBEA9Mczbi05sPz2qTgefQYUU= X-Received: by 2002:a2e:9853:: with SMTP id e19mr1224260ljj.256.1625174701631; Thu, 01 Jul 2021 14:25:01 -0700 (PDT) MIME-Version: 1.0 References: <20210701195500.27097-1-paskripkin@gmail.com> In-Reply-To: <20210701195500.27097-1-paskripkin@gmail.com> From: Jing Zhang Date: Thu, 1 Jul 2021 16:24:50 -0500 Message-ID: Subject: Re: [PATCH next] kvm: debugfs: fix memory leak in kvm_create_vm_debugfs To: Pavel Skripkin Cc: Paolo Bonzini , KVM , linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jul 1, 2021 at 2:55 PM Pavel Skripkin wrote: > > In commit bc9e9e672df9 ("KVM: debugfs: Reuse binary stats descriptors") > loop for filling debugfs_stat_data was copy-pasted 2 times, but > in the second loop pointers are saved over pointers allocated > in the first loop. It causes memory leak. Fix it. > > Fixes: bc9e9e672df9 ("KVM: debugfs: Reuse binary stats descriptors") > Signed-off-by: Pavel Skripkin > --- > virt/kvm/kvm_main.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/virt/kvm/kvm_main.c b/virt/kvm/kvm_main.c > index 7d95126cda9e..986959833d70 100644 > --- a/virt/kvm/kvm_main.c > +++ b/virt/kvm/kvm_main.c > @@ -935,7 +935,7 @@ static int kvm_create_vm_debugfs(struct kvm *kvm, int fd) > stat_data->kvm = kvm; > stat_data->desc = pdesc; > stat_data->kind = KVM_STAT_VCPU; > - kvm->debugfs_stat_data[i] = stat_data; > + kvm->debugfs_stat_data[i + kvm_vm_stats_header.num_desc] = stat_data; Pavel, thanks for fixing this. Reviewed-by: Jing Zhang > debugfs_create_file(pdesc->name, kvm_stats_debugfs_mode(pdesc), > kvm->debugfs_dentry, stat_data, > &stat_fops_per_vm); > -- > 2.32.0 >