From: "Philippe Mathieu-Daudé" <f4bug@amsat.org>
To: "Jason A. Donenfeld" <Jason@zx2c4.com>
Cc: Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
"open list:BROADCOM NVRAM DRIVER" <linux-mips@vger.kernel.org>,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] mips: allow firmware to pass RNG seed to kernel
Date: Tue, 4 Oct 2022 00:07:08 +0200 [thread overview]
Message-ID: <CAAdtpL5BQA-y-N0Bc--KbfT9WXok0kNQ17YuF1Yyjg13DHLtgQ@mail.gmail.com> (raw)
In-Reply-To: <20220930140138.575751-1-Jason@zx2c4.com>
Hi Jason,
On Fri, Sep 30, 2022 at 4:05 PM Jason A. Donenfeld <Jason@zx2c4.com> wrote:
>
> Nearly all other firmware environments have some way of passing a RNG
> seed to initialize the RNG: DTB's rng-seed, EFI's RNG protocol, m68k's
> bootinfo block, x86's setup_data, and so forth. This adds something
> similar for MIPS, which will allow various firmware environments,
> bootloaders, and hypervisors to pass an RNG seed to initialize the
> kernel's RNG.
>
> Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com>
> ---
> arch/mips/kernel/setup.c | 21 +++++++++++++++++++++
> 1 file changed, 21 insertions(+)
>
> diff --git a/arch/mips/kernel/setup.c b/arch/mips/kernel/setup.c
> index 2ca156a5b231..39c79f67c7a3 100644
> --- a/arch/mips/kernel/setup.c
> +++ b/arch/mips/kernel/setup.c
> @@ -42,6 +42,7 @@
> #include <asm/setup.h>
> #include <asm/smp-ops.h>
> #include <asm/prom.h>
> +#include <asm/fw/fw.h>
>
> #ifdef CONFIG_MIPS_ELF_APPENDED_DTB
> char __section(".appended_dtb") __appended_dtb[0x100000];
> @@ -756,6 +757,24 @@ static void __init prefill_possible_map(void)
> static inline void prefill_possible_map(void) {}
> #endif
>
> +static void __init setup_rng_seed(void)
> +{
> + char *rng_seed_hex = fw_getenv("rngseed");
> + u8 rng_seed[512];
> + size_t len;
> +
> + if (!rng_seed_hex)
> + return;
> +
Assuming rngseed="x", ...
> + len = min(sizeof(rng_seed), strlen(rng_seed_hex) / 2);
... len = 0 ...
> + if (hex2bin(rng_seed, rng_seed_hex, len))
> + return;
hex2bin(..., len=0) = 0
> +
> + add_bootloader_randomness(rng_seed, len);
So we call char/random code with len=0. Is it safe?
Maybe simply safer to check len before calling hex2bin?
> + memzero_explicit(rng_seed, len);
> + memzero_explicit(rng_seed_hex, len * 2);
> +}
> +
> void __init setup_arch(char **cmdline_p)
> {
> cpu_probe();
> @@ -786,6 +805,8 @@ void __init setup_arch(char **cmdline_p)
> paging_init();
>
> memblock_dump_all();
> +
> + setup_rng_seed();
> }
>
> unsigned long kernelsp[NR_CPUS];
> --
> 2.37.3
>
next prev parent reply other threads:[~2022-10-03 22:07 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-30 14:01 [PATCH] mips: allow firmware to pass RNG seed to kernel Jason A. Donenfeld
2022-10-01 16:09 ` Thomas Bogendoerfer
2022-10-03 22:07 ` Philippe Mathieu-Daudé [this message]
2022-10-03 22:30 ` Jason A. Donenfeld
2022-10-06 11:28 ` Philippe Mathieu-Daudé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAAdtpL5BQA-y-N0Bc--KbfT9WXok0kNQ17YuF1Yyjg13DHLtgQ@mail.gmail.com \
--to=f4bug@amsat.org \
--cc=Jason@zx2c4.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=tsbogend@alpha.franken.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).