linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Philippe Mathieu-Daudé" <f4bug@amsat.org>
To: Florian Fainelli <f.fainelli@gmail.com>
Cc: "Álvaro Fernández Rojas" <noltari@gmail.com>,
	"Michael Turquette" <mturquette@baylibre.com>,
	"Stephen Boyd" <sboyd@kernel.org>,
	"Rob Herring" <robh+dt@kernel.org>,
	bcm-kernel-feedback-list <bcm-kernel-feedback-list@broadcom.com>,
	"Julia Lawall" <julia.lawall@lip6.fr>,
	"Jonas Gorski" <jonas.gorski@gmail.com>,
	"kbuild test robot" <lkp@intel.com>,
	linux-clk <linux-clk@vger.kernel.org>,
	"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
	<devicetree@vger.kernel.org>,
	"Linux ARM" <linux-arm-kernel@lists.infradead.org>,
	"open list" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2/2] clk: bcm63xx-gate: add BCM6318 support
Date: Sat, 13 Jun 2020 19:53:07 +0200	[thread overview]
Message-ID: <CAAdtpL6OXziD9Q0dBZzkcq0jPF04rmNd6o_hi7Frm5DejG29mA@mail.gmail.com> (raw)
In-Reply-To: <93c429b1-31f4-95c2-1bd9-b3756b396f3a@gmail.com>

On Wed, Jun 10, 2020 at 5:32 PM Florian Fainelli <f.fainelli@gmail.com> wrote:
> On 6/10/2020 1:29 AM, Philippe Mathieu-Daudé wrote:
> > Hi,
> >
> > On Wed, Jun 10, 2020 at 8:13 AM Álvaro Fernández Rojas
> > <noltari@gmail.com> wrote:
> >>
> >> Hi Florian,
> >>
> >>> El 10 jun 2020, a las 4:27, Florian Fainelli <f.fainelli@gmail.com> escribió:
> >>>
> >>>
> >>>
> >>> On 6/9/2020 4:30 AM, Álvaro Fernández Rojas wrote:
> >>>> +static const struct clk_bcm63xx_table_entry bcm6318_clocks[] = {
> >>>> +    { .name = "adsl_asb", .bit = 0, },
> >>>> +    { .name = "usb_asb", .bit = 1, },
> >>>> +    { .name = "mips_asb", .bit = 2, },
> >>>> +    { .name = "pcie_asb", .bit = 3, },
> >>>> +    { .name = "phymips_asb", .bit = 4, },
> >>>> +    { .name = "robosw_asb", .bit = 5, },
> >>>> +    { .name = "sar_asb", .bit = 6, },
> >>>> +    { .name = "sdr_asb", .bit = 7, },
> >>>> +    { .name = "swreg_asb", .bit = 8, },
> >>>> +    { .name = "periph_asb", .bit = 9, },
> >>>> +    { .name = "cpubus160", .bit = 10, },
> >>>> +    { .name = "adsl", .bit = 11, },
> >>>> +    { .name = "sar124", .bit = 12, },
> >>>
> >>> Nit: this should be sar125
> >>
> >> Nice catch, I will fix this in v2.
> >>
> >>>
> >>>> +    { .name = "mips", .bit = 13, .flags = CLK_IS_CRITICAL, },
> >>>> +    { .name = "pcie", .bit = 14, },
> >>>> +    { .name = "robosw250", .bit = 16, },
> >>>> +    { .name = "robosw025", .bit = 17, },
> >>>> +    { .name = "sdr", .bit = 19, .flags = CLK_IS_CRITICAL, },
> >>>> +    { .name = "usb", .bit = 20, },
> >>>
> >>> This should probably be "usbd" to indicate this is the USB device clock
> >>> (not host)
> >>
> >> Ok, I will change it. I got confused by the fact that both (usbd and usbh) were present on 6318_map_part.h:
> >> #define USBD_CLK_EN         (1 << 20)
> >> #define USBH_CLK_EN         (1 << 20)
> >
> > Is there a datasheet to verify that?
>
> Not a public one, but I can confirm this is correct given the internal
> datasheet.

OK thank you Florian.

> --
> Florian

  reply	other threads:[~2020-06-13 17:53 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-06-09 11:30 [PATCH 0/2] clk: bcm63xx-gate: add BCM6318 support Álvaro Fernández Rojas
2020-06-09 11:30 ` [PATCH 1/2] dt-bindings: clock: bcm63xx: add 6318 gated clock bindings Álvaro Fernández Rojas
2020-06-10  2:23   ` Florian Fainelli
2020-06-09 11:30 ` [PATCH 2/2] clk: bcm63xx-gate: add BCM6318 support Álvaro Fernández Rojas
2020-06-10  2:27   ` Florian Fainelli
2020-06-10  6:12     ` Álvaro Fernández Rojas
2020-06-10  8:29       ` Philippe Mathieu-Daudé
2020-06-10 15:14         ` Florian Fainelli
2020-06-13 17:53           ` Philippe Mathieu-Daudé [this message]
2020-06-10 14:08 ` [PATCH v2 0/2] " Álvaro Fernández Rojas
2020-06-10 14:08   ` [PATCH v2 1/2] dt-bindings: clock: bcm63xx: add 6318 gated clock bindings Álvaro Fernández Rojas
2020-06-17 22:23     ` Rob Herring
2020-06-10 14:08   ` [PATCH v2 2/2] clk: bcm63xx-gate: add BCM6318 support Álvaro Fernández Rojas
2020-06-20  0:00   ` [PATCH v2 0/2] " Stephen Boyd

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAAdtpL6OXziD9Q0dBZzkcq0jPF04rmNd6o_hi7Frm5DejG29mA@mail.gmail.com \
    --to=f4bug@amsat.org \
    --cc=bcm-kernel-feedback-list@broadcom.com \
    --cc=devicetree@vger.kernel.org \
    --cc=f.fainelli@gmail.com \
    --cc=jonas.gorski@gmail.com \
    --cc=julia.lawall@lip6.fr \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-clk@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lkp@intel.com \
    --cc=mturquette@baylibre.com \
    --cc=noltari@gmail.com \
    --cc=robh+dt@kernel.org \
    --cc=sboyd@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).