From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.6 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SPF_PASS,URIBL_BLOCKED, USER_IN_DEF_DKIM_WL autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7E8EBC169C4 for ; Fri, 8 Feb 2019 17:40:37 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 470E52146E for ; Fri, 8 Feb 2019 17:40:37 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="fT9JNspF" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727623AbfBHRkf (ORCPT ); Fri, 8 Feb 2019 12:40:35 -0500 Received: from mail-pg1-f195.google.com ([209.85.215.195]:39885 "EHLO mail-pg1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726869AbfBHRke (ORCPT ); Fri, 8 Feb 2019 12:40:34 -0500 Received: by mail-pg1-f195.google.com with SMTP id r11so1874533pgp.6 for ; Fri, 08 Feb 2019 09:40:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=Go1VRvx/8L0QU1rl0vOOYSWKTtgB0UTzUDeaSFlHE/U=; b=fT9JNspFdYqEr4bCaMIUIrtSDQIzlMNulJrhxo0r4NEHCbBHju9o76Uu2IvCDKZt+p gIzXDsyRVl1/QlbACnOssBnuB7b+sASRwkav4196DBlELMZ+GrioA/NCPaxnvbUFZuk8 cU27aRYeyEDjqZXIBSj8fNLCZlGMzoUfz0hFbfWsqrV/Gr52Bkg4bD779RDYjN7E2Tt+ 2sUKzMS3OR4hKf81JJGiGlFlYRbkw9q38Jmuig22thBwndgXItQ9FVUxPXLzSwsuJVRA iHR9izIab78Y6JDuiYCeVBOYHULdukt7pTj7Pm+JDUvvqmZ9g8Ve09ezhksKoJRn53D9 1isg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=Go1VRvx/8L0QU1rl0vOOYSWKTtgB0UTzUDeaSFlHE/U=; b=BrYn4I1NBPfIR2AazFRPXpZf4muZsfU9wvTJPQWB1L1tPlQpwyFVaceDQfYRv3VoiE ivbAzlZ/BkqdJ//zhDw3Ga2BC2kIe01WQi9tvsrnxQplwrYwBIejdToX0r9T4kfGyz0q 79HFdmdESiem/50ty5nw8Pc8HP2EbvKX5JnS+0AdJhfAjWRmyQRkWKBUqyiV354yCcoz 7mQY4lKYAld/52YwvoRyphoQnrGKafcFMMgocDDCix6ZuUt2YMTSoNZVlD92heNEEH/p NUwKbgkolZkMSUahkZuu/HagskC/SC6N1pSRtvBuEKtjP5ju8UpIua8cXodnQ1dEi7wO wT5g== X-Gm-Message-State: AHQUAua6VtXCuF1L5LcLBmcTHxinNLaKc7pnqTxUjny19rHzRDD4voGK SjBFwuRiW39MwBIOCuGHYkikZTvzRCTjzMT6XeZAVw== X-Google-Smtp-Source: AHgI3IZJKdSSj7Vgo9NmfLXYnXi4fnyw/ajbO6S4cAcNvP4TePiNubBDJ4qJC+2i/sxVck4KUp6amBNYeaseuNWQpfM= X-Received: by 2002:a63:7044:: with SMTP id a4mr21178893pgn.359.1549647633096; Fri, 08 Feb 2019 09:40:33 -0800 (PST) MIME-Version: 1.0 References: <1f5629e03181d0e30efc603f00dad78912991a45.1548166824.git.christophe.leroy@c-s.fr> <87ef8i45km.fsf@dja-thinkpad.axtens.net> <69720148-fd19-0810-5a1d-96c45e2ec00c@c-s.fr> In-Reply-To: <69720148-fd19-0810-5a1d-96c45e2ec00c@c-s.fr> From: Andrey Konovalov Date: Fri, 8 Feb 2019 18:40:21 +0100 Message-ID: Subject: Re: [PATCH v4 3/3] powerpc/32: Add KASAN support To: Christophe Leroy Cc: Daniel Axtens , Benjamin Herrenschmidt , Paul Mackerras , Michael Ellerman , Nicholas Piggin , "Aneesh Kumar K.V" , Andrey Ryabinin , Alexander Potapenko , Dmitry Vyukov , Linux Memory Management List , PowerPC , LKML , kasan-dev Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Feb 8, 2019 at 6:17 PM Christophe Leroy w= rote: > > Hi Daniel, > > Le 08/02/2019 =C3=A0 17:18, Daniel Axtens a =C3=A9crit : > > Hi Christophe, > > > > I've been attempting to port this to 64-bit Book3e nohash (e6500), > > although I think I've ended up with an approach more similar to Aneesh'= s > > much earlier (2015) series for book3s. > > > > Part of this is just due to the changes between 32 and 64 bits - we nee= d > > to hack around the discontiguous mappings - but one thing that I'm > > particularly puzzled by is what the kasan_early_init is supposed to do. > > It should be a problem as my patch uses a 'for_each_memblock(memory, > reg)' loop. > > > > >> +void __init kasan_early_init(void) > >> +{ > >> + unsigned long addr =3D KASAN_SHADOW_START; > >> + unsigned long end =3D KASAN_SHADOW_END; > >> + unsigned long next; > >> + pmd_t *pmd =3D pmd_offset(pud_offset(pgd_offset_k(addr), addr), a= ddr); > >> + int i; > >> + phys_addr_t pa =3D __pa(kasan_early_shadow_page); > >> + > >> + BUILD_BUG_ON(KASAN_SHADOW_START & ~PGDIR_MASK); > >> + > >> + if (early_mmu_has_feature(MMU_FTR_HPTE_TABLE)) > >> + panic("KASAN not supported with Hash MMU\n"); > >> + > >> + for (i =3D 0; i < PTRS_PER_PTE; i++) > >> + __set_pte_at(&init_mm, (unsigned long)kasan_early_shadow_= page, > >> + kasan_early_shadow_pte + i, > >> + pfn_pte(PHYS_PFN(pa), PAGE_KERNEL_RO), 0); > >> + > >> + do { > >> + next =3D pgd_addr_end(addr, end); > >> + pmd_populate_kernel(&init_mm, pmd, kasan_early_shadow_pte= ); > >> + } while (pmd++, addr =3D next, addr !=3D end); > >> +} > > > > As far as I can tell it's mapping the early shadow page, read-only, ove= r > > the KASAN_SHADOW_START->KASAN_SHADOW_END range, and it's using the earl= y > > shadow PTE array from the generic code. > > > > I haven't been able to find an answer to why this is in the docs, so I > > was wondering if you or anyone else could explain the early part of > > kasan init a bit better. > > See https://www.kernel.org/doc/html/latest/dev-tools/kasan.html for an > explanation of the shadow. > > When shadow is 0, it means the memory area is entirely accessible. > > It is necessary to setup a shadow area as soon as possible because all > data accesses check the shadow area, from the begining (except for a few > files where sanitizing has been disabled in Makefiles). > > Until the real shadow area is set, all access are granted thanks to the > zero shadow area beeing for of zeros. Not entirely correct. kasan_early_init() indeed maps the whole shadow memory range to the same kasan_early_shadow_page. However as kernel loads and memory gets allocated this shadow page gets rewritten with non-zero values by different KASAN allocator hooks. Since these values come from completely different parts of the kernel, but all land on the same page, kasan_early_shadow_page's content can be considered garbage. When KASAN checks memory accesses for validity it detects these garbage shadow values, but doesn't print any reports, as the reporting routine bails out on the current->kasan_depth check (which has the value of 1 initially). Only after kasan_init() completes, when the proper shadow memory is mapped, current->kasan_depth gets set to 0 and we start reporting bad accesses. > > I mainly used ARM arch as an exemple when I implemented KASAN for ppc32. > > > > > At the moment, I don't do any early init, and like Aneesh's series for > > book3s, I end up needing a special flag to disable kasan until after > > kasan_init. Also, as with Balbir's seris for Radix, some tests didn't > > fire, although my missing tests are a superset of his. I suspect the > > early init has something to do with these...? > > I think you should really focus on establishing a zero shadow area as > early as possible instead of trying to ack the core parts of KASAN. > > > > > (I'm happy to collate answers into a patch to the docs, btw!) > > We can also have the discussion going via > https://github.com/linuxppc/issues/issues/106 > > > > > In the long term I hope to revive Aneesh's and Balbir's series for hash > > and radix as well. > > Great. > > Christophe > > > > > Regards, > > Daniel > > > >> + > >> +static void __init kasan_init_region(struct memblock_region *reg) > >> +{ > >> + void *start =3D __va(reg->base); > >> + void *end =3D __va(reg->base + reg->size); > >> + unsigned long k_start, k_end, k_cur, k_next; > >> + pmd_t *pmd; > >> + > >> + if (start >=3D end) > >> + return; > >> + > >> + k_start =3D (unsigned long)kasan_mem_to_shadow(start); > >> + k_end =3D (unsigned long)kasan_mem_to_shadow(end); > >> + pmd =3D pmd_offset(pud_offset(pgd_offset_k(k_start), k_start), k_= start); > >> + > >> + for (k_cur =3D k_start; k_cur !=3D k_end; k_cur =3D k_next, pmd++= ) { > >> + k_next =3D pgd_addr_end(k_cur, k_end); > >> + if ((void *)pmd_page_vaddr(*pmd) =3D=3D kasan_early_shado= w_pte) { > >> + pte_t *new =3D pte_alloc_one_kernel(&init_mm); > >> + > >> + if (!new) > >> + panic("kasan: pte_alloc_one_kernel() fail= ed"); > >> + memcpy(new, kasan_early_shadow_pte, PTE_TABLE_SIZ= E); > >> + pmd_populate_kernel(&init_mm, pmd, new); > >> + } > >> + }; > >> + > >> + for (k_cur =3D k_start; k_cur < k_end; k_cur +=3D PAGE_SIZE) { > >> + void *va =3D memblock_alloc(PAGE_SIZE, PAGE_SIZE); > >> + pte_t pte =3D pfn_pte(PHYS_PFN(__pa(va)), PAGE_KERNEL); > >> + > >> + if (!va) > >> + panic("kasan: memblock_alloc() failed"); > >> + pmd =3D pmd_offset(pud_offset(pgd_offset_k(k_cur), k_cur)= , k_cur); > >> + pte_update(pte_offset_kernel(pmd, k_cur), ~0, pte_val(pte= )); > >> + } > >> + flush_tlb_kernel_range(k_start, k_end); > >> +} > >> + > >> +void __init kasan_init(void) > >> +{ > >> + struct memblock_region *reg; > >> + > >> + for_each_memblock(memory, reg) > >> + kasan_init_region(reg); > >> + > >> + kasan_init_tags(); > >> + > >> + /* At this point kasan is fully initialized. Enable error message= s */ > >> + init_task.kasan_depth =3D 0; > >> + pr_info("KASAN init done\n"); > >> +} > >> diff --git a/arch/powerpc/mm/mem.c b/arch/powerpc/mm/mem.c > >> index 33cc6f676fa6..ae7db88b72d6 100644 > >> --- a/arch/powerpc/mm/mem.c > >> +++ b/arch/powerpc/mm/mem.c > >> @@ -369,6 +369,10 @@ void __init mem_init(void) > >> pr_info(" * 0x%08lx..0x%08lx : highmem PTEs\n", > >> PKMAP_BASE, PKMAP_ADDR(LAST_PKMAP)); > >> #endif /* CONFIG_HIGHMEM */ > >> +#ifdef CONFIG_KASAN > >> + pr_info(" * 0x%08lx..0x%08lx : kasan shadow mem\n", > >> + KASAN_SHADOW_START, KASAN_SHADOW_END); > >> +#endif > >> #ifdef CONFIG_NOT_COHERENT_CACHE > >> pr_info(" * 0x%08lx..0x%08lx : consistent mem\n", > >> IOREMAP_TOP, IOREMAP_TOP + CONFIG_CONSISTENT_SIZE); > >> -- > >> 2.13.3 > > -- > You received this message because you are subscribed to the Google Groups= "kasan-dev" group. > To unsubscribe from this group and stop receiving emails from it, send an= email to kasan-dev+unsubscribe@googlegroups.com. > To post to this group, send email to kasan-dev@googlegroups.com. > To view this discussion on the web visit https://groups.google.com/d/msgi= d/kasan-dev/69720148-fd19-0810-5a1d-96c45e2ec00c%40c-s.fr. > For more options, visit https://groups.google.com/d/optout.