From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.4 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_IN_DEF_DKIM_WL autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 15CD6C10DCE for ; Tue, 24 Mar 2020 23:03:10 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id D918520722 for ; Tue, 24 Mar 2020 23:03:09 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="szxby5Dm" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727522AbgCXXDI (ORCPT ); Tue, 24 Mar 2020 19:03:08 -0400 Received: from mail-pj1-f65.google.com ([209.85.216.65]:34682 "EHLO mail-pj1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727338AbgCXXDI (ORCPT ); Tue, 24 Mar 2020 19:03:08 -0400 Received: by mail-pj1-f65.google.com with SMTP id q16so1661355pje.1 for ; Tue, 24 Mar 2020 16:03:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=caaFIIIt12v7NnlB+JkGTlJxk5XtTgNBQOzAZR3YtSU=; b=szxby5DmXpqS2cBekkiZsvcCmCXeaAF3Vt1Ci/bIc8LIL3LmWxxBGDEEyNG7SvgW9k b07YoAQSbl4hm+NGBDXyN+MHCBfJ8g8fsNpXho4mc1TsLIgRfqz64Lv0/TvTLmcxMG9w 4jsjIVjBO3PA77m+5p7mmfZdruFbAhjgrIa6nrqkFzq/CZpoTDibQ35VBuKyRroZrEmI 64qWtvuYxFUtIfCe5W6rS7vPIRBYcQcUIueAA8CIjoqtx72gzFrrPewOYHFkALw5yD68 HNCQ862wFqKn5e47N9uZ6LMJBe7Rqvim4M6KqfBkdkRA9vHcKzVhya7D6mFZV2p4x0qB oDog== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=caaFIIIt12v7NnlB+JkGTlJxk5XtTgNBQOzAZR3YtSU=; b=B5x0zv6x61G5Ph9877FTnDazi1YvlL4H6wx7suDULvPwKDPSYs3qDc69s557vHFHJA sc42ckdQMgmNzEdfRQOXNkcwhtFe147ihqUEf7RuTuwaVtGui2rDPwUrD8GmGK//hu3K h2ASJIlmBUjVOhNfw3x6SvGtjAsTE4/Zy2r8fCPhKIRz/CJHtEYgvhSswZ4cDTBOaq4i v+/chC98x4DaQxrAg8dgmbU9xh5bVyls5tV04SDvpPA/M8kvJqd61LMIG7Xu9tmSIBpH fW2JEsTl40A4AZ0IeGdaCRAs9eTqwJUvtYC9+SC2sD7l+muTk9bz5ovvSCNizvuJ/1rU 5HFg== X-Gm-Message-State: ANhLgQ0cEnTD1tITwkopFg9DVGq0TzQjnFO3sv7w2y/lNXagjuZTYZUX m8Up8+2OpN0gecN9NE9v6JePkzJZqB7aec/J4aq8eg== X-Google-Smtp-Source: ADFU+vsfQx6nUivjTgQwIwIh+hXPldHTU+juUFoemo8hpe3IRczTIEA4HW8lw9yLuIXUwcQ0Rj6/koQcrCN9PdBvHM0= X-Received: by 2002:a17:90a:5218:: with SMTP id v24mr282003pjh.90.1585090987319; Tue, 24 Mar 2020 16:03:07 -0700 (PDT) MIME-Version: 1.0 References: <20200320201539.3a3a8640@canb.auug.org.au> <20200324164709.ux4riz7v7uy32nlj@treble> <39035493-9d5b-9da3-10d4-0af5d1cdb32a@infradead.org> <20200324211303.GQ2452@worktop.programming.kicks-ass.net> In-Reply-To: <20200324211303.GQ2452@worktop.programming.kicks-ass.net> From: Andrey Konovalov Date: Wed, 25 Mar 2020 00:02:55 +0100 Message-ID: Subject: Re: linux-next: Tree for Mar 20 (objtool warnings) To: Peter Zijlstra Cc: Randy Dunlap , Josh Poimboeuf , Stephen Rothwell , Linux Next Mailing List , Linux Kernel Mailing List , Andrey Ryabinin , Greg Kroah-Hartman Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Mar 24, 2020 at 10:13 PM Peter Zijlstra wrote: > > On Tue, Mar 24, 2020 at 10:53:05AM -0700, Randy Dunlap wrote: > > >> kernel/kcov.o: warning: objtool: __sanitizer_cov_trace_pc()+0x89: call to __ubsan_handle_load_invalid_value() with UACCESS enabled > > >> > > > > config-r1510 is attached. > > and kcov.o is attached. > > I'm thinking this is because of commit: > > 0d6958a70483 kcov: collect coverage from interrupts > > Which has: > > @@ -1230,6 +1230,9 @@ struct task_struct { > > + bool kcov_softirq; > > @@ -145,9 +157,10 @@ static notrace bool check_kcov_mode(enum kcov_mode needed_mode, struct task_stru > > + if (!in_task() && !(in_serving_softirq() && t->kcov_softirq)) > > And this __ubsan_handle_load_invalid_value() is verifying a bool is 0,1. > > Another reason to hate on _Bool I suppose... > > Let me see what to do about that... :/ Hm, let's turn it into an unsigned int if bool causes a problem? I can send a patch.