From: Andrey Konovalov <andreyknvl@google.com>
To: Vincenzo Frascino <vincenzo.frascino@arm.com>
Cc: Linux ARM <linux-arm-kernel@lists.infradead.org>,
LKML <linux-kernel@vger.kernel.org>,
kasan-dev <kasan-dev@googlegroups.com>,
Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will@kernel.org>, Dmitry Vyukov <dvyukov@google.com>,
Andrey Ryabinin <aryabinin@virtuozzo.com>,
Alexander Potapenko <glider@google.com>,
Marco Elver <elver@google.com>,
Evgenii Stepanov <eugenis@google.com>,
Branislav Rankov <Branislav.Rankov@arm.com>
Subject: Re: [PATCH v5 5/6] arm64: mte: Expose execution mode
Date: Thu, 21 Jan 2021 18:41:07 +0100 [thread overview]
Message-ID: <CAAeHK+y9Je7nwRAJ+t5Yw0d3Bmrrn-mhqdw4uqLMSdHaRjZm1A@mail.gmail.com> (raw)
In-Reply-To: <20210121163943.9889-6-vincenzo.frascino@arm.com>
On Thu, Jan 21, 2021 at 5:40 PM Vincenzo Frascino
<vincenzo.frascino@arm.com> wrote:
>
> MTE enabled arm64 HW can be configured in synchronous or asynchronous
> tagging mode of execution.
> In synchronous mode, an exception is triggered if a tag check fault
> occurs.
> In asynchronous mode, if a tag check fault occurs, the TFSR_EL1 register
> is updated asynchronously. The kernel checks the corresponding bits
> periodically.
>
> Introduce an API that exposes the mode of execution to the kernel.
>
> Note: This API will be used by KASAN KUNIT tests to forbid the execution
> when async mode is enable.
>
> Cc: Catalin Marinas <catalin.marinas@arm.com>
> Cc: Will Deacon <will@kernel.org>
> Signed-off-by: Vincenzo Frascino <vincenzo.frascino@arm.com>
> ---
> arch/arm64/include/asm/memory.h | 1 +
> arch/arm64/include/asm/mte-kasan.h | 6 ++++++
> arch/arm64/kernel/mte.c | 8 ++++++++
> 3 files changed, 15 insertions(+)
>
> diff --git a/arch/arm64/include/asm/memory.h b/arch/arm64/include/asm/memory.h
> index df96b9c10b81..1d4eef519fa6 100644
> --- a/arch/arm64/include/asm/memory.h
> +++ b/arch/arm64/include/asm/memory.h
> @@ -233,6 +233,7 @@ static inline const void *__tag_set(const void *addr, u8 tag)
> #ifdef CONFIG_KASAN_HW_TAGS
> #define arch_enable_tagging_sync() mte_enable_kernel_sync()
> #define arch_enable_tagging_async() mte_enable_kernel_async()
> +#define arch_is_mode_sync() mte_is_mode_sync()
> #define arch_set_tagging_report_once(state) mte_set_report_once(state)
> #define arch_init_tags(max_tag) mte_init_tags(max_tag)
> #define arch_get_random_tag() mte_get_random_tag()
> diff --git a/arch/arm64/include/asm/mte-kasan.h b/arch/arm64/include/asm/mte-kasan.h
> index 76b6a5988ce5..c216160e805c 100644
> --- a/arch/arm64/include/asm/mte-kasan.h
> +++ b/arch/arm64/include/asm/mte-kasan.h
> @@ -31,6 +31,7 @@ void *mte_set_mem_tag_range(void *addr, size_t size, u8 tag);
>
> void mte_enable_kernel_sync(void);
> void mte_enable_kernel_async(void);
> +bool mte_is_mode_sync(void);
> void mte_init_tags(u64 max_tag);
>
> void mte_set_report_once(bool state);
> @@ -64,6 +65,11 @@ static inline void mte_enable_kernel_sync(void)
> {
> }
>
> +static inline bool mte_is_mode_sync(void)
> +{
> + return false;
> +}
> +
> static inline void mte_init_tags(u64 max_tag)
> {
> }
> diff --git a/arch/arm64/kernel/mte.c b/arch/arm64/kernel/mte.c
> index 7763ac1f2917..1cc3fc173b97 100644
> --- a/arch/arm64/kernel/mte.c
> +++ b/arch/arm64/kernel/mte.c
> @@ -26,6 +26,7 @@
> u64 gcr_kernel_excl __ro_after_init;
>
> static bool report_fault_once = true;
> +static bool __mte_mode_sync = true;
>
> static void mte_sync_page_tags(struct page *page, pte_t *ptep, bool check_swap)
> {
> @@ -169,9 +170,16 @@ void mte_enable_kernel_sync(void)
>
> void mte_enable_kernel_async(void)
> {
> + __mte_mode_sync = false;
> +
> __mte_enable_kernel("asynchronous", SCTLR_ELx_TCF_ASYNC);
> }
>
> +bool mte_is_mode_sync(void)
> +{
> + return __mte_mode_sync;
> +}
> +
> void mte_set_report_once(bool state)
> {
> WRITE_ONCE(report_fault_once, state);
> --
> 2.30.0
>
(See my comment on patch #6.)
next prev parent reply other threads:[~2021-01-21 17:44 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-21 16:39 [PATCH v5 0/6] arm64: ARMv8.5-A: MTE: Add async mode support Vincenzo Frascino
2021-01-21 16:39 ` [PATCH v5 1/6] arm64: mte: Add asynchronous " Vincenzo Frascino
2021-01-21 16:39 ` [PATCH v5 2/6] kasan: Add KASAN mode kernel parameter Vincenzo Frascino
2021-01-21 17:34 ` Andrey Konovalov
2021-01-22 11:25 ` Vincenzo Frascino
2021-01-21 16:39 ` [PATCH v5 3/6] kasan: Add report for async mode Vincenzo Frascino
2021-01-21 17:36 ` Andrey Konovalov
2021-01-22 2:45 ` kernel test robot
2021-01-22 2:46 ` kernel test robot
2021-01-22 13:19 ` Catalin Marinas
2021-01-22 13:27 ` Vincenzo Frascino
2021-01-22 13:38 ` Vincenzo Frascino
2021-01-21 16:39 ` [PATCH v5 4/6] arm64: mte: Enable async tag check fault Vincenzo Frascino
2021-01-21 17:38 ` Andrey Konovalov
2021-01-22 11:24 ` Vincenzo Frascino
2021-01-22 11:58 ` Catalin Marinas
2021-01-21 16:39 ` [PATCH v5 5/6] arm64: mte: Expose execution mode Vincenzo Frascino
2021-01-21 17:41 ` Andrey Konovalov [this message]
2021-01-21 16:39 ` [PATCH v5 6/6] kasan: Forbid kunit tests when async mode is enabled Vincenzo Frascino
2021-01-21 17:40 ` Andrey Konovalov
2021-01-22 11:26 ` Vincenzo Frascino
2021-01-22 12:00 ` Catalin Marinas
2021-01-22 4:04 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAAeHK+y9Je7nwRAJ+t5Yw0d3Bmrrn-mhqdw4uqLMSdHaRjZm1A@mail.gmail.com \
--to=andreyknvl@google.com \
--cc=Branislav.Rankov@arm.com \
--cc=aryabinin@virtuozzo.com \
--cc=catalin.marinas@arm.com \
--cc=dvyukov@google.com \
--cc=elver@google.com \
--cc=eugenis@google.com \
--cc=glider@google.com \
--cc=kasan-dev@googlegroups.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=vincenzo.frascino@arm.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).