From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.3 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_IN_DEF_DKIM_WL autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5A92DC433DF for ; Sun, 11 Oct 2020 10:37:44 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0432C207F7 for ; Sun, 11 Oct 2020 10:37:43 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="fyGSM/hs" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729774AbgJKKhl (ORCPT ); Sun, 11 Oct 2020 06:37:41 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36094 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729681AbgJKKhk (ORCPT ); Sun, 11 Oct 2020 06:37:40 -0400 Received: from mail-pl1-x641.google.com (mail-pl1-x641.google.com [IPv6:2607:f8b0:4864:20::641]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7BB3CC0613D2 for ; Sun, 11 Oct 2020 03:37:40 -0700 (PDT) Received: by mail-pl1-x641.google.com with SMTP id d23so6874575pll.7 for ; Sun, 11 Oct 2020 03:37:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=IwIdQxaAvtPvdQ7kv8/2HX6fvW7PYAkceLWLP3z3+j0=; b=fyGSM/hsJOE0+XtyetgrP/4oSTaoITF9ynd40QSEjMTurJmPGVfydGEeShfrjnIx46 bt3uG5ZSkh68debo5dfPfrAp8wvNUD8IsS5GDoeO5XNxTqGfxrR/aqjxV49upHn5pqmo 6mbu4nm2PJaOkxMfymbia6RnuRZNoU4liSZ+kRwILNQ3DFil3jGHMuRWVgWadtUlG0pm UPAXkrs1YKR5H8pdQhL93YcwDIQHoxtG+uvcFRdCidW5Rpd+ksWW0Pd0pZzipCpQWQ81 VTw6Ps674GUciAn/Nmh+x6wVwiI7+rl4Wh0JXyEVpFqGEA/U4DWJ41sL6EdlEMnRWiA8 iI9g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=IwIdQxaAvtPvdQ7kv8/2HX6fvW7PYAkceLWLP3z3+j0=; b=K1fKTzJEtf3lNkroiKKrsN7ERtcMrI3Rv3YPsfSVPelOdZO5toN38SXCykTwFTy1b9 JFudDbnwSMUfyEWV6yZhHIkzkOaEX+3I51UULT1SNdsjfvL90E9a12s7xN5sqXZGcqlH ErEJ/asyabiW+oLwqtT4Ar7PjWFkgrUE0Gqt4E/7ajcZ1XqNelC3Txe0nvrmfOtQKpW/ 8nu7xgYPvB5YDS77zZo2NegBXlUSNZ7KEoBRUHpbfwk13XCtQ8zYMsb3jiey208WUQi1 TTT7CXAZnLMKD2Tk8DFnY1ctsNVI37KyewB3YaBx0TjvMubnFwd3F+ZuB0Fo25guQ4rh cYqQ== X-Gm-Message-State: AOAM530qLe6kbzcFDdh7Eli9vRmhJ8tdtnQ8M+wURvr1KoEF870LAMKs qjQACR80UiiOJh5qRcGqrSDK+DO3yuMK1G8FmEYTfA== X-Google-Smtp-Source: ABdhPJx3URKf9AYK1M9Ikngl4G/r8DiVTS1GIRSdM5JdeFin+So8Y+XY9rUA1QnFioyMCB7L+/WDBgYt7vg2IYTVf0A= X-Received: by 2002:a17:902:d716:b029:d3:8e2a:1b5d with SMTP id w22-20020a170902d716b02900d38e2a1b5dmr18272569ply.85.1602412659693; Sun, 11 Oct 2020 03:37:39 -0700 (PDT) MIME-Version: 1.0 References: <20201009170202.103512-1-a.nogikh@gmail.com> In-Reply-To: From: Andrey Konovalov Date: Sun, 11 Oct 2020 12:37:29 +0200 Message-ID: Subject: Re: [PATCH v2 0/3] [PATCH v2 0/3] [PATCH v2 0/3] net, mac80211, kernel: enable KCOV remote coverage collection for 802.11 frame handling To: Johannes Berg Cc: Aleksandr Nogikh , "David S. Miller" , kuba@kernel.org, Andrew Morton , Eric Dumazet , Dmitry Vyukov , Marco Elver , LKML , netdev , linux-wireless@vger.kernel.org, Aleksandr Nogikh Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Oct 9, 2020 at 7:13 PM Johannes Berg wr= ote: > > > > On 9 October 2020 19:01:59 CEST, Aleksandr Nogikh wr= ote: > > >This patch series conflicts with another proposed patch > >http://lkml.kernel.org/r/223901affc7bd759b2d6995c2dbfbdd0a29bc88a.160224= 8029.git.andreyknvl@google.com > >One of these patches needs to be rebased once the other one is merged. > > > Maybe that other patch shouldn't do things that way though, and add new A= PI (which the existing one could call with some kind of "all contexts" argu= ment) instead, so it's only necessary to specify the context (mask?) where = its actually needed (the few places in usb or e whatever)? > > Surely that would also look less tedious in the mac80211 code, for exampl= e. > > And if you ever fix the nesting issue you'd have fewer places to modify a= gain. Hi Johannes, I initially hesitated to do that, as it would multiply the number of kcov callbacks. But perhaps you're right and a clean API look outweighs the rest. I will do this in v3. Thanks!