From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.6 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED,USER_IN_DEF_DKIM_WL autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 43A80C43444 for ; Thu, 3 Jan 2019 18:46:34 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 08613217F5 for ; Thu, 3 Jan 2019 18:46:34 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="GoUxsewU" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726460AbfACSqd (ORCPT ); Thu, 3 Jan 2019 13:46:33 -0500 Received: from mail-pf1-f193.google.com ([209.85.210.193]:43339 "EHLO mail-pf1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726238AbfACSqc (ORCPT ); Thu, 3 Jan 2019 13:46:32 -0500 Received: by mail-pf1-f193.google.com with SMTP id w73so17058402pfk.10 for ; Thu, 03 Jan 2019 10:46:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=MgzV5dTndps76ADDi/niLj9jnEoksetg/kN5EQSE/zM=; b=GoUxsewUnTYsCM77AWfGlQfTgMINGlA35HpX38hrx1dskXw4mI65zWLT8zB5BYj6e8 dWsAYaoSKabJNGNo9wQ7kiRDOy+0ey1nWiWJLIWcYQN0z+K9h3DYz2J59oKlX+nzSTTa aT57NflI4m5PdSfbXZIhK5emMEoGtqL0F3zjVt4kHv7srAa90A8KpUyo/X4pRSfnHe45 mAT04CkeOtEEc/W2zJ2MdjjmkeoXPYwO94z4+bpJzerWLi7x1dNRRviz0FSvXA89Biog sYyO53jbmfC2HT0on1mg+NJMYZHuZQNJAPTRUv2ZWXjRpBcxKkAu8FFYEp88Z0s/Fqyd 5EJA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=MgzV5dTndps76ADDi/niLj9jnEoksetg/kN5EQSE/zM=; b=ewWhN91P2bhwN3zMo+92ksRXsvq9JiiYLJgsezyHRSp3qqwp7MdrIvIYuJ4dWeXbiN h1l5Hdf2RIp1GrZs+N3PMEvvCIFGLV3CBDK9exd6UzRaM/S9P3F8JIRZU20meVcRkOfR Nm41JNiUIEDznVw98nJzyVeObhjedMw+tZDqX/oSw5TZNbPjp0s+MAvmTf2q8MT7ks5e j6qTyOtm+pivieaRjaxIycDCkukW6iYPy+HeXAV+JJNiP6OvzzEGiLHSCI5ALcFBGCXj JYyOS0ssY3v30yaCh4dmrLlmElxwiTfI5jibnmDa4TY2HypXifsS7cep5nzL+Af+lAwN Btvg== X-Gm-Message-State: AJcUukcD8uK01UnG3t2Mg7BRf/DIs60Zhr3Y8OBC6eTiNtGmlBMhMzpD bV0A1HJfmMcal83BbM3WQjQOgOykK5vHsmUy9yChLw== X-Google-Smtp-Source: ALg8bN5SinAEs0gYR2nS6mwrBbNs6CaZLdp3j4CHwOgZ9jildDr4wOzb2uxGWuD9JrGMv17tlykPD+ZozUjLDh+fs1c= X-Received: by 2002:a65:560e:: with SMTP id l14mr18036989pgs.168.1546541191326; Thu, 03 Jan 2019 10:46:31 -0800 (PST) MIME-Version: 1.0 References: <20190102121436.5c2b72d1b0ec49affadc9692@linux-foundation.org> In-Reply-To: <20190102121436.5c2b72d1b0ec49affadc9692@linux-foundation.org> From: Andrey Konovalov Date: Thu, 3 Jan 2019 19:46:20 +0100 Message-ID: Subject: Re: [PATCH v2 1/3] kasan, arm64: use ARCH_SLAB_MINALIGN instead of manual aligning To: Andrew Morton Cc: Andrey Ryabinin , Alexander Potapenko , Dmitry Vyukov , Catalin Marinas , Will Deacon , Christoph Lameter , Mark Rutland , Nick Desaulniers , Marc Zyngier , Dave Martin , Ard Biesheuvel , "Eric W . Biederman" , Ingo Molnar , Paul Lawrence , Geert Uytterhoeven , Arnd Bergmann , "Kirill A . Shutemov" , Greg Kroah-Hartman , Kate Stewart , Mike Rapoport , Vincenzo Frascino , kasan-dev , "open list:DOCUMENTATION" , LKML , Linux ARM , linux-sparse@vger.kernel.org, Linux Memory Management List , Linux Kbuild mailing list , Kostya Serebryany , Evgeniy Stepanov , Lee Smith , Ramana Radhakrishnan , Jacob Bramley , Ruben Ayrapetyan , Jann Horn , Mark Brand , Chintan Pandya , Vishwath Mohan Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jan 2, 2019 at 9:14 PM Andrew Morton wrote: > > On Wed, 2 Jan 2019 18:36:06 +0100 Andrey Konovalov wrote: > > > Instead of changing cache->align to be aligned to KASAN_SHADOW_SCALE_SIZE > > in kasan_cache_create() we can reuse the ARCH_SLAB_MINALIGN macro. > > > > ... > > > > --- a/arch/arm64/include/asm/kasan.h > > +++ b/arch/arm64/include/asm/kasan.h > > @@ -36,6 +36,10 @@ > > #define KASAN_SHADOW_OFFSET (KASAN_SHADOW_END - (1ULL << \ > > (64 - KASAN_SHADOW_SCALE_SHIFT))) > > > > +#ifdef CONFIG_KASAN_SW_TAGS > > +#define ARCH_SLAB_MINALIGN (1ULL << KASAN_SHADOW_SCALE_SHIFT) > > +#endif > > + > > void kasan_init(void); > > void kasan_copy_shadow(pgd_t *pgdir); > > asmlinkage void kasan_early_init(void); > > diff --git a/include/linux/slab.h b/include/linux/slab.h > > index 11b45f7ae405..d87f913ab4e8 100644 > > --- a/include/linux/slab.h > > +++ b/include/linux/slab.h > > @@ -16,6 +16,7 @@ > > #include > > #include > > #include > > +#include > > > > This still seems unadvisable. Like other architectures, arm defines > ARCH_SLAB_MINALIGN in arch/arm/include/asm/cache.h. > arch/arm/include/asm64/cache.h doesn't define ARCH_SLAB_MINALIGN > afaict. > > If arch/arm/include/asm64/cache.h later gets a definition of > ARCH_SLAB_MINALIGN then we again face the risk that different .c files > will see different values of ARCH_SLAB_MINALIGN depending on which > headers they include. > > So what to say about this? The architecture's ARCH_SLAB_MINALIGN > should be defined in the architecture's cache.h, end of story. Not in > slab.h, not in kasan.h. Done in v3, thanks! > > > -- > You received this message because you are subscribed to the Google Groups "kasan-dev" group. > To unsubscribe from this group and stop receiving emails from it, send an email to kasan-dev+unsubscribe@googlegroups.com. > To post to this group, send email to kasan-dev@googlegroups.com. > To view this discussion on the web visit https://groups.google.com/d/msgid/kasan-dev/20190102121436.5c2b72d1b0ec49affadc9692%40linux-foundation.org. > For more options, visit https://groups.google.com/d/optout.