From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-23.2 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_IN_DEF_DKIM_WL autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9C0DAC433DB for ; Fri, 5 Feb 2021 17:35:38 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5290964F2E for ; Fri, 5 Feb 2021 17:35:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233348AbhBEPxE (ORCPT ); Fri, 5 Feb 2021 10:53:04 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60440 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233321AbhBEPst (ORCPT ); Fri, 5 Feb 2021 10:48:49 -0500 Received: from mail-pl1-x62e.google.com (mail-pl1-x62e.google.com [IPv6:2607:f8b0:4864:20::62e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3949DC061574 for ; Fri, 5 Feb 2021 09:30:56 -0800 (PST) Received: by mail-pl1-x62e.google.com with SMTP id u15so3936248plf.1 for ; Fri, 05 Feb 2021 09:30:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=dqdujun8wGwVR12tCa3y7+xoN9EW0D48IZceWkJl7oI=; b=bSEk/I22cujvi4qnuuPGwPinL75MBuQNwqPNQZP9tya6m4rltCMGJhtz11m0nLqw4E 9wQJ5MpoVrm+2u9PQQ2iPAN5H0vNEWnwhzm7cvOeyan9lKAqY/hurkA7fu4jQB0JKp5J chZoes3QaP9Lb8FsBAWPefFuIB+lsUqEfGAmZWMByfA9woeGw7BjaNsLawJZZsq1Ibdb cLwIlVr3G1Nwe+NzEKfLjULuoNTM5bDRitYc+wfP/pPZm0hHM0Txea4rLtPp4TnE0fts TJAjJsmtsURoteU0XgC7hqC9jCvXu5xRvvNI8hZCK7jq5w5taZngEr2G2gBUiPet8EVM 19og== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=dqdujun8wGwVR12tCa3y7+xoN9EW0D48IZceWkJl7oI=; b=ADZi+l52MToy+WeZVmUt2+1sMdjIwyvK4xG6PF2B2/GszwynV+nsBuNUfDRytrETMr pl/2AiRZefoiDIM1Z3Vumha2FHIOXWbA1AoF37bFSQ2MQALpVT4vYlIxbADvxE3n2PnS TkJsMGErHK0zHm/RceEih7twUwjh6sKnpikRtqAUdB3LnqPyFonT8Pb1X+534yJxYY7Z E9nlYultMKv9ZnXOGePAX7s/BlYCQGZ3VqC3UgzRzBuDET4mbNhH2eetjRiqTXseiBTF f4DTYH7tYtUMp+Ueh86POHkPhzAixDNyPO139OswDj1XX4+DG1FKX5sHB2nhRZrmdb2m l9mw== X-Gm-Message-State: AOAM531/epsuUKf0omqwF5ptHkVLyZPDhVMtMRod0WR8cw52uMOB9gO7 R50fEJXsaY2ADNG4uau2tBiky+a0lBK5iShwm7Iufw== X-Google-Smtp-Source: ABdhPJydJVbZuowKkuiIq7j3adPgOPz+adwLhFZiCNyj2VyHDStxbQpGwPNsujGvsVZ0emhENzvP0iBjmmwBHqfvSSw= X-Received: by 2002:a17:90b:350b:: with SMTP id ls11mr5060341pjb.166.1612546255453; Fri, 05 Feb 2021 09:30:55 -0800 (PST) MIME-Version: 1.0 References: <20210204150100.GE20815@willie-the-truck> <20210204163721.91295-1-lecopzer@gmail.com> <20210205171859.GE22665@willie-the-truck> In-Reply-To: <20210205171859.GE22665@willie-the-truck> From: Andrey Konovalov Date: Fri, 5 Feb 2021 18:30:44 +0100 Message-ID: Subject: Re: [PATCH v2 1/4] arm64: kasan: don't populate vmalloc area for CONFIG_KASAN_VMALLOC To: Will Deacon Cc: Lecopzer Chen , Andrew Morton , Ard Biesheuvel , Andrey Ryabinin , Mark Brown , Catalin Marinas , Dan Williams , Dmitry Vyukov , Alexander Potapenko , gustavoars@kernel.org, kasan-dev , Lecopzer Chen , Linux ARM , LKML , "moderated list:ARM/Mediatek SoC..." , Linux Memory Management List , Guenter Roeck , Robin Murphy , rppt@kernel.org, tyhicks@linux.microsoft.com, Vincenzo Frascino , yj.chiang@mediatek.com Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Feb 5, 2021 at 6:19 PM Will Deacon wrote: > > On Fri, Feb 05, 2021 at 12:37:21AM +0800, Lecopzer Chen wrote: > > > > > On Thu, Feb 04, 2021 at 10:46:12PM +0800, Lecopzer Chen wrote: > > > > > On Sat, Jan 09, 2021 at 06:32:49PM +0800, Lecopzer Chen wrote: > > > > > > Linux support KAsan for VMALLOC since commit 3c5c3cfb9ef4da9 > > > > > > ("kasan: support backing vmalloc space with real shadow memory") > > > > > > > > > > > > Like how the MODULES_VADDR does now, just not to early populate > > > > > > the VMALLOC_START between VMALLOC_END. > > > > > > similarly, the kernel code mapping is now in the VMALLOC area and > > > > > > should keep these area populated. > > > > > > > > > > > > Signed-off-by: Lecopzer Chen > > > > > > --- > > > > > > arch/arm64/mm/kasan_init.c | 23 ++++++++++++++++++----- > > > > > > 1 file changed, 18 insertions(+), 5 deletions(-) > > > > > > > > > > > > diff --git a/arch/arm64/mm/kasan_init.c b/arch/arm64/mm/kasan_init.c > > > > > > index d8e66c78440e..39b218a64279 100644 > > > > > > --- a/arch/arm64/mm/kasan_init.c > > > > > > +++ b/arch/arm64/mm/kasan_init.c > > > > > > @@ -214,6 +214,7 @@ static void __init kasan_init_shadow(void) > > > > > > { > > > > > > u64 kimg_shadow_start, kimg_shadow_end; > > > > > > u64 mod_shadow_start, mod_shadow_end; > > > > > > + u64 vmalloc_shadow_start, vmalloc_shadow_end; > > > > > > phys_addr_t pa_start, pa_end; > > > > > > u64 i; > > > > > > > > > > > > @@ -223,6 +224,9 @@ static void __init kasan_init_shadow(void) > > > > > > mod_shadow_start = (u64)kasan_mem_to_shadow((void *)MODULES_VADDR); > > > > > > mod_shadow_end = (u64)kasan_mem_to_shadow((void *)MODULES_END); > > > > > > > > > > > > + vmalloc_shadow_start = (u64)kasan_mem_to_shadow((void *)VMALLOC_START); > > > > > > + vmalloc_shadow_end = (u64)kasan_mem_to_shadow((void *)VMALLOC_END); > > > > > > + > > > > > > /* > > > > > > * We are going to perform proper setup of shadow memory. > > > > > > * At first we should unmap early shadow (clear_pgds() call below). > > > > > > @@ -241,12 +245,21 @@ static void __init kasan_init_shadow(void) > > > > > > > > > > > > kasan_populate_early_shadow(kasan_mem_to_shadow((void *)PAGE_END), > > > > > > (void *)mod_shadow_start); > > > > > > - kasan_populate_early_shadow((void *)kimg_shadow_end, > > > > > > - (void *)KASAN_SHADOW_END); > > > > > > + if (IS_ENABLED(CONFIG_KASAN_VMALLOC)) { > > > > > > > > > > Do we really need yet another CONFIG option for KASAN? What's the use-case > > > > > for *not* enabling this if you're already enabling one of the KASAN > > > > > backends? > > > > > > > > As I know, KASAN_VMALLOC now only supports KASAN_GENERIC and also > > > > KASAN_VMALLOC uses more memory to map real shadow memory (1/8 of vmalloc va). > > > > > > The shadow is allocated dynamically though, isn't it? > > > > Yes, but It's still a cost. > > > > > > There should be someone can enable KASAN_GENERIC but can't use VMALLOC > > > > due to memory issue. > > > > > > That doesn't sound particularly realistic to me. The reason I'm pushing here > > > is because I would _really_ like to move to VMAP stack unconditionally, and > > > that would effectively force KASAN_VMALLOC to be set if KASAN is in use. > > > > > > So unless there's a really good reason not to do that, please can we make > > > this unconditional for arm64? Pretty please? > > > > I think it's fine since we have a good reason. > > Also if someone have memory issue in KASAN_VMALLOC, > > they can use SW_TAG, right? > > > > However the SW_TAG/HW_TAG is not supported VMALLOC yet. > > So the code would be like > > > > if (IS_ENABLED(CONFIG_KASAN_GENERIC)) > > Just make this CONFIG_KASAN_VMALLOC, since that depends on KASAN_GENERIC. > > > /* explain the relationship between > > * KASAN_GENERIC and KASAN_VMALLOC in arm64 > > * XXX: because we want VMAP stack.... > > */ > > I don't understand the relation with SW_TAGS. The VMAP_STACK dependency is: > > depends on !KASAN || KASAN_HW_TAGS || KASAN_VMALLOC This means that VMAP_STACK can be only enabled if KASAN_HW_TAGS=y or if KASAN_VMALLOC=y for other modes. > > which doesn't mention SW_TAGS at all. So that seems to imply that SW_TAGS > and VMAP_STACK are mutually exclusive :( SW_TAGS doesn't yet have vmalloc support, so it's not compatible with VMAP_STACK. Once vmalloc support is added to SW_TAGS, KASAN_VMALLOC should be allowed to be enabled with SW_TAGS. This series is a step towards having that support, but doesn't implement it. That will be a separate effort.