From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.3 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_IN_DEF_DKIM_WL autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9AF79C07E9B for ; Tue, 20 Jul 2021 04:37:25 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 78F5D611C1 for ; Tue, 20 Jul 2021 04:37:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S245421AbhGTD4g (ORCPT ); Mon, 19 Jul 2021 23:56:36 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49872 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239282AbhGTD43 (ORCPT ); Mon, 19 Jul 2021 23:56:29 -0400 Received: from mail-pj1-x1034.google.com (mail-pj1-x1034.google.com [IPv6:2607:f8b0:4864:20::1034]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C7402C061574 for ; Mon, 19 Jul 2021 21:37:04 -0700 (PDT) Received: by mail-pj1-x1034.google.com with SMTP id gx2so1905025pjb.5 for ; Mon, 19 Jul 2021 21:37:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=BbJ5l/mzifntQdZgcoAMozoV8xnurm7BXOSvdrIxbhg=; b=mq949U1s2+kAYZI0X3lgUoNXTGjhIZkrl7UOL0sPaK2QLJ/i/YLoHlNHs/Kasexq9o aonmjdVagasMfgKQ7UHxzTrkrwCiIIsnXbg9DfmeDxLkHUkV37XBWcNWfZj0Swx9vqWi ELkbuloc5D29K6er/zFevAbSakKTLFOqO24nHFIql+8yx+A8Wn06QH0MMn3AeD2dL+nb /IXgREyPLNTEf7yoCCZ3ltix3nR2xw2/zeoNg6ioFHOxGt5XBwvD1Kk0pA2IqKJUo75O 23yfUcc9Eu7N1aV1wduxNTFPcCd6d70zGzujjMQMG3URPmmx+2KUYp+U0Z7mcdzLYXl6 iBhA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=BbJ5l/mzifntQdZgcoAMozoV8xnurm7BXOSvdrIxbhg=; b=LmPXKzHr9FeMFbfNW4cXRxL4px8D0NF1AnkiQQ/P1IJYdyWd70HgVAh/lvKEzc5KwT vSmR7Ezdlxuveq5pM6+Zdh4B6a5A6i1oOlDxPrkSmLvSCu5omjdaaAzI/fDOCVqCJd2g ZU14NYTyiCG+cZLzS2g+WsleGTGFbOWeFNPdfj2UUMkW06PuOcu3CollFDyONpLbR++F nDTA1mGWNTId4IfbQFy8+MzaZIsPbQacL/pk3Jngq1hIVVZ/LmSfRJrM6bnft1+NAzr0 evq/HUaf4OllTegiQH9z/znfCVFL7zL9ED8X5mVEjeonMeq5wgq4nAG3VJHjyrmsDyhm YWQg== X-Gm-Message-State: AOAM532pKAEHKT/orJwi9nNLQD4Uh2gD250n6epoBOYmD7pijMuBUFfe b6Su+DrrEGPH4Y4CrpKAY0ySNqdKQeAisxWw72VeQw== X-Google-Smtp-Source: ABdhPJxVYzjLwg+WrH2DJ++AV1AOi2rqP2W42mIUyF1Blf/p9WzgLzJ4wqRstvUbJYWqQh3FCWDRx57OJD7EJ8N01dM= X-Received: by 2002:a17:902:8484:b029:101:7016:fb7b with SMTP id c4-20020a1709028484b02901017016fb7bmr21740363plo.23.1626755824154; Mon, 19 Jul 2021 21:37:04 -0700 (PDT) MIME-Version: 1.0 References: <20210713163324.627647-1-seanjc@google.com> <20210713163324.627647-46-seanjc@google.com> In-Reply-To: <20210713163324.627647-46-seanjc@google.com> From: Reiji Watanabe Date: Mon, 19 Jul 2021 21:36:48 -0700 Message-ID: Subject: Re: [PATCH v2 45/46] KVM: SVM: Drop redundant clearing of vcpu->arch.hflags at INIT/RESET To: Sean Christopherson Cc: Paolo Bonzini , Vitaly Kuznetsov , Wanpeng Li , Jim Mattson , Joerg Roedel , kvm@vger.kernel.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jul 13, 2021 at 9:35 AM Sean Christopherson wrote: > > Drop redundant clears of vcpu->arch.hflags in init_vmcb() now that > init_vmcb() is invoked only through kvm_vcpu_reset(), which always clears > hflags. And of course, the second clearing in init_vmcb() was always > redundant. > > Suggested-by: Reiji Watanabe > Signed-off-by: Sean Christopherson Reviewed-by: Reiji Watanabe Thank you for removing the redundant code. Regards, Reiji