From: Chunyan Zhang <zhang.lyra@gmail.com>
To: Rob Herring <robh@kernel.org>
Cc: "Chunyan Zhang" <chunyan.zhang@spreadtrum.com>,
"Mark Rutland" <mark.rutland@arm.com>,
"gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
"Catalin Marinas" <catalin.marinas@arm.com>,
"Will Deacon" <will.deacon@arm.com>,
"Arnd Bergmann" <arnd@arndb.de>,
"Orson Zhai (翟京)" <orson.zhai@spreadtrum.com>,
"Sudeep Holla" <sudeep.holla@arm.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH V3 3/4] dt-bindings: serial: add a new compatible string for SC9860
Date: Fri, 3 Mar 2017 18:48:54 +0800 [thread overview]
Message-ID: <CAAfSe-sgeG9WdxyJE25Bn3xYcp=AHTAtGob0xVJmvoLPkduPEw@mail.gmail.com> (raw)
In-Reply-To: <20170303062149.xeernsjqhipwk7tq@rob-hp-laptop>
On 3 March 2017 at 14:21, Rob Herring <robh@kernel.org> wrote:
> On Thu, Mar 02, 2017 at 02:22:09PM +0800, Chunyan Zhang wrote:
>> SC9860 use the same serial device, so added a new compatible string to
>> support SC9860 as well, also added an example of how to describe this
>> serial device in DT.
>>
>> Signed-off-by: Chunyan Zhang <chunyan.zhang@spreadtrum.com>
>> ---
>> Documentation/devicetree/bindings/serial/sprd-uart.txt | 15 ++++++++++++++-
>> 1 file changed, 14 insertions(+), 1 deletion(-)
>>
>> diff --git a/Documentation/devicetree/bindings/serial/sprd-uart.txt b/Documentation/devicetree/bindings/serial/sprd-uart.txt
>> index 2aff0f2..8bd8144 100644
>> --- a/Documentation/devicetree/bindings/serial/sprd-uart.txt
>> +++ b/Documentation/devicetree/bindings/serial/sprd-uart.txt
>> @@ -1,7 +1,20 @@
>> * Spreadtrum serial UART
>>
>> Required properties:
>> -- compatible: must be "sprd,sc9836-uart"
>> +- compatible must contain:
>> + * "sprd,sc9836-uart" for SC9836 and all Spreadtrum SoCs
>> + This also can be specific with:
>> + * "sprd,sc9860-uart" for SC9860
>
> Just say:
>
> - compatible: must be one of:
> "sprd,sc9836-uart"
> "sprd,sc9860-uart", "sprd,sc9836-uart"
>
>> +
>> - reg: offset and length of the register set for the device
>> - interrupts: exactly one interrupt specifier
>> - clocks: phandles to input clocks.
>> +
>> +Example:
>> + uart0: serial@70000000 {
>> + compatible = "sprd,sc9860-uart",
>> + "sprd,sc9836-uart";
>> + reg = <0x000000 0x100>;
>
> unit address doesn't match the reg property.
OK, I will revise dts file accordingly.
Thanks,
Chunyan
>
>> + interrupts = <GIC_SPI 2 IRQ_TYPE_LEVEL_HIGH>;
>> + clocks = <&ext_26m>;
>> + };
>> --
>> 2.7.4
>>
prev parent reply other threads:[~2017-03-03 11:54 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-02 6:22 [PATCH V3 0/4] Add Spreadtrum SP9860G support Chunyan Zhang
2017-03-02 6:22 ` [PATCH V3 4/4] serial: sprd: adjust TIMEOUT to a big value Chunyan Zhang
[not found] ` <1488435730-6711-2-git-send-email-chunyan.zhang@spreadtrum.com>
2017-03-02 16:22 ` [PATCH V3 1/4] arm64: dts: Add basic DT to support Spreadtrum's SP9860G Mathieu Poirier
[not found] ` <1488435730-6711-4-git-send-email-chunyan.zhang@spreadtrum.com>
2017-03-03 6:21 ` [PATCH V3 3/4] dt-bindings: serial: add a new compatible string for SC9860 Rob Herring
2017-03-03 10:48 ` Chunyan Zhang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAAfSe-sgeG9WdxyJE25Bn3xYcp=AHTAtGob0xVJmvoLPkduPEw@mail.gmail.com' \
--to=zhang.lyra@gmail.com \
--cc=arnd@arndb.de \
--cc=catalin.marinas@arm.com \
--cc=chunyan.zhang@spreadtrum.com \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=orson.zhai@spreadtrum.com \
--cc=robh@kernel.org \
--cc=sudeep.holla@arm.com \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).