From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1752051AbeEGIHD (ORCPT <rfc822;w@1wt.eu>);
        Mon, 7 May 2018 04:07:03 -0400
Received: from mail-lf0-f41.google.com ([209.85.215.41]:45090 "EHLO
        mail-lf0-f41.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1751940AbeEGIG7 (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Mon, 7 May 2018 04:06:59 -0400
X-Google-Smtp-Source: AB8JxZo2xm2yhzDzf2SOQ06sawEqxpnd9PLKsYHczsN58ds5q3ICsYk3Umnj9d/fWB4Nnjw27R2ySUH1M6upuRm4QRM=
MIME-Version: 1.0
In-Reply-To: <20180507074943.GB19313@mai>
References: <1525350452-14433-1-git-send-email-chunyan.zhang@spreadtrum.com>
 <20180507055130.GA19313@mai> <CAAfSe-uBy00gR+Upcc1aO0LWwLMGT-WrCmt4oo_SiEXUcW+PuA@mail.gmail.com>
 <20180507074943.GB19313@mai>
From: Chunyan Zhang <zhang.lyra@gmail.com>
Date: Mon, 7 May 2018 16:06:18 +0800
Message-ID: <CAAfSe-u9DHK-s40qmgAO_TDyZQVgvqkytA=5PRmGt=5Nm-mExw@mail.gmail.com>
Subject: Re: [PATCH] clocksource/drivers/sprd: Fix Kconfig dependency
To: Daniel Lezcano <daniel.lezcano@linaro.org>
Cc: Chunyan Zhang <chunyan.zhang@spreadtrum.com>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Baolin Wang <baolin.wang@spreadtrum.com>,
        Orson Zhai <orson.zhai@spreadtrum.com>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Transfer-Encoding: 8bit
X-MIME-Autoconverted: from quoted-printable to 8bit by mail.home.local id w4787Bbr005149

On 7 May 2018 at 15:49, Daniel Lezcano <daniel.lezcano@linaro.org> wrote:
> On Mon, May 07, 2018 at 02:04:38PM +0800, Chunyan Zhang wrote:
>> Hi Daniel,
>>
>> On 7 May 2018 at 13:51, Daniel Lezcano <daniel.lezcano@linaro.org> wrote:
>> > On Thu, May 03, 2018 at 08:27:32PM +0800, Chunyan Zhang wrote:
>> >> SPRD arch doesn't select SPRD_TIMER, so this config would not
>> >> appear even if ARCH_SPRD is set and COMPILE_TEST is not.
>> >>
>> >> Fix the Kconfig selection rule by letting the SPRD arch to select.
>> >
>> > Instead of changing this Kconfig, please fix the arch's Kconfig by selecting
>> > SPRD_TIMER.
>>
>> Oh, that's not my expectation, I hope we can give users permission of
>> not selecting SPRD TIMER driver even if SPRD arch is selected. (I can
>> confirm that all Spreadtrum's platforms in mainline can work without
>> this driver. An enough minimum workable system doesn't need this
>> driver indeed.)
>
> Ok, can you add the EXPERT option in addition to the bool like:

Sure, that makes more sense indeed :)

Thanks for the review,
Chunyan

>
> https://lkml.org/lkml/2018/4/3/897
>
> Thanks.
>
>   -- Daniel
>
>
> --
>
>  <http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs
>
> Follow Linaro:  <http://www.facebook.com/pages/Linaro> Facebook |
> <http://twitter.com/#!/linaroorg> Twitter |
> <http://www.linaro.org/linaro-blog/> Blog