From: Belisko Marek <marek.belisko@gmail.com>
To: Mark Brown <broonie@kernel.org>
Cc: Liam Girdwood <lgirdwood@gmail.com>,
perex@perex.cz, tiwai@suse.de,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
alsa-devel@alsa-project.org,
"Dr. H. Nikolaus Schaller" <hns@goldelico.com>
Subject: Re: [PATCH] ASoC: bt-sco: Add devicetree support for bt-sco codec
Date: Wed, 6 May 2015 21:38:55 +0200 [thread overview]
Message-ID: <CAAfyv37jOJ=grVAM22-oLx2s6-8rXr2fVbgpNqkaJjwuEsHZ9Q@mail.gmail.com> (raw)
In-Reply-To: <20150506121311.GP22845@sirena.org.uk>
Hi Mark,
On Wed, May 6, 2015 at 2:13 PM, Mark Brown <broonie@kernel.org> wrote:
> On Tue, May 05, 2015 at 10:15:41PM +0200, Marek Belisko wrote:
>
>> +static const struct of_device_id bt_sco_codec_of_match[] = {
>> + { .compatible = "delta,dfbmcs320", },
>> + { .compatible = "linux,bt-sco", },
>
> Is there any burning reason for adding the linux,bt-sco compatible?
No no real reason just want to keep that if somebody would like use it from DT
referenced by bt-sco entry (similar as platform data). I'm adding DT
support for it because I want to use
this for W2CBW003 chip and I can use simply "linux,bt-sco" property in
DT or I instead of that add new vendor
prefix + add new compatible entry which is IMO much harder that
reference it by generic name.
Thanks,
marek
--
as simple and primitive as possible
-------------------------------------------------
Marek Belisko - OPEN-NANDRA
Freelance Developer
Ruska Nova Ves 219 | Presov, 08005 Slovak Republic
Tel: +421 915 052 184
skype: marekwhite
twitter: #opennandra
web: http://open-nandra.com
next prev parent reply other threads:[~2015-05-06 19:39 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-05 20:15 [PATCH] ASoC: bt-sco: Add devicetree support for bt-sco codec Marek Belisko
2015-05-06 12:13 ` Mark Brown
2015-05-06 19:38 ` Belisko Marek [this message]
2015-05-08 18:06 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAAfyv37jOJ=grVAM22-oLx2s6-8rXr2fVbgpNqkaJjwuEsHZ9Q@mail.gmail.com' \
--to=marek.belisko@gmail.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=hns@goldelico.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=perex@perex.cz \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).