From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0E3C3C0650F for ; Tue, 30 Jul 2019 12:16:33 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id D90CA2089E for ; Tue, 30 Jul 2019 12:16:32 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=brainfault-org.20150623.gappssmtp.com header.i=@brainfault-org.20150623.gappssmtp.com header.b="RcEyHgsu" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730009AbfG3MQb (ORCPT ); Tue, 30 Jul 2019 08:16:31 -0400 Received: from mail-wm1-f67.google.com ([209.85.128.67]:54330 "EHLO mail-wm1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729518AbfG3MQa (ORCPT ); Tue, 30 Jul 2019 08:16:30 -0400 Received: by mail-wm1-f67.google.com with SMTP id p74so56906199wme.4 for ; Tue, 30 Jul 2019 05:16:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=brainfault-org.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=iCWEmw5uxTuTJM5Fn9CAHniCyIMMG4EL6XrLjBjgqU8=; b=RcEyHgsukWeHJWoW0g1tULEyN+REkaDBS0hPbWb+PVgj21FsAiJFooBKPafQGCQT4k Oe7x3r0UWoYUkKuGQXtHOsZC7ZrYeQsDJQPhCtdqZvkYgnxuNy6VcVzzXe8ww7se6Gc0 M9g+GzB9ptSlWbp4AsgoGzauTqZB2tLn6pneb3x2VfvezxPKSRD5ctSTCYZI6F7nNg5Q kTom1CS4D1/Ew4fjK0ZO9TSBUj9psnOiA1fMRYFpHn0E32yFj3GO0qLecTJ0lRrfMzWF jcbyhSInAQWXs8cU/NADw+cye/IMLF+AO67Op9zOMIRAFOVr8/ty82by4n/ajOEjRfIN h8Og== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=iCWEmw5uxTuTJM5Fn9CAHniCyIMMG4EL6XrLjBjgqU8=; b=NsIdftApzvKY9pKjEsRHpqED7vsn2LnmbDuatXsktAJ54ka8NmiMEXOxwwuy3y4niA iOtV4RzbYhO6JvcwcWZe5EGtKLXqp4rCsR3Xysy+uQ/qyNP8L+GDqygk2u1fLGmN6M7G kfa/bnQRi6vlfHRaCHkLC0Rj+VDjYXWjtzZN9lQuIn+YujImhdaXsUJ7tkNg69euPm7G 8iDu7dMwCO4uRCmeB2qG/0++8zIev/2upwzpN8R2tZR4+gAu57jwExn1Uf94QMJ/116V 4Ne+l72j6UYu6Pxoi6hvF/HuHuXQ9le7IPfay0JvaZmrv4biDYJrajWb/If8Q/6fM4y3 83tg== X-Gm-Message-State: APjAAAXr+Ah10j2fb25RbvQ72H9mN+R9WhpHby3Yi8PKRbMM8EJrpEtG Yoru4gOBXifGkgWWPmk93FIbh8dSppTcNUW0wz0= X-Google-Smtp-Source: APXvYqwoLi8AAqz+99Z48jcpAPghzt+IGo83CFyDdCeXa8lkuZwKmiu9/wvRi+usFvnPUs5v/7GdZ2sspfW5V98qygc= X-Received: by 2002:a1c:cfc5:: with SMTP id f188mr96400937wmg.24.1564488988047; Tue, 30 Jul 2019 05:16:28 -0700 (PDT) MIME-Version: 1.0 References: <20190729115544.17895-1-anup.patel@wdc.com> <20190729115544.17895-7-anup.patel@wdc.com> <3caa5b31-f5ed-98cd-2bdf-88d8cb837919@redhat.com> <536673cd-3b84-4e56-6042-de73a536653f@redhat.com> <9f84c328-c5ad-b3cc-df0f-05f113476341@redhat.com> In-Reply-To: <9f84c328-c5ad-b3cc-df0f-05f113476341@redhat.com> From: Anup Patel Date: Tue, 30 Jul 2019 17:46:16 +0530 Message-ID: Subject: Re: [RFC PATCH 06/16] RISC-V: KVM: Implement KVM_GET_ONE_REG/KVM_SET_ONE_REG ioctls To: Paolo Bonzini Cc: Anup Patel , Palmer Dabbelt , Paul Walmsley , Radim K , Daniel Lezcano , Thomas Gleixner , Atish Patra , Alistair Francis , Damien Le Moal , Christoph Hellwig , "kvm@vger.kernel.org" , "linux-riscv@lists.infradead.org" , "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jul 30, 2019 at 5:40 PM Paolo Bonzini wrote: > > On 30/07/19 14:08, Anup Patel wrote: > >> Still, I would prefer all the VS CSRs to be accessible via the get/set > >> reg ioctls. > > We had implemented VS CSRs access to user-space but then we > > removed it to keep this series simple and easy to review. We thought > > of adding it later when we deal with Guest/VM migration. > > > > Do you want it to be added as part of this series ? > > Yes, please. It's not enough code to deserve a separate patch, and it > is useful for debugging. Sure, I will add it in v2 series. We have skipped Guest FP ONE_REG interface with same rationale. We should add that as well. Agree ? Regards, Anup