From: Anup Patel <anup@brainfault.org>
To: Paul Walmsley <paul.walmsley@sifive.com>
Cc: Anup Patel <Anup.Patel@wdc.com>,
Palmer Dabbelt <palmer@dabbelt.com>,
Albert Ou <aou@eecs.berkeley.edu>,
Atish Patra <Atish.Patra@wdc.com>,
Alistair Francis <Alistair.Francis@wdc.com>,
Christoph Hellwig <hch@lst.de>,
"linux-riscv@lists.infradead.org"
<linux-riscv@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] RISC-V: Add debug defconfigs
Date: Fri, 6 Dec 2019 04:53:36 +0530 [thread overview]
Message-ID: <CAAhSdy0VXuhqXnEHTMwYKfDKQt2c5fU=ejXuz54c6LvwLRew_A@mail.gmail.com> (raw)
In-Reply-To: <alpine.DEB.2.21.9999.1912051512590.239155@viisi.sifive.com>
On Fri, Dec 6, 2019 at 4:44 AM Paul Walmsley <paul.walmsley@sifive.com> wrote:
>
> On Thu, 5 Dec 2019, Anup Patel wrote:
>
> > On Thu, Dec 5, 2019 at 10:31 PM Paul Walmsley <paul.walmsley@sifive.com> wrote:
> >
> > > What leads you to conclude that this was done for SiFive internal use?
> >
> > Why else you need it ?
>
> Suppose you were to assume that I had reasons for doing it that aren't
> related to SiFive. What might they be?
It does not matter what your reasons were. Having DEBUG options in
defconfigs is not the right way to do it.
I have posted v2 of this patch. Please have a look. It's much cleaner
now and does not have performance impact for people using defconfigs.
Regards,
Anup
prev parent reply other threads:[~2019-12-05 23:23 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-05 0:56 [PATCH] RISC-V: Add debug defconfigs Anup Patel
2019-12-05 3:03 ` Paul Walmsley
2019-12-05 16:33 ` Anup Patel
2019-12-05 16:47 ` Daniel Thompson
2019-12-05 17:09 ` Anup Patel
2019-12-05 17:01 ` Paul Walmsley
2019-12-05 17:05 ` Anup Patel
2019-12-05 23:14 ` Paul Walmsley
2019-12-05 23:23 ` Anup Patel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAAhSdy0VXuhqXnEHTMwYKfDKQt2c5fU=ejXuz54c6LvwLRew_A@mail.gmail.com' \
--to=anup@brainfault.org \
--cc=Alistair.Francis@wdc.com \
--cc=Anup.Patel@wdc.com \
--cc=Atish.Patra@wdc.com \
--cc=aou@eecs.berkeley.edu \
--cc=hch@lst.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=palmer@dabbelt.com \
--cc=paul.walmsley@sifive.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).