From: Anup Patel <anup@brainfault.org>
To: Marc Zyngier <maz@kernel.org>
Cc: Palmer Dabbelt <palmer@dabbelt.com>,
Palmer Dabbelt <palmerdabbelt@google.com>,
Paul Walmsley <paul.walmsley@sifive.com>,
Thomas Gleixner <tglx@linutronix.de>,
Daniel Lezcano <daniel.lezcano@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
Atish Patra <atish.patra@wdc.com>,
Alistair Francis <Alistair.Francis@wdc.com>,
linux-riscv <linux-riscv@lists.infradead.org>,
"linux-kernel@vger.kernel.org List"
<linux-kernel@vger.kernel.org>, DTML <devicetree@vger.kernel.org>,
Anup Patel <anup.patel@wdc.com>
Subject: Re: [RFC PATCH v2 00/11] Linux RISC-V ACLINT Support
Date: Mon, 26 Jul 2021 18:15:20 +0530 [thread overview]
Message-ID: <CAAhSdy3E56j9XBfNr93AdW62mEx40F9F4-SYbNEFdkKA2BWRqA@mail.gmail.com> (raw)
In-Reply-To: <20210618123851.1344518-1-anup.patel@wdc.com>
Hi Marc,
I have taken the approach of IPI domains (like you suggested) in this series.
What do you think ?
Regards,
Anup
On Fri, Jun 18, 2021 at 6:09 PM Anup Patel <anup.patel@wdc.com> wrote:
>
> Most of the existing RISC-V platforms use SiFive CLINT to provide M-level
> timer and IPI support whereas S-level uses SBI calls for timer and IPI
> support. Also, the SiFive CLINT device is a single device providing both
> timer and IPI functionality so RISC-V platforms can't partially implement
> SiFive CLINT device and provide alternate mechanism for timer and IPI.
>
> The RISC-V Advacned Core Local Interruptor (ACLINT) tries to address the
> limitations of SiFive CLINT by:
> 1) Taking modular approach and defining timer and IPI functionality as
> separate devices so that RISC-V platforms can include only required
> devices
> 2) Providing dedicated MMIO device for S-level IPIs so that SBI calls
> can be avoided for IPIs in Linux RISC-V
> 3) Allowing multiple instances of timer and IPI devices for a
> multi-socket (or multi-die) NUMA systems
> 4) Being backward compatible to SiFive CLINT so that existing RISC-V
> platforms stay compliant with RISC-V ACLINT specification
>
> Latest RISC-V ACLINT specification (will be frozen in a month) can be
> found at:
> https://github.com/riscv/riscv-aclint/blob/main/riscv-aclint.adoc
>
> This series adds RISC-V ACLINT support and can be found in riscv_aclint_v2
> branch at:
> https://github.com/avpatel/linux
>
> To test this series, the RISC-V ACLINT support for QEMU and OpenSBI
> can be found in the riscv_aclint_v1 branch at:
> https://github.com/avpatel/qemu
> https://github.com/avpatel/opensbi
>
> Changes since v1:
> - Added a new PATCH3 to treat IPIs as normal Linux IRQs for RISC-V kernel
> - New SBI IPI call based irqchip driver in PATCH3 which is only initialized
> by riscv_ipi_setup() when no Linux IRQ numbers are available for IPIs
> - Moved DT bindings patches before corresponding driver patches
> - Implemented ACLINT SWI driver as a irqchip driver in PATCH7
> - Minor nit fixes pointed by Bin Meng
>
> Anup Patel (11):
> RISC-V: Clear SIP bit only when using SBI IPI operations
> RISC-V: Use common print prefix in smp.c
> RISC-V: Treat IPIs as normal Linux IRQs
> RISC-V: Allow marking IPIs as suitable for remote FENCEs
> RISC-V: Use IPIs for remote TLB flush when possible
> dt-bindings: interrupt-controller: Add ACLINT MSWI and SSWI bindings
> irqchip: Add ACLINT software interrupt driver
> RISC-V: Select ACLINT SWI driver for virt machine
> dt-bindings: timer: Add ACLINT MTIMER bindings
> clocksource: clint: Add support for ACLINT MTIMER device
> MAINTAINERS: Add entry for RISC-V ACLINT drivers
>
> .../riscv,aclint-swi.yaml | 82 ++++++
> .../bindings/timer/riscv,aclint-mtimer.yaml | 55 ++++
> MAINTAINERS | 9 +
> arch/riscv/Kconfig | 1 +
> arch/riscv/Kconfig.socs | 1 +
> arch/riscv/include/asm/sbi.h | 2 +
> arch/riscv/include/asm/smp.h | 48 +++-
> arch/riscv/kernel/Makefile | 1 +
> arch/riscv/kernel/cpu-hotplug.c | 2 +
> arch/riscv/kernel/irq.c | 1 +
> arch/riscv/kernel/sbi-ipi.c | 223 ++++++++++++++
> arch/riscv/kernel/sbi.c | 15 -
> arch/riscv/kernel/smp.c | 171 +++++------
> arch/riscv/kernel/smpboot.c | 4 +-
> arch/riscv/mm/tlbflush.c | 62 +++-
> drivers/clocksource/timer-clint.c | 58 ++--
> drivers/irqchip/Kconfig | 11 +
> drivers/irqchip/Makefile | 1 +
> drivers/irqchip/irq-aclint-swi.c | 271 ++++++++++++++++++
> drivers/irqchip/irq-riscv-intc.c | 55 ++--
> 20 files changed, 879 insertions(+), 194 deletions(-)
> create mode 100644 Documentation/devicetree/bindings/interrupt-controller/riscv,aclint-swi.yaml
> create mode 100644 Documentation/devicetree/bindings/timer/riscv,aclint-mtimer.yaml
> create mode 100644 arch/riscv/kernel/sbi-ipi.c
> create mode 100644 drivers/irqchip/irq-aclint-swi.c
>
> --
> 2.25.1
>
next prev parent reply other threads:[~2021-07-26 12:45 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-18 12:38 [RFC PATCH v2 00/11] Linux RISC-V ACLINT Support Anup Patel
2021-06-18 12:38 ` [RFC PATCH v2 01/11] RISC-V: Clear SIP bit only when using SBI IPI operations Anup Patel
2021-06-18 12:38 ` [RFC PATCH v2 02/11] RISC-V: Use common print prefix in smp.c Anup Patel
2021-07-26 13:44 ` Marc Zyngier
2021-07-26 15:22 ` Anup Patel
2021-06-18 12:38 ` [RFC PATCH v2 03/11] RISC-V: Treat IPIs as normal Linux IRQs Anup Patel
2021-06-18 12:38 ` [RFC PATCH v2 04/11] RISC-V: Allow marking IPIs as suitable for remote FENCEs Anup Patel
2021-06-18 12:38 ` [RFC PATCH v2 05/11] RISC-V: Use IPIs for remote TLB flush when possible Anup Patel
2021-06-18 12:38 ` [RFC PATCH v2 06/11] dt-bindings: interrupt-controller: Add ACLINT MSWI and SSWI bindings Anup Patel
2021-07-12 19:22 ` Rob Herring
2021-07-13 15:27 ` Anup Patel
2021-07-27 6:32 ` Sean Anderson
2021-06-18 12:38 ` [RFC PATCH v2 07/11] irqchip: Add ACLINT software interrupt driver Anup Patel
2021-07-26 14:25 ` Marc Zyngier
2021-07-26 16:05 ` Anup Patel
2021-06-18 12:38 ` [RFC PATCH v2 08/11] RISC-V: Select ACLINT SWI driver for virt machine Anup Patel
2021-06-18 12:38 ` [RFC PATCH v2 09/11] dt-bindings: timer: Add ACLINT MTIMER bindings Anup Patel
2021-06-18 12:38 ` [RFC PATCH v2 10/11] clocksource: clint: Add support for ACLINT MTIMER device Anup Patel
2021-06-18 12:38 ` [RFC PATCH v2 11/11] MAINTAINERS: Add entry for RISC-V ACLINT drivers Anup Patel
2021-07-26 12:45 ` Anup Patel [this message]
2021-07-26 14:32 ` [RFC PATCH v2 00/11] Linux RISC-V ACLINT Support Marc Zyngier
2021-07-26 13:01 ` Anup Patel
2021-07-29 4:30 ` Palmer Dabbelt
2021-07-29 4:56 ` Anup Patel
2021-07-29 5:36 ` Anup Patel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAAhSdy3E56j9XBfNr93AdW62mEx40F9F4-SYbNEFdkKA2BWRqA@mail.gmail.com \
--to=anup@brainfault.org \
--cc=Alistair.Francis@wdc.com \
--cc=anup.patel@wdc.com \
--cc=atish.patra@wdc.com \
--cc=daniel.lezcano@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=maz@kernel.org \
--cc=palmer@dabbelt.com \
--cc=palmerdabbelt@google.com \
--cc=paul.walmsley@sifive.com \
--cc=robh+dt@kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).