From: Anup Patel <anup@brainfault.org>
To: "hch@infradead.org" <hch@infradead.org>
Cc: Atish Patra <Atish.Patra@wdc.com>,
"aou@eecs.berkeley.edu" <aou@eecs.berkeley.edu>,
"gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
Anup Patel <Anup.Patel@wdc.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"alexios.zavras@intel.com" <alexios.zavras@intel.com>,
"palmer@sifive.com" <palmer@sifive.com>,
"paul.walmsley@sifive.com" <paul.walmsley@sifive.com>,
"linux-riscv@lists.infradead.org"
<linux-riscv@lists.infradead.org>,
"allison@lohutok.net" <allison@lohutok.net>
Subject: Re: [PATCH] RISC-V: Issue a local tlb flush if possible.
Date: Mon, 19 Aug 2019 20:39:02 +0530 [thread overview]
Message-ID: <CAAhSdy3KLCW540mLVk4F6nAqYP2dYuiGqO4FuwTD1Hra_gHcGg@mail.gmail.com> (raw)
In-Reply-To: <20190819144627.GA27061@infradead.org>
On Mon, Aug 19, 2019 at 8:16 PM hch@infradead.org <hch@infradead.org> wrote:
>
> On Thu, Aug 15, 2019 at 08:37:04PM +0000, Atish Patra wrote:
> > We get ton of them. Here is the stack dump.
>
> Looks like we might not need to flush anything at all here as the
> mm_struct was never scheduled to run on any cpu?
If we were using ASID then yes we don't need to flush anything
but currently we don't use ASID due to lack of HW support and
HW can certainly do speculatively page table walks so flushing
local TLB when MM mask is empty might help.
This just my theory and we need to stress test more.
Regards,
Anup
next prev parent reply other threads:[~2019-08-19 15:09 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-10 1:43 [PATCH] RISC-V: Issue a local tlb flush if possible Atish Patra
2019-08-10 3:30 ` Anup Patel
2019-08-10 5:28 ` Atish Patra
2019-08-10 6:37 ` Andreas Schwab
2019-08-10 9:21 ` Atish Patra
2019-08-12 14:56 ` Christoph Hellwig
2019-08-13 0:15 ` Atish Patra
2019-08-13 14:30 ` hch
2019-08-15 20:37 ` Atish Patra
2019-08-19 14:46 ` hch
2019-08-19 15:09 ` Anup Patel [this message]
2019-08-19 15:10 ` hch
2019-08-20 0:02 ` Atish Patra
2019-08-12 15:36 ` Troy Benjegerdes
2019-08-12 17:13 ` Atish Patra
2019-08-12 17:55 ` Christoph Hellwig
2019-08-13 18:25 ` Paul Walmsley
2019-08-14 1:49 ` Atish Patra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAAhSdy3KLCW540mLVk4F6nAqYP2dYuiGqO4FuwTD1Hra_gHcGg@mail.gmail.com \
--to=anup@brainfault.org \
--cc=Anup.Patel@wdc.com \
--cc=Atish.Patra@wdc.com \
--cc=alexios.zavras@intel.com \
--cc=allison@lohutok.net \
--cc=aou@eecs.berkeley.edu \
--cc=gregkh@linuxfoundation.org \
--cc=hch@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=palmer@sifive.com \
--cc=paul.walmsley@sifive.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).