From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5CF47C2B9F8 for ; Tue, 25 May 2021 12:32:48 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 33D4361404 for ; Tue, 25 May 2021 12:32:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232518AbhEYMeQ (ORCPT ); Tue, 25 May 2021 08:34:16 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48874 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232230AbhEYMeP (ORCPT ); Tue, 25 May 2021 08:34:15 -0400 Received: from mail-wr1-x42c.google.com (mail-wr1-x42c.google.com [IPv6:2a00:1450:4864:20::42c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 189DEC061756 for ; Tue, 25 May 2021 05:32:45 -0700 (PDT) Received: by mail-wr1-x42c.google.com with SMTP id v12so32065581wrq.6 for ; Tue, 25 May 2021 05:32:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=brainfault-org.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=sFy/LCaXB1SRilva8CJ6mi6jxkEQV+dWKl9QiGNHUsg=; b=s2myp/MyFCHOHtpxco8bZqGgOkPGygWKSZEMO5NAtVwE7ob5u1K956l3GFDdI8BvXp 6huP+HAe5CK3gwN1qVuy1yHJgr5u1dVVw844eZ4sUbKonuWYdz7uDbugoZn7ZPs1Pijh RbxX8EkV57WppSRghckgfI2u2zN49d7zF0mrxQWOQevslGVYdY+W5vNXe/K6tY41C+GL 4gD18WUuLnhhTN19n0BJxOF6Z2aY/EJ2Gqed5nPh6W1riNawh/tLQcBEp/+rhWKYfs2Z Uk+XNOTGlJ3BlTkWJnbNqo1hdeDOAb78BDm7BZsf2uwGyjXnG1AwvQ0MsayaKfHJ+tEQ KYoQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=sFy/LCaXB1SRilva8CJ6mi6jxkEQV+dWKl9QiGNHUsg=; b=RNTsJnMb7GlgAvw6jahRXbgt/xw2J8YGSQEuUWvHPn6K/CeVTWx95+PCpZBQLuMGmo UTSF9gk+4Um+hjvhzp3RkMSoNGbZXuSk6vJWIVXOQqt19iNcIi6/FRLM8wkn/92waG8q kGzqC1JNixnTUioD8UhfclG3ksZPp3G040+gs2tG2FIjQTTvlHK5HjixDXdquLHvrnDG ElP0J0uw5Ce8iW9j+7UHn+B4eoEoWIYY+BFMV9vB/bNKITiTNbbMyMtw7zR9N/fX01xk kvIS1MYG0eLWZ/sU+3z8t1m4O/9Wy8XSLN2RDgKXOY43urT0Q6s3Rra6Nat3gyEkAU8Z KS2g== X-Gm-Message-State: AOAM533ItlY1Og+J5tQbgbHqtkse6ozAXRkSz3x4Q8xPFC3AYBiqhgVI Mm1nvtyzPBITCOLVsxerhBBFjnWIxIKAJBtTwYRn2UN4WfW9cw== X-Google-Smtp-Source: ABdhPJwmnDH3iFAvmCNe+NjWKkYYKkEISVmzhPeoZ89aTiS5cvv29wco+Is3CTtZH/UHKJezW1DX4vg3l9OBcF2kkmY= X-Received: by 2002:adf:e38c:: with SMTP id e12mr26636946wrm.128.1621945963328; Tue, 25 May 2021 05:32:43 -0700 (PDT) MIME-Version: 1.0 References: <1621945234-37878-1-git-send-email-guoren@kernel.org> In-Reply-To: <1621945234-37878-1-git-send-email-guoren@kernel.org> From: Anup Patel Date: Tue, 25 May 2021 18:02:31 +0530 Message-ID: Subject: Re: [PATCH] arch: Cleanup unused functions To: Guo Ren Cc: Anup Patel , Palmer Dabbelt , Arnd Bergmann , Christoph Hellwig , linux-riscv , "linux-kernel@vger.kernel.org List" , linux-arch , linux-sunxi@lists.linux.dev, Guo Ren , Michal Simek Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, May 25, 2021 at 5:52 PM wrote: > > From: Guo Ren > > These functions haven't been used, so just remove them. The patch > has been tested with riscv, but I only use grep to check the > microblaze's. > > Signed-off-by: Guo Ren > Cc: Arnd Bergmann > Cc: Michal Simek > Cc: Christoph Hellwig Looks good to me. Reviewed-by: Anup Patel Regards, Anup > --- > arch/microblaze/include/asm/page.h | 3 --- > arch/riscv/include/asm/page.h | 10 ---------- > 2 files changed, 13 deletions(-) > > diff --git a/arch/microblaze/include/asm/page.h b/arch/microblaze/include/asm/page.h > index bf681f2..ce55097 100644 > --- a/arch/microblaze/include/asm/page.h > +++ b/arch/microblaze/include/asm/page.h > @@ -35,9 +35,6 @@ > > #define ARCH_SLAB_MINALIGN L1_CACHE_BYTES > > -#define PAGE_UP(addr) (((addr)+((PAGE_SIZE)-1))&(~((PAGE_SIZE)-1))) > -#define PAGE_DOWN(addr) ((addr)&(~((PAGE_SIZE)-1))) > - > /* > * PAGE_OFFSET -- the first address of the first page of memory. With MMU > * it is set to the kernel start address (aligned on a page boundary). > diff --git a/arch/riscv/include/asm/page.h b/arch/riscv/include/asm/page.h > index 6a7761c..a1b888f 100644 > --- a/arch/riscv/include/asm/page.h > +++ b/arch/riscv/include/asm/page.h > @@ -37,16 +37,6 @@ > > #ifndef __ASSEMBLY__ > > -#define PAGE_UP(addr) (((addr)+((PAGE_SIZE)-1))&(~((PAGE_SIZE)-1))) > -#define PAGE_DOWN(addr) ((addr)&(~((PAGE_SIZE)-1))) > - > -/* align addr on a size boundary - adjust address up/down if needed */ > -#define _ALIGN_UP(addr, size) (((addr)+((size)-1))&(~((size)-1))) > -#define _ALIGN_DOWN(addr, size) ((addr)&(~((size)-1))) > - > -/* align addr on a size boundary - adjust address up if needed */ > -#define _ALIGN(addr, size) _ALIGN_UP(addr, size) > - > #define clear_page(pgaddr) memset((pgaddr), 0, PAGE_SIZE) > #define copy_page(to, from) memcpy((to), (from), PAGE_SIZE) > > -- > 2.7.4 >