From: Huacai Chen <chenhc@lemote.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: "Rafael J . Wysocki" <rafael@kernel.org>,
Sudeep Holla <sudeep.holla@arm.com>,
LKML <linux-kernel@vger.kernel.org>, zhangfx <zhangfx@lemote.com>,
wu zhangjin <wuzhangjin@gmail.com>
Subject: Re: [PATCH V2] cacheinfo: Keep the old value if of_property_read_u32 fails
Date: Mon, 12 Nov 2018 10:52:39 +0800 [thread overview]
Message-ID: <CAAhV-H72Yf86sEBykk=ziAr+6+ttT=GRWK5DnyFpNFqccoAahQ@mail.gmail.com> (raw)
In-Reply-To: <20181111192901.GA8332@kroah.com>
On Mon, Nov 12, 2018 at 3:29 AM Greg Kroah-Hartman
<gregkh@linuxfoundation.org> wrote:
>
> On Fri, Oct 19, 2018 at 09:31:29PM +0800, Huacai Chen wrote:
> > Commit 448a5a552f336bd7b847b1951 ("drivers: base: cacheinfo: use OF
> > property_read_u32 instead of get_property,read_number") makes cache
> > size and number_of_sets be 0 if DT doesn't provide there values. I
> > think this is unreasonable so make them keep the old values, which is
> > the same as old kernels.
> >
> > Fixes: 448a5a552f33 ("drivers: base: cacheinfo: use OF property_read_u32 instead of get_property,read_number")
> > Signed-off-by: Huacai Chen <chenhc@lemote.com>
> > Reviewed-by: Sudeep Holla <sudeep.holla@arm.com>
> > ---
> > drivers/base/cacheinfo.c | 6 ++----
> > 1 file changed, 2 insertions(+), 4 deletions(-)
>
> What changed from v1? Always put that below the --- line.
Hi, Greg,
V2 just add a Fixes line and Reviewed-by line, no functional changes.
Huacai
>
> Please fix this up and resend a v3.
>
> thanks,
>
> greg k-h
prev parent reply other threads:[~2018-11-12 2:46 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-19 13:31 [PATCH V2] cacheinfo: Keep the old value if of_property_read_u32 fails Huacai Chen
2018-11-11 19:29 ` Greg Kroah-Hartman
2018-11-12 2:52 ` Huacai Chen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAAhV-H72Yf86sEBykk=ziAr+6+ttT=GRWK5DnyFpNFqccoAahQ@mail.gmail.com' \
--to=chenhc@lemote.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rafael@kernel.org \
--cc=sudeep.holla@arm.com \
--cc=wuzhangjin@gmail.com \
--cc=zhangfx@lemote.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).