From: JoonSoo Kim <js1304@gmail.com>
To: Minchan Kim <minchan@kernel.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
linux-kernel@vger.kernel.org, linux-mm@kvack.org,
Peter Zijlstra <a.p.zijlstra@chello.nl>
Subject: Re: [PATCH 0/5] minor clean-up and optimize highmem related code
Date: Thu, 1 Nov 2012 02:11:42 +0900 [thread overview]
Message-ID: <CAAmzW4N+Pe_+MdLCjfVyw5Lih=vPeJj-+hLQuikp33OV_0SoiA@mail.gmail.com> (raw)
In-Reply-To: <CAAmzW4OboOMD+yrAim4-H_LBC439iYat=gwfxcn5M1gvcRyz=w@mail.gmail.com>
Hello, Andrew.
2012/10/29 JoonSoo Kim <js1304@gmail.com>:
> Hi, Minchan.
>
> 2012/10/29 Minchan Kim <minchan@kernel.org>:
>> Hi Joonsoo,
>>
>> On Mon, Oct 29, 2012 at 04:12:51AM +0900, Joonsoo Kim wrote:
>>> This patchset clean-up and optimize highmem related code.
>>>
>>> [1] is just clean-up and doesn't introduce any functional change.
>>> [2-3] are for clean-up and optimization.
>>> These eliminate an useless lock opearation and list management.
>>> [4-5] is for optimization related to flush_all_zero_pkmaps().
>>>
>>> Joonsoo Kim (5):
>>> mm, highmem: use PKMAP_NR() to calculate an index of pkmap
>>> mm, highmem: remove useless pool_lock
>>> mm, highmem: remove page_address_pool list
>>> mm, highmem: makes flush_all_zero_pkmaps() return index of last
>>> flushed entry
>>> mm, highmem: get virtual address of the page using PKMAP_ADDR()
>>
>> This patchset looks awesome to me.
>> If you have a plan to respin, please CCed Peter.
>
> Thanks for review.
> I will wait more review and respin, the day after tomorrow.
> Version 2 will include fix about your comment.
Could you pick up second version of this patchset?
[3] is changed to leave one blank line.
[4] is changed in order to further optimize according to Minchan's comment.
It return first index of flushed entry, instead of last index.
Others doesn't changed.
next prev parent reply other threads:[~2012-10-31 17:11 UTC|newest]
Thread overview: 146+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <Yes>
2012-07-16 16:14 ` [PATCH 1/3] mm: correct return value of migrate_pages() Joonsoo Kim
2012-07-16 16:14 ` [PATCH 2/3] mm: fix possible incorrect return value of migrate_pages() syscall Joonsoo Kim
2012-07-16 17:26 ` Christoph Lameter
2012-07-16 17:40 ` Michal Nazarewicz
2012-07-16 17:59 ` JoonSoo Kim
2012-07-17 13:02 ` Michal Nazarewicz
2012-07-16 16:14 ` [PATCH 3/3] mm: fix return value in __alloc_contig_migrate_range() Joonsoo Kim
2012-07-16 17:29 ` Christoph Lameter
2012-07-16 17:40 ` Michal Nazarewicz
2012-07-16 18:40 ` JoonSoo Kim
2012-07-17 13:16 ` Michal Nazarewicz
2012-07-16 17:14 ` [PATCH 4] mm: fix possible incorrect return value of move_pages() syscall Joonsoo Kim
2012-07-16 17:30 ` Christoph Lameter
2012-07-16 17:23 ` [PATCH 1/3] mm: correct return value of migrate_pages() Christoph Lameter
2012-07-16 17:32 ` JoonSoo Kim
2012-07-16 17:37 ` Christoph Lameter
2012-07-16 17:40 ` Michal Nazarewicz
2012-07-16 17:57 ` JoonSoo Kim
2012-07-16 18:05 ` Christoph Lameter
2012-07-17 12:33 ` [PATCH 1/4 v2] mm: correct return value of migrate_pages() and migrate_huge_pages() Joonsoo Kim
2012-07-17 12:33 ` [PATCH 2/4 v2] mm: fix possible incorrect return value of migrate_pages() syscall Joonsoo Kim
2012-07-17 14:28 ` Christoph Lameter
2012-07-17 15:41 ` JoonSoo Kim
2012-07-17 12:33 ` [PATCH 3/4 v2] mm: fix return value in __alloc_contig_migrate_range() Joonsoo Kim
2012-07-17 13:25 ` Michal Nazarewicz
2012-07-17 15:45 ` JoonSoo Kim
2012-07-17 15:49 ` [PATCH 3/4 v3] " Joonsoo Kim
2012-07-17 12:33 ` [PATCH 4/4 v2] mm: fix possible incorrect return value of move_pages() syscall Joonsoo Kim
2012-07-27 17:55 ` [RESEND PATCH 1/4 v3] mm: correct return value of migrate_pages() and migrate_huge_pages() Joonsoo Kim
2012-07-27 17:55 ` [RESEND PATCH 2/4 v3] mm: fix possible incorrect return value of migrate_pages() syscall Joonsoo Kim
2012-07-27 20:57 ` Christoph Lameter
2012-07-28 6:16 ` JoonSoo Kim
2012-07-30 19:30 ` Christoph Lameter
2012-07-27 17:55 ` [RESEND PATCH 3/4 v3] mm: fix return value in __alloc_contig_migrate_range() Joonsoo Kim
2012-07-27 17:55 ` [RESEND PATCH 4/4 v3] mm: fix possible incorrect return value of move_pages() syscall Joonsoo Kim
2012-07-27 20:54 ` Christoph Lameter
2012-07-28 6:09 ` JoonSoo Kim
2012-07-30 19:29 ` Christoph Lameter
2012-07-31 3:34 ` JoonSoo Kim
2012-07-31 14:04 ` Christoph Lameter
2012-08-01 5:15 ` Michael Kerrisk
2012-08-01 18:00 ` Christoph Lameter
2012-08-02 5:52 ` Michael Kerrisk
2012-08-13 16:17 ` [PATCH 1/5] workqueue: use enum value to set array size of pools in gcwq Joonsoo Kim
2012-08-13 16:17 ` [PATCH 2/5] workqueue: change value of lcpu in queue_delayed_work_on() Joonsoo Kim
2012-08-13 16:32 ` Tejun Heo
2012-08-13 16:54 ` JoonSoo Kim
2012-08-13 17:03 ` Tejun Heo
2012-08-13 17:43 ` JoonSoo Kim
2012-08-13 18:00 ` Tejun Heo
2012-08-14 18:04 ` JoonSoo Kim
2012-08-13 16:17 ` [PATCH 3/5] workqueue: introduce system_highpri_wq Joonsoo Kim
2012-08-13 16:17 ` [PATCH 4/5] workqueue: use system_highpri_wq for highpri workers in rebind_workers() Joonsoo Kim
2012-08-13 16:34 ` Tejun Heo
2012-08-13 16:57 ` JoonSoo Kim
2012-08-13 17:05 ` Tejun Heo
2012-08-13 17:45 ` JoonSoo Kim
2012-08-13 16:17 ` [PATCH 5/5] workqueue: use system_highpri_wq for unbind_work Joonsoo Kim
2012-08-13 16:36 ` Tejun Heo
2012-08-13 17:02 ` JoonSoo Kim
2012-08-13 17:07 ` Tejun Heo
2012-08-13 17:52 ` JoonSoo Kim
2012-08-14 18:10 ` [PATCH v2 0/6] system_highpri_wq Joonsoo Kim
2012-08-14 18:10 ` [PATCH v2 1/6] workqueue: use enum value to set array size of pools in gcwq Joonsoo Kim
2012-08-14 18:10 ` [PATCH v2 2/6] workqueue: correct req_cpu in trace_workqueue_queue_work() Joonsoo Kim
2012-08-14 18:34 ` Tejun Heo
2012-08-14 18:56 ` JoonSoo Kim
2012-08-14 18:10 ` [PATCH v2 3/6] workqueue: change value of lcpu in __queue_delayed_work_on() Joonsoo Kim
2012-08-14 19:00 ` Tejun Heo
2012-08-14 18:10 ` [PATCH v2 4/6] workqueue: introduce system_highpri_wq Joonsoo Kim
2012-08-14 18:10 ` [PATCH v2 5/6] workqueue: use system_highpri_wq for highpri workers in rebind_workers() Joonsoo Kim
2012-08-14 18:29 ` Tejun Heo
2012-08-14 18:10 ` [PATCH v2 6/6] workqueue: use system_highpri_wq for unbind_work Joonsoo Kim
2012-08-15 14:25 ` [PATCH v3 0/6] system_highpri_wq Joonsoo Kim
2012-08-15 14:25 ` [PATCH v3 1/6] workqueue: use enum value to set array size of pools in gcwq Joonsoo Kim
2012-08-15 14:25 ` [PATCH v3 2/6] workqueue: correct req_cpu in trace_workqueue_queue_work() Joonsoo Kim
2012-08-15 14:25 ` [PATCH v3 3/6] workqueue: change value of lcpu in __queue_delayed_work_on() Joonsoo Kim
2012-08-15 14:25 ` [PATCH v3 4/6] workqueue: introduce system_highpri_wq Joonsoo Kim
2012-08-15 14:25 ` [PATCH v3 5/6] workqueue: use system_highpri_wq for highpri workers in rebind_workers() Joonsoo Kim
2012-08-15 14:25 ` [PATCH v3 6/6] workqueue: use system_highpri_wq for unbind_work Joonsoo Kim
2012-08-16 21:22 ` [PATCH v3 0/6] system_highpri_wq Tejun Heo
2012-08-17 13:38 ` JoonSoo Kim
2012-08-24 16:05 ` [PATCH 1/2] slub: rename cpu_partial to max_cpu_object Joonsoo Kim
2012-08-24 16:05 ` [PATCH 2/2] slub: correct the calculation of the number of cpu objects in get_partial_node Joonsoo Kim
2012-08-24 16:15 ` Christoph Lameter
2012-08-24 16:28 ` JoonSoo Kim
2012-08-24 16:31 ` Christoph Lameter
2012-08-24 16:40 ` JoonSoo Kim
2012-08-24 16:12 ` [PATCH 1/2] slub: rename cpu_partial to max_cpu_object Christoph Lameter
2012-08-25 14:11 ` [PATCH 1/2] slab: do ClearSlabPfmemalloc() for all pages of slab Joonsoo Kim
2012-08-25 14:11 ` [PATCH 2/2] slab: fix starting index for finding another object Joonsoo Kim
2012-09-03 10:08 ` [PATCH 1/2] slab: do ClearSlabPfmemalloc() for all pages of slab Mel Gorman
2012-10-18 23:18 ` [PATCH 0/2] clean-up initialization of deferrable timer Joonsoo Kim
2012-10-18 23:18 ` [PATCH 1/2] timer: add setup_timer_deferrable() macro Joonsoo Kim
2012-10-18 23:18 ` [PATCH 2/2] timer: use new " Joonsoo Kim
2012-10-26 14:08 ` [PATCH 0/2] clean-up initialization of deferrable timer JoonSoo Kim
2012-10-20 15:48 ` [PATCH for-v3.7 1/2] slub: optimize poorly inlined kmalloc* functions Joonsoo Kim
2012-10-20 15:48 ` [PATCH for-v3.7 2/2] slub: optimize kmalloc* inlining for GFP_DMA Joonsoo Kim
2012-10-22 14:31 ` Christoph Lameter
2012-10-23 2:29 ` JoonSoo Kim
2012-10-23 6:16 ` Eric Dumazet
2012-10-23 16:12 ` JoonSoo Kim
2012-10-24 8:05 ` [PATCH for-v3.7 1/2] slub: optimize poorly inlined kmalloc* functions Pekka Enberg
2012-10-24 13:36 ` Christoph Lameter
2012-10-20 16:30 ` [PATCH 0/3] workqueue: minor cleanup Joonsoo Kim
2012-10-20 16:30 ` [PATCH 1/3] workqueue: optimize mod_delayed_work_on() when @delay == 0 Joonsoo Kim
2012-10-20 16:30 ` [PATCH 2/3] workqueue: trivial fix for return statement in work_busy() Joonsoo Kim
2012-10-20 22:53 ` Tejun Heo
2012-10-20 16:30 ` [PATCH 3/3] workqueue: remove unused argument of wq_worker_waking_up() Joonsoo Kim
2012-10-20 22:57 ` Tejun Heo
2012-10-23 1:44 ` JoonSoo Kim
2012-10-24 19:14 ` Tejun Heo
2012-10-28 19:12 ` [PATCH 0/5] minor clean-up and optimize highmem related code Joonsoo Kim
2012-10-28 19:12 ` [PATCH 1/5] mm, highmem: use PKMAP_NR() to calculate an index of pkmap Joonsoo Kim
2012-10-29 1:48 ` Minchan Kim
2012-10-28 19:12 ` [PATCH 2/5] mm, highmem: remove useless pool_lock Joonsoo Kim
2012-10-29 1:52 ` Minchan Kim
2012-10-30 21:31 ` Andrew Morton
2012-10-31 5:14 ` Minchan Kim
2012-10-31 15:01 ` JoonSoo Kim
2012-10-28 19:12 ` [PATCH 3/5] mm, highmem: remove page_address_pool list Joonsoo Kim
2012-10-29 1:57 ` Minchan Kim
2012-10-28 19:12 ` [PATCH 4/5] mm, highmem: makes flush_all_zero_pkmaps() return index of last flushed entry Joonsoo Kim
2012-10-29 2:06 ` Minchan Kim
2012-10-29 13:12 ` JoonSoo Kim
2012-10-28 19:12 ` [PATCH 5/5] mm, highmem: get virtual address of the page using PKMAP_ADDR() Joonsoo Kim
2012-10-29 2:09 ` Minchan Kim
2012-10-29 2:12 ` [PATCH 0/5] minor clean-up and optimize highmem related code Minchan Kim
2012-10-29 13:15 ` JoonSoo Kim
2012-10-31 17:11 ` JoonSoo Kim [this message]
2012-10-31 16:56 ` [PATCH v2 " Joonsoo Kim
2012-10-31 16:56 ` [PATCH v2 1/5] mm, highmem: use PKMAP_NR() to calculate an index of pkmap Joonsoo Kim
2012-10-31 16:56 ` [PATCH v2 2/5] mm, highmem: remove useless pool_lock Joonsoo Kim
2012-10-31 16:56 ` [PATCH v2 3/5] mm, highmem: remove page_address_pool list Joonsoo Kim
2012-10-31 16:56 ` [PATCH v2 4/5] mm, highmem: makes flush_all_zero_pkmaps() return index of first flushed entry Joonsoo Kim
2012-11-01 5:03 ` Minchan Kim
2012-11-02 19:07 ` JoonSoo Kim
2012-11-02 22:42 ` Minchan Kim
2012-11-13 0:30 ` JoonSoo Kim
2012-11-13 12:49 ` Minchan Kim
2012-11-13 14:12 ` JoonSoo Kim
2012-11-13 15:01 ` Minchan Kim
2012-11-14 17:09 ` JoonSoo Kim
2012-11-19 23:46 ` Minchan Kim
2012-11-27 15:01 ` JoonSoo Kim
2012-10-31 16:56 ` [PATCH v2 5/5] mm, highmem: get virtual address of the page using PKMAP_ADDR() Joonsoo Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAAmzW4N+Pe_+MdLCjfVyw5Lih=vPeJj-+hLQuikp33OV_0SoiA@mail.gmail.com' \
--to=js1304@gmail.com \
--cc=a.p.zijlstra@chello.nl \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=minchan@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).