From: Joonsoo Kim <js1304@gmail.com>
To: Mike Kravetz <mike.kravetz@oracle.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Linux Memory Management List <linux-mm@kvack.org>,
LKML <linux-kernel@vger.kernel.org>,
kernel-team@lge.com, Vlastimil Babka <vbabka@suse.cz>,
Christoph Hellwig <hch@infradead.org>,
Roman Gushchin <guro@fb.com>,
Naoya Horiguchi <n-horiguchi@ah.jp.nec.com>,
Michal Hocko <mhocko@suse.com>,
Joonsoo Kim <iamjoonsoo.kim@lge.com>
Subject: Re: [PATCH 03/11] mm/hugetlb: introduce alloc_control structure to simplify migration target allocation APIs
Date: Fri, 22 May 2020 14:52:45 +0900 [thread overview]
Message-ID: <CAAmzW4N7f5WbcJbhEdPq2W+6xOpdMR_5jDRU_3UmZK_VOBvZnw@mail.gmail.com> (raw)
In-Reply-To: <3499673c-d103-bb69-5f38-8cce8e659a85@oracle.com>
2020년 5월 22일 (금) 오전 3:57, Mike Kravetz <mike.kravetz@oracle.com>님이 작성:
>
> On 5/17/20 6:20 PM, js1304@gmail.com wrote:
> > From: Joonsoo Kim <iamjoonsoo.kim@lge.com>
> >
> > Currently, page allocation functions for migration requires some arguments.
> > More worse, in the following patch, more argument will be needed to unify
> > the similar functions. To simplify them, in this patch, unified data
> > structure that controls allocation behaviour is introduced.
>
> As a followup to Roman's question and your answer about adding a suffix/prefix
> to the new structure. It 'may' be a bit confusing as alloc_context is already
> defined and *ac is passsed around for page allocations. Perhaps, this new
> structure could somehow have migrate in the name as it is all about allocating
> migrate targets?
I have considered that but I cannot find appropriate prefix. In hugetlb code,
struct alloc_control is passed to the internal function which is not
fully dedicated
to the migration so 'migrate' would not be appropriate prefix.
alloc_context is used by page allocation core and alloc_control would be used by
outside of it so I think that we can endure it. If there is a good
suggestion, I will change
the name happily.
> >
> > For clean-up, function declarations are re-ordered.
> >
> > Note that, gfp_mask handling on alloc_huge_page_(node|nodemask) is
> > slightly changed, from ASSIGN to OR. It's safe since caller of these
> > functions doesn't pass extra gfp_mask except htlb_alloc_mask().
> >
> > Signed-off-by: Joonsoo Kim <iamjoonsoo.kim@lge.com>
>
> Patch makes sense.
Thanks!
> > diff --git a/mm/migrate.c b/mm/migrate.c
> > index a298a8c..94d2386 100644
> > --- a/mm/migrate.c
> > +++ b/mm/migrate.c
> > @@ -1526,10 +1526,15 @@ struct page *new_page_nodemask(struct page *page,
> > unsigned int order = 0;
> > struct page *new_page = NULL;
> >
> > - if (PageHuge(page))
> > - return alloc_huge_page_nodemask(
> > - page_hstate(compound_head(page)),
> > - preferred_nid, nodemask);
> > + if (PageHuge(page)) {
> > + struct hstate *h = page_hstate(page);
>
> I assume the removal of compound_head(page) was intentional? Just asking
> because PageHuge will look at head page while page_hstate will not. So,
> if passed a non-head page things could go bad.
I was thinking that page_hstate() can handle the tail page but it seems that
it's not. Thanks for correction. I will change it on next version.
Thanks.
next prev parent reply other threads:[~2020-05-22 5:52 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-18 1:20 [PATCH 00/11] clean-up the migration target allocation functions js1304
2020-05-18 1:20 ` [PATCH 01/11] mm/page_isolation: prefer the node of the source page js1304
2020-05-21 0:37 ` Roman Gushchin
2020-05-21 1:18 ` Joonsoo Kim
2020-05-27 6:45 ` Joonsoo Kim
2020-05-18 1:20 ` [PATCH 02/11] mm/migrate: move migration helper from .h to .c js1304
2020-05-21 18:17 ` Mike Kravetz
2020-05-18 1:20 ` [PATCH 03/11] mm/hugetlb: introduce alloc_control structure to simplify migration target allocation APIs js1304
2020-05-21 0:43 ` Roman Gushchin
2020-05-21 1:20 ` Joonsoo Kim
2020-05-21 18:57 ` Mike Kravetz
2020-05-22 5:52 ` Joonsoo Kim [this message]
2020-05-18 1:20 ` [PATCH 04/11] mm/hugetlb: unify hugetlb migration callback function js1304
2020-05-21 0:46 ` Roman Gushchin
2020-05-21 1:22 ` Joonsoo Kim
2020-05-21 20:54 ` Mike Kravetz
2020-05-22 7:38 ` Joonsoo Kim
2020-05-18 1:20 ` [PATCH 05/11] mm/hugetlb: make hugetlb migration target allocation APIs CMA aware js1304
2020-05-21 21:43 ` Mike Kravetz
2020-05-18 1:20 ` [PATCH 06/11] mm/hugetlb: do not modify user provided gfp_mask js1304
2020-05-21 22:19 ` Mike Kravetz
2020-05-22 7:42 ` Joonsoo Kim
2020-05-18 1:20 ` [PATCH 07/11] mm/migrate: change the interface of the migration target alloc/free functions js1304
2020-05-18 1:20 ` [PATCH 08/11] mm/migrate: make standard migration target allocation functions js1304
2020-05-18 1:20 ` [PATCH 09/11] mm/gup: use standard migration target allocation function js1304
2020-05-18 1:20 ` [PATCH 10/11] mm/mempolicy: " js1304
2020-05-18 1:20 ` [PATCH 11/11] mm/page_alloc: use standard migration target allocation function directly js1304
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAAmzW4N7f5WbcJbhEdPq2W+6xOpdMR_5jDRU_3UmZK_VOBvZnw@mail.gmail.com \
--to=js1304@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=guro@fb.com \
--cc=hch@infradead.org \
--cc=iamjoonsoo.kim@lge.com \
--cc=kernel-team@lge.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@suse.com \
--cc=mike.kravetz@oracle.com \
--cc=n-horiguchi@ah.jp.nec.com \
--cc=vbabka@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).