From: Joonsoo Kim <js1304@gmail.com>
To: Vlastimil Babka <vbabka@suse.cz>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Linux Memory Management List <linux-mm@kvack.org>,
LKML <linux-kernel@vger.kernel.org>,
Johannes Weiner <hannes@cmpxchg.org>,
Michal Hocko <mhocko@kernel.org>,
Minchan Kim <minchan@kernel.org>,
Mel Gorman <mgorman@techsingularity.net>,
kernel-team@lge.com, Ye Xiaolong <xiaolong.ye@intel.com>,
Joonsoo Kim <iamjoonsoo.kim@lge.com>
Subject: Re: [PATCH v2 2/2] mm/page_alloc: integrate classzone_idx and high_zoneidx
Date: Fri, 20 Mar 2020 16:40:42 +0900 [thread overview]
Message-ID: <CAAmzW4NJd2kh8-81sYLjRR8gcsmLpndhS4s5Jh6kB-FLM-wNKg@mail.gmail.com> (raw)
In-Reply-To: <99196b17-24fb-8990-2d21-c459d2321747@suse.cz>
2020년 3월 19일 (목) 오후 9:32, Vlastimil Babka <vbabka@suse.cz>님이 작성:
>
> On 3/18/20 4:32 AM, js1304@gmail.com wrote:
> > From: Joonsoo Kim <iamjoonsoo.kim@lge.com>
> >
> > classzone_idx is just different name for high_zoneidx now.
> > So, integrate them and add some comment to struct alloc_context
> > in order to reduce future confusion about the meaning of this variable.
> >
> > In addition to integration, this patch also renames high_zoneidx
> > to highest_zoneidx since it represents more precise meaning.
>
> 2 years ago I suggested max_zone_idx.
> Not insisting, but perhaps max_zoneidx would simply be shorter than
> highest_zoneidx, while saying the same thing?
I think that highest_zoneidx looks more familiar than max_zoneidx since
it is previously high_zoneidx. It would cause less confusion.
> Also I wonder if we still need the accessor ac_classzone_idx() (before rename),
> or just replace it with ac->highest_zoneidx (or whatever the final name is)
> instead of renaming it?
Okay. Looks like we don't need the accessor. I will use open-code.
Thanks.
prev parent reply other threads:[~2020-03-20 7:40 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-18 3:32 [PATCH v2 0/2] integrate classzone_idx and high_zoneidx js1304
2020-03-18 3:32 ` [PATCH v2 1/2] mm/page_alloc: use ac->high_zoneidx for classzone_idx js1304
2020-03-18 21:29 ` David Rientjes
2020-03-19 8:57 ` Joonsoo Kim
2020-03-19 12:21 ` Vlastimil Babka
2020-03-20 7:33 ` Joonsoo Kim
2020-03-19 12:29 ` Vlastimil Babka
2020-03-18 3:32 ` [PATCH v2 2/2] mm/page_alloc: integrate classzone_idx and high_zoneidx js1304
2020-03-18 3:42 ` Joonsoo Kim
2020-03-19 12:32 ` Vlastimil Babka
2020-03-20 7:40 ` Joonsoo Kim [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAAmzW4NJd2kh8-81sYLjRR8gcsmLpndhS4s5Jh6kB-FLM-wNKg@mail.gmail.com \
--to=js1304@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=hannes@cmpxchg.org \
--cc=iamjoonsoo.kim@lge.com \
--cc=kernel-team@lge.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mgorman@techsingularity.net \
--cc=mhocko@kernel.org \
--cc=minchan@kernel.org \
--cc=vbabka@suse.cz \
--cc=xiaolong.ye@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).