From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1433902AbdDZAyH (ORCPT <rfc822;w@1wt.eu>);
        Tue, 25 Apr 2017 20:54:07 -0400
Received: from mail-wr0-f193.google.com ([209.85.128.193]:35392 "EHLO
        mail-wr0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1433887AbdDZAx7 (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Tue, 25 Apr 2017 20:53:59 -0400
MIME-Version: 1.0
In-Reply-To: <20170425102440.GA491@jagdpanzerIV.localdomain>
References: <1492737291-11455-1-git-send-email-iamjoonsoo.kim@lge.com>
 <1492737291-11455-4-git-send-email-iamjoonsoo.kim@lge.com> <20170425102440.GA491@jagdpanzerIV.localdomain>
From: Joonsoo Kim <js1304@gmail.com>
Date: Wed, 26 Apr 2017 09:53:33 +0900
Message-ID: <CAAmzW4NbQd8Y-=7Js4OwLmmUOEWQt5_=XYBC-aVe_JpiTfig6A@mail.gmail.com>
Subject: Re: [PATCH v3 3/4] zram: make deduplication feature optional
To: Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
        Minchan Kim <minchan@kernel.org>,
        Sergey Senozhatsky <sergey.senozhatsky@gmail.com>,
        LKML <linux-kernel@vger.kernel.org>, kernel-team@lge.com,
        Joonsoo Kim <iamjoonsoo.kim@lge.com>
Content-Type: text/plain; charset=UTF-8
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

2017-04-25 19:24 GMT+09:00 Sergey Senozhatsky
<sergey.senozhatsky.work@gmail.com>:
> Hello,
>
> On (04/21/17 10:14), js1304@gmail.com wrote:
> [..]
>>  int zram_dedup_init(struct zram *zram, size_t num_pages);
>>  void zram_dedup_fini(struct zram *zram);
>> +#else
>> +
>> +static inline u64 zram_dedup_dup_size(struct zram *zram) { return 0; }
>> +static inline u64 zram_dedup_meta_size(struct zram *zram) { return 0; }
>> +
>> +static inline void zram_dedup_insert(struct zram *zram, struct zram_entry *new,
>> +                     u32 checksum) { }
>> +static inline struct zram_entry *zram_dedup_find(struct zram *zram,
>> +                     struct page *page, u32 *checksum) { return NULL; }
>> +
>> +static inline void zram_dedup_init_entry(struct zram *zram,
>> +                     struct zram_entry *entry, unsigned long handle,
>> +                     unsigned int len) { }
>> +static inline bool zram_dedup_put_entry(struct zram *zram,
>> +                     struct zram_entry *entry) { return true; }
>> +
>> +static inline int zram_dedup_init(struct zram *zram,
>> +                     size_t num_pages) { return 0; }
>> +static inline void zram_dedup_fini(struct zram *zram) { }
>> +
>> +#endif
>
> doesn't compile on CONFIG_ZRAM=m config.

Hello,

Good catch!
I fixed it and sent update version, v4.

Thanks.