From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756645Ab2J2NP6 (ORCPT ); Mon, 29 Oct 2012 09:15:58 -0400 Received: from mail-ob0-f174.google.com ([209.85.214.174]:50104 "EHLO mail-ob0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755685Ab2J2NP5 (ORCPT ); Mon, 29 Oct 2012 09:15:57 -0400 MIME-Version: 1.0 In-Reply-To: <20121029021219.GK15767@bbox> References: <1351451576-2611-1-git-send-email-js1304@gmail.com> <20121029021219.GK15767@bbox> Date: Mon, 29 Oct 2012 22:15:56 +0900 Message-ID: Subject: Re: [PATCH 0/5] minor clean-up and optimize highmem related code From: JoonSoo Kim To: Minchan Kim Cc: Andrew Morton , linux-kernel@vger.kernel.org, linux-mm@kvack.org, Peter Zijlstra Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, Minchan. 2012/10/29 Minchan Kim : > Hi Joonsoo, > > On Mon, Oct 29, 2012 at 04:12:51AM +0900, Joonsoo Kim wrote: >> This patchset clean-up and optimize highmem related code. >> >> [1] is just clean-up and doesn't introduce any functional change. >> [2-3] are for clean-up and optimization. >> These eliminate an useless lock opearation and list management. >> [4-5] is for optimization related to flush_all_zero_pkmaps(). >> >> Joonsoo Kim (5): >> mm, highmem: use PKMAP_NR() to calculate an index of pkmap >> mm, highmem: remove useless pool_lock >> mm, highmem: remove page_address_pool list >> mm, highmem: makes flush_all_zero_pkmaps() return index of last >> flushed entry >> mm, highmem: get virtual address of the page using PKMAP_ADDR() > > This patchset looks awesome to me. > If you have a plan to respin, please CCed Peter. Thanks for review. I will wait more review and respin, the day after tomorrow. Version 2 will include fix about your comment.